Hi @HHK1

We are encountering an issue with Swift 4.2 on our picker. https://github.com/Yummypets/YPImagePicker/issues/224

After some research, it looks like we'd need to have a pod version uploaded for PryntTrimmerView in swift 4.2.

Trying to link the dependency from the tag3.0.0-beta.1 doesn't work for some reason unfortunately :/

[!] Invalid `YPImagePicker.podspec` file: [!] Unsupported version requirements.

 #  from /Users/sacha/Projects/YPImagePicker/YPImagePicker.podspec:16
 #  -------------------------------------------
 #    s.dependency 'SteviaLayout', '~> 4.4.0'
 >    s.dependency 'PryntTrimmerView', :git => 'https://github.com/HHK1/PryntTrimmerView.git', :tag => '3.0.0-beta.1'
 #    s.resources    = ['Resources/*', 'Source/**/*.xib']
 #  -------------------------------------------

I think you'd need to push a new version for instance 2.1.0 based on 3.0.0-beta.1 code then pod trunk push.

Thanks a ton for your help :)

let visibleThumbnailsCount = Int(ceil(frame.width / thumbnailSize.width)) line gives a crash

Before this the AVAssetTimeSelector.frame gives (30.0, 88.0, 315.0, 56.0), but assetPreview.frame gives (0.0, 0.0, 0.0, 0.0). I think the problem is with frames.

Hey @HHK1, great tool you have here !

This is a feature that was requested in our media picker and some users pointed us towards you library. Just wanted to let you know that we are looking at integrating PryntTrimmerView as a dependency as part of our Media Picker tool YPImagePicker.

Begining implementation can be found: here

Let me know how you'd feel about that :)

Cheers!

Hello @HHK1,

I just adjusted the pod spec can you upload it to COCOAPODS, please?

And I added to changelog the fix of CSTime to NSValue casting, because is a brake change on XCode 12 and will be easier to see this if someone using an old version of your lib.

Thank you so much.

Douglas

Hello There,

I'm trying to load thumbnails from my video into trim view. But I have the following error: Could not calculate the thumbnail size.

This is my video's location: file:///private/var/mobile/Containers/Data/PluginKitPlugin/D7ABED4E-C54A-4948-B7D3-5587AE62358D/tmp/trim.CCA9A520-F11E-4BA6-A3A8-B15AA9E05CAC.MOV

What could be happening?

Best Regards

What is this PR for?

Change type cast CMTime to NSValue using NSValue constructor

Why are we doing this?

XCode 12.0 beta 6, iOS 14, Swift 5 Fix Compile error "Cannot convert value of type 'CMTime' to type 'NSValue in coercion"

ScreenShots

I want to create a trimmer View in a new view controller. I created a new view controller in the sample project and one view and a trimmerView in viewController. I have few doubt in this.

1. In storyboard while assigning the class to the view(brown view) Class name is display as trimmerView but while creating outlets in file trimmerView is not displaying. it is displaying as PryntTrimmerView and connection is not applicable to that view.

2. I tried to create dynamically but the properties trimmerView.asset = asset trimmerView.delegate = self trimmerView.handleColor = UIColor.white trimmerView.mainColor = UIColor.orange trimmerView.positionBarColor = UIColor.white

are not calling and not displaying in view controller. Please give suggestion to implement the Trimmerview in UiViewController and can use the properties and delegate methods to trim the video.

Thank you

/Users/joelaws/Workspace/kratos/Pods/PryntTrimmerView/PryntTrimmerView/Classes/Cropper/CropMaskView.swift:33:30: 'kCAFillRuleEvenOdd' has been renamed to 'CAShapeLayerFillRule.evenOdd'
/Users/joelaws/Workspace/kratos/Pods/QuartzCore.kCAFillRuleEvenOdd:3:12: 'kCAFillRuleEvenOdd' was obsoleted in Swift 3
/Users/joelaws/Workspace/kratos/Pods/PryntTrimmerView/PryntTrimmerView/Classes/Cropper/CropMaskView.swift:108:64: 'kCAMediaTimingFunctionEaseInEaseOut' has been renamed to 'CAMediaTimingFunctionName.easeInEaseOut'
/Users/joelaws/Workspace/kratos/Pods/QuartzCore.kCAMediaTimingFunctionEaseInEaseOut:3:12: 'kCAMediaTimingFunctionEaseInEaseOut' was obsoleted in Swift 3
/Users/joelaws/Workspace/kratos/Pods/PryntTrimmerView/PryntTrimmerView/Classes/Cropper/CropMaskView.swift:109:30: 'kCAFillModeBoth' has been renamed to 'CAMediaTimingFillMode.both'
/Users/joelaws/Workspace/kratos/Pods/QuartzCore.kCAFillModeBoth:3:12: 'kCAFillModeBoth' was obsoleted in Swift 3
/Users/joelaws/Workspace/kratos/Pods/PryntTrimmerView/PryntTrimmerView/Classes/ThumbSelectorView.swift:122:50: 'kCMTimeZero' has been renamed to 'CMTime.zero'
/Users/joelaws/Workspace/kratos/Pods/CoreMedia.kCMTimeZero:3:12: 'kCMTimeZero' was obsoleted in Swift 4.2
/Users/joelaws/Workspace/kratos/Pods/PryntTrimmerView/PryntTrimmerView/Classes/ThumbSelectorView.swift:123:51: 'kCMTimeZero' has been renamed to 'CMTime.zero'
/Users/joelaws/Workspace/kratos/Pods/CoreMedia.kCMTimeZero:3:12: 'kCMTimeZero' was obsoleted in Swift 4.2
/Users/joelaws/Workspace/kratos/Pods/PryntTrimmerView/PryntTrimmerView/Classes/Parents/AssetVideoScrollView.swift:139:65: 'AVAssetImageGeneratorResult' has been renamed to 'AVAssetImageGenerator.Result'
/Users/joelaws/Workspace/kratos/Pods/AVFoundation.AVAssetImageGeneratorResult:2:18: 'AVAssetImageGeneratorResult' was obsoleted in Swift 4.2
/Users/joelaws/Workspace/kratos/Pods/PryntTrimmerView/PryntTrimmerView/Classes/Parents/AssetVideoScrollView.swift:162:78: 'UIImageOrientation' has been renamed to 'UIImage.Orientation'
/Users/joelaws/Workspace/kratos/Pods/UIKit.UIImageOrientation:2:18: 'UIImageOrientation' was obsoleted in Swift 4.2

class AssetVideoScrollView: UIScrollView {
    private var widthConstraint: NSLayoutConstraint?

and the same error with

  @IBDesignable public class TrimmerView: AVAssetTimeSelector {
    private var leftConstraint: NSLayoutConstraint?
    private var rightConstraint: NSLayoutConstraint?

You can check it in https://github.com/Yummypets/YPImagePicker/commit/4fea39d9c3688a1ea8e36ae83dcce59a507c3e3d

Expected Results

No warning to convert PryntTrimmerView.framework to Swift 5

Actual Results

Xcode created warnings to convert PryntTrimmerView.framework to Swift 5

Steps to Reproduce

Build the cocoapod in Xcode 10.2

Hi,

I'd like to extend or use AVAssetTimeSelector and AssetVideoScrollView outside this project, basically use them to write something similar to TrimmerView. Right now I couldn't do this because the classes are not open, and some properties are internal (such as assetPreview).

Thanks

Hi!

Thanks for the awesome tool

I was reading a code related to the video cropping. There is one thing I can't wrap my head around

CGSize(width: 16 * videoCropView.aspectRatio.width * 18,
                                height: 16 * videoCropView.aspectRatio.height * 18)

Could you please explain why we need to multiple aspectRatio by 16 and 18 ?

and why scale is determined by dividing width on width let renderScale = renderSize.width / cropFrame.width

Thanks!

In this PR I updated the exclude section of the Package.swift to correctly point to the license file and the example project.

Background: as a "home" directory the SPM uses <package_folder>/Sources/<package_name_folder> path format, so in our case this is: PryntTrimmerView/Sources/PryntTrimmerView/. Therefore SPM tries to find the license and example project over there, however, these items are located two levels up in fact — in the package root.

#83

New warnings appear after building project in Xcode 13 using SPM for installation.

Invalid Exclude '.../SourcePackages/checkouts/PryntTrimmerView/Sources/PryntTrimmerView/PryntTrimmerViewExample': File not found.

Invalid Exclude '.../SourcePackages/checkouts/PryntTrimmerView/Sources/PryntTrimmerView/LICENSE': File not found.

I guess it can be removed from the exclude section in Package.swift?

Hi! When I display the asset inside the trimmerView, on the simulator all frames appear. But when I try working on a real device, only the first frame appears I am using: xCode 12.4, iOS 14.4.2