I had an issue with GLIndexedCollectionViewFlowLayout where when content offset is 0, if I were to bounce the collection (pull it to have a negative content offset on x) the offset would jump to the very end of the loaded content in the collection.

I added this:

if offsetCorrection != .greatestFiniteMagnitude {
    return CGPoint(x: proposedContentOffset.x + offsetCorrection, y: 0)
} else {
    return CGPoint(x: proposedContentOffset.x , y: 0)
}

to the final return in:

func targetContentOffset(forProposedContentOffset proposedContentOffset: , withScrollingVelocity velocity: )

Probably not the best way to handle this behavior, since I am not 100% sure why that number needs to be so high

I just wanted to bring some attention to this, as I wasn't sure if it was intended behavior to scroll to the end on a bounce at the beginning of the collection like that.

If collectionViewPaginatedScroll was true it set collectionView.isPagingEnabled to false and it was never set to true anywhere. So setting paginationEnabled inside of GLTableCollectionViewController did nothing.

Thank you for the great project!! When I tapped a collectionView, how can I get "indexPath.section"? I could get indexPath.item but indexPath.section always returns "0".

func collectionView(_ collectionView: UICollectionView, didSelectItemAt indexPath: IndexPath) { print(indexPath.section) print(indexPath.item) }

Thank you!

The pronoun "his" is for men, and "its" is for things. GLTableCollectionView is a thing, so "its" is the correct pronoun.

I want to use more than one UICollectionViewCell in the table view

Description:

I want to use more than one UICollectionViewCell in the table view but get fatal error like the custom cell didn't registered! It works just with one view cell (default cell or custom cell) but if i want to use mixed of these i got error. Thanks for your help 👍

Expected Behavior:

Show default cell with custom new cell

Actual Behavior:

Fatal error

Steps to Reproduce:

Custom cell -> GameCell.swift

import UIKit

class GameCell: UICollectionViewCell {
    
    static let id: String = "collectionViewCellID"
    
    override init(frame: CGRect) {
        super.init(frame: frame)
        setupViews()
    }
    
    required init?(coder aDecoder: NSCoder) {
        fatalError("init(coder:) has not been implemented")
    }
    
    let imageView: UIImageView = {
        let iv = UIImageView()
        iv.contentMode = .scaleAspectFill
        iv.layer.cornerRadius = 16
        iv.layer.masksToBounds = true
        iv.image = UIImage(named: "someImage")
        return iv
    }()
    
    func setupViews() {
        addSubview(imageView)
        
        imageView.frame = CGRect(x: 0, y: 0, width: frame.width, height: frame.width)
    }
}

GLCollectionTableViewCell.swift -> line 147

collectionView.register(GameCell.self, forCellWithReuseIdentifier: GameCell.id)

GLTableCollectionViewController.swift -> line 117

        if indexPath.item % 2 == 0 {
            guard let cell: GLIndexedCollectionViewCell = collectionView.dequeueReusableCell(withReuseIdentifier: GLIndexedCollectionViewCell.identifier, for: indexPath) as? GLIndexedCollectionViewCell else {
                fatalError("UICollectionViewCell must be of GLIndexedCollectionViewCell type")
            }
            cell.backgroundColor = UIColor(hue: CGFloat(indexPath.item) / 20.0, saturation: 0.8, brightness: 0.9, alpha: 1)
            return cell
        }
        else{
            guard let cell: GameCell = collectionView.dequeueReusableCell(withReuseIdentifier: GameCell.id, for: indexPath) as? GameCell else {
                fatalError("UICollectionViewCell must be of GLIndexedCollectionViewCell type")
            }
            return cell
        }

Your Environment:

• xCode: 9.4.1
• GLTableCollectionView version: Last Version
• Device: iPhone 6s (Real Device)
• iOS version: 11.4

Description:

Expected Behavior:

Actual Behavior:

Steps to Reproduce:

Your Environment:

• GLTableCollectionView version:
• Device:
• iOS version:

This PR is to reorganize the structure of the repo to separate out the classes necessary for the framework from the demo app. Everything is setup to be Carthage and Pods compatible and it is working with Carthage (needs to be registered on cocoapods.org for the pod to work). However because the library was initially designed as an app instead of a framework it is not easy to customize the behavior. The source classes will need some rework but I have yet to figure out where to begin (maybe another contributor can help out).

Hi, For iOS projets it's will be great to make your component Carthage compatible

Take a look at these articles:

• Ruthlessly Simple Dependency Management with Carthage
• Carthage Tutorial: Getting Started
• Making Carthage-compatible Frameworks with Swift
• Swift Cross Platform Framework (section Configure targets for Carthage) 👍

On your README.md add on top and add section for the installation with Carthage.

Hi Giulio!

Great Project! Do you have any writing about Add/Delete Sections and Add/Delete CollectionView Cells from user interface, can you help me please. Thanks

This PR will fix issue #30 causing the targetContentOffset(forProposedContentOffset proposedContentOffset: , withScrollingVelocity velocity: ) to return a CGPoint with x equal to .greatestFiniteMagnitude when proposedContentOffset.x was equal to 0.

Thanks to @mmdock for finding this bug 🐞 and for proposing a solution!

• Fix the "last cell" bug while using the paginated scroll mode, the bug caused the first cell opposite to the scrolling direction to snap instead of the last one.
• Comments updated
• Few minor spelling fix here and there
• Project files updated to Xcode 8.3