Changes in this pull request

Set estimatedRowHeight to 220, which is a better estimate

Issue fixed: #74

Checklist

• [x] Project builds and runs as expected.
• [x] No new linting violations have been introduced.
• [x] No new bugs have been introduced.
• [x] I have reviewed the contributing guide
• [ ] I'm attaching to this PR some screenshots (if applicable)

Changes in this pull request

Support Swift 5 Support Dark Mode Add SVProgressHud as expected Add named colors

Issue fixed:

Issues in this pull request

Markdown in proposal still light mode only

Checklist

• [x] Project builds and runs as expected.
• [x] No new linting violations have been introduced.
• [ ] No new bugs have been introduced.
• [ ] I have reviewed the contributing guide
• [ ] I'm attaching to this PR some screenshots (if applicable)

Changes in this pull request

Now that ruby 2.5 is out, it should be supported.

Luckily, this literally is a 1 character change.

Checklist

• [x] Project builds and runs as expected.
• [x] No new linting violations have been introduced.
• [x] No new bugs have been introduced.
• [x] I have reviewed the contributing guide
• [x] ~~I'm attaching to this PR some screenshots (if applicable)~~

Changes in this pull request

• Fresh icons
• iPad Support

Issue fixeds: #62 #84

Checklist

• [x] Project builds and runs as expected.
• [x] No new linting violations have been introduced.
• [x] I have reviewed the contributing guide
• [x] I'm attaching to this PR some screenshots (if applicable)

Icons

iPad Support

Portrait

Landscape

Form Sheets

Changes in this pull request

This pull request migrates used dependencies to Swift Package Manager and removes Carthage usage. I want to contribute few changes to this project and replacing Carthage with Swift Package Manager looks as a good starting point. It simplifies the process of compiling the project on a new machine.

The app should behave as previously once these changes are merged although some migration changes where needed to update to latest versions of dependencies.

Checklist

• [x] Project builds and runs as expected.
• [ ] No new linting violations have been introduced. (Didn't manage to compile project before changes)
• [x] No new bugs have been introduced.
• [x] I have reviewed the contributing guide
• [ ] I'm attaching to this PR some screenshots (if applicable)

Changes in this pull request

Changed private var downView: DownView? to public private(set) var downView: DownView? to access it in the unit tests.

A small start in unit tests can be found in the ProposalDetailViewControllerTests.swift

(ps: thanks a lot @diogot for all patience in the review)

(Not totally fixed, but started) Issue fixed: #104

Checklist

• [x] Project builds and runs as expected.
• [x] No new linting violations have been introduced.
• [x] No new bugs have been introduced.
• [x] I have reviewed the contributing guide
• [ ] I'm attaching to this PR some screenshots (if applicable)

Changes in this pull request

• Only show the proposal count after loading has finished

Before

After

Checklist

• [x] Project builds and runs as expected.
• [x] No new linting violations have been introduced.
• [x] No new bugs have been introduced.
• [x] I have reviewed the contributing guide
• [x] I'm attaching to this PR some screenshots (if applicable)

Changes in this pull request

Sorry for the big PR, I didn't write this much of code. The old rakelib is a pet project that started in MyWeight, and I ported to Swifte-evolution. Later I create a new project to make easy to be used in other projects. This project is xcode-rakelib, and I added here as git subtree.

The main advantage of use xcode-rakelib is that the project configuration is done in rake-config.yml instead of messing directly with the rakelib files. The current tasks supported are:

$ rake
rake -T
rake bump:build                         # Bump build number
rake bump:major                         # Bump major version
rake bump:minor                         # Bump minor version
rake bump:patch                         # Bump patch version
rake danger                             # Run danger
rake git:add_tag                        # Add tag with current version
rake git:push                           # Push current branch and tags
rake setup                              # Install/update and configure project
rake setup:brew                         # Update brew and install/update fo...
rake setup:bundler                      # Bundle install
rake setup:carthage                     # Carthage
rake setup:carthage_update[dependency]  # Install carthage dependencies
rake setup:cocoapods                    # CocoaPods
rake setup:pod_install                  # Pod install
rake setup:pod_repo_update              # Pod repo update
rake setup:submodules                   # Updated submodules
rake swiftgen                           # Run SwiftGen
rake swiftgen:strings                   # Generate strings
rake xcode:release[env]                 # Release
rake xcode:tests                        # Run unit tests

Another question is why git subtree instead of git submodules? With subtree, all the files are committed to the project, so there is no need to run any additional command on project setup. If we need to update to a new version of xcode-rakelib is needed to run:

git remote add -f xcode-rakelib [email protected]:diogot/xcode-rakelib.git
git fetch xcode-rakelib master
git subtree pull --prefix rakelib xcode-rakelib master --squash

But most of the users don't need to bother with this.

Otherwise, If we choose to use submodules after each git clone will be necessary to run git submodule update --init --recursive to be able to run any rake task, including rake setup. I think this is not very friendly.

The next step is to configure Danger on the CI. It looks like the project is using Bitrise but I didn't find any config file.

Checklist

• [X] Project builds and runs as expected.
• [X] No new linting violations have been introduced.
• [X] No new bugs have been introduced.
• [X] I have reviewed the contributing guide

Changes in this pull request

Issue fixed: #78

Checklist

• [x] Project builds and runs as expected.
• [x] No new linting violations have been introduced.
• [x] No new bugs have been introduced.
• [x] I have reviewed the contributing guide
• [x] I'm attaching to this PR some screenshots (if applicable)

💄

Changes in this pull request

Issue fixed: none

Checklist

• [x] Project builds and runs as expected.
• [x] No new linting violations have been introduced.
• [x] No new bugs have been introduced.
• [x] I have reviewed the contributing guide
• [x] I'm attaching to this PR some screenshots (if applicable)

Changes in this pull request

Issue fixed: #68

• Notification tracking implemented

Checklist

• [x] Project builds and runs as expected.
• [x] No new linting violations have been introduced.
• [x] No new bugs have been introduced.
• [x] I have reviewed the contributing guide
• [ ] ~I'm attaching to this PR some screenshots (if applicable)~