IBlinter says SignIn.storyboard:0:0: warning: duplicate element id 9SU-qi-UFm. But in fact, there is only one element whose id is 9SU-qi-UFm . Is this the expected behavior?

Version: 0.4.26 Using: Homebrew and CocoaPods - same result for both .iblinter.yml:

enabled_rules:
  - misplaced
  - view_as_device
  - image_resources
excluded:
  - Pods
view_as_device_rule:
  device_id: retina5_9

Search Results for9SU-qi-UFm :

• <textView clipsSubviews="YES" multipleTouchEnabled="YES" contentMode="scaleToFill" scrollEnabled="NO" showsHorizontalScrollIndicator="NO" showsVerticalScrollIndicator="NO" editable="NO" usesAttributedText="YES" translatesAutoresizingMaskIntoConstraints="NO" id="9SU-qi-UFm">
• <constraint firstItem="9SU-qi-UFm" firstAttribute="leading" secondItem="L3f-4j-PFL" secondAttribute="leading" id="TtQ-0E-1RQ"/>
• <constraint firstItem="9SU-qi-UFm" firstAttribute="centerX" secondItem="L3f-4j-PFL" secondAttribute="centerX" id="Y9A-8a-Q6E"/>
• <constraint firstItem="9SU-qi-UFm" firstAttribute="centerY" secondItem="L3f-4j-PFL" secondAttribute="centerY" id="cnK-2q-oAm"/>
• <constraint firstAttribute="trailing" secondItem="9SU-qi-UFm" secondAttribute="trailing" id="gxV-NN-gNj"/>
• <outlet property="descriptionsTextView" destination="9SU-qi-UFm" id="ar7-62-iKJ"/>

I have tried DuplicateIDRuleTests with the latest version of the source code, but it seems to be failing.

Test Suite 'DuplicateIDRuleTests' started at 2021-05-11 16:55:32.057
Test Case '-[IBLinterKitTest.DuplicateIDRuleTests testDuplicateId]' started.
/Users/wata/tmp/IBLinter/Tests/IBLinterKitTest/Rules/DuplicateIDRuleTests.swift:20: error: -[IBLinterKitTest.DuplicateIDRuleTests testDuplicateId] : XCTAssertEqual failed: ("5") is not equal to ("2")
/Users/wata/tmp/IBLinter/Tests/IBLinterKitTest/Rules/DuplicateIDRuleTests.swift:22: error: -[IBLinterKitTest.DuplicateIDRuleTests testDuplicateId] : XCTAssertEqual failed: ("["duplicate element id fullscreen", "duplicate element id iN0-l3-epB", "duplicate element id aEU-56-OK8", "duplicate element id fullscreen", "duplicate element id fullscreen"]") is not equal to ("["duplicate element id iN0-l3-epB", "duplicate element id aEU-56-OK8"]")
Test Case '-[IBLinterKitTest.DuplicateIDRuleTests testDuplicateId]' failed (0.772 seconds).
Test Suite 'DuplicateIDRuleTests' failed at 2021-05-11 16:55:32.829.
	 Executed 1 test, with 2 failures (0 unexpected) in 0.772 (0.772) seconds

after installing via cocoa pods:

xcode 10.2 / swift 5

dyld: Library not loaded: @rpath/libswiftCore.dylib
  Referenced from: XcodeProject/./Pods/IBLinter/bin/iblinter
  Reason: image not found
Abort trap: 6

reverted to 0.4.13 and it works

There is warning when installed by pods: warning: no rule to process file '/Users/.../XcodeProjects/ScriptsTest/Pods/IBLinter/bin/iblinter' of type compiled.mach-o.executable for architecture x86_64

Also I see that IBLinter hierarchy is not as swiftlint or swiftgen. Maybe that's why there is that warning.

The use case for this new flag is to only lint the files that have changed. This could help in larger projects where linting all xib/storyboard files could take a good amount of time. This is also a feature present in other linters like SwiftLint and xiblint.

Hi there

We've got one WatchKit app storyboard, that seems to cause trouble for IBLinter and causes it to crash.

The error is this:

Fatal error: parse error /path/to/project/WatchKitApp/Base.lproj/Interface.storyboard: XML Element Error: Incorrect key ["archive"]: file /Users/travis/build/IBDecodable/IBLinter/Sources/IBLinterKit/Validator.swift, line 36

The storyboard renders in Xcode properly, I've checked it with xmllint and it reported no errors. I can't even find a key called "archived" inside storyboard XML file 🤔

not sure what's the root cause.

Out of curiosity, I've removed everything from the storyboard and only this was left:

<?xml version="1.0" encoding="UTF-8"?>
<document type="com.apple.InterfaceBuilder.WatchKit.Storyboard" version="3.0" toolsVersion="14460.31" targetRuntime="watchKit" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES">

</document>

still causes the same crash.

If IBLinter was installed as pod, an empty line is displayed instead of warnings and errors. If IBLinter was installed as brew, it shows warnings and errors.

This PR adds support validating module of a placeholder or viewController. Currently we are using this tool, but I think we need to validate module in a placeholder or a ViewController.

This PR also update the related tests.

This PR is to add rules to keep "View as" device for files as specific one. "View as" is useful to confirm that constraints are working correctly on any types of devices. But sometimes we got unnecessary difference for .storyboard unexpectedly when it is left as changed from previous commit. This unexpected difference makes management of .storyboard files more complex. So I consider that it is useful to keep "View as" device at least on commits.

My storyboard has been working just fine but IBLinter reports

Resources/Base.lproj/Main.storyboard::: error: custom class name 'MainMenuController' should be 'Main' 
Resources/Base.lproj/Main.storyboard::: error: custom class name 'GameScreenController' should be 'Main' 
Resources/Base.lproj/Main.storyboard::: error: custom class name 'InfoDialogController' should be 'Main' 

I assume it is suggesting the name of the file. I don’t understand why you can’t have multiple UIViewController subclasses in a storyboard.

Hi @kateinoigakukun and @phimage.

Latest IBDecodable supported decode feature of UICollectionReusableView. This PR use it to support UICollectionReusableView in reuse_identifier rule.

~NOTE: IBDecodable not yet released as tagged version, I'll change back package dependency files after the release. That is reason I add "WIP" to PR title, but all other work are finished please review except it~ 0.2.0 is not available 👍

Detail changes description

• reuse_identifier rule support UICollectionReusableView.
• fixed unit test.
• modify storyboard fixture resource to test header and footer UICollectionReusableView.

as this project is inspired by Swiftlint - it could be easily integrated into Jenkins CI with Warnings NG Plugin when using checkstyle XML report export.

Is it possible to add this to IBLinter?

I don't see a Swift Package Manager Plugin to run IBLinter like there is now for SwiftLint and SwiftGen. I'd like to get this working for my project. Before I start on this in a couple days, has anyone already attempted it or in progress?

I would implement is as a PR to IBLinter adding directly to the existing Package.swift as done in the SwiftLint project. If you would prefer a separate project as done for SwiftGen I'd be happy to discuss the goals.

Violation messages reported by reporters don't include the violation identifier. Once such an identifier is included, it would be easy to identify and disable enabled by default rules in IBLinter.

IBLinter reporters don't print a violation rule identifier:

XXX.xib:0:0: warning: "View as:" should be Unknown device (retina3). Currently it is iPhone XR (retina6_1).

Swiftlint reporters print a violation rule identifier.

Rule.swift:44:36: error: Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)

I have it integrated as a build step for my iOS app like this:

if which iblinter >/dev/null; then
  iblinter lint
else
  echo "warning: IBLinter not installed, download from https://github.com/IBDecodable/IBLinter"
fi

And it automatically detects all .storyboards and fails with the following errors for the watch kit storyboard.

WatchKitApp/Base.lproj/Interface.storyboard:0:0: warning: Parse XML error XML Element Error: Incorrect key ["archive"]
WatchKitApp/Base.lproj/Interface.storyboard:0:0: warning: Parse XML error XML Element Error: Incorrect key ["archive"]
WatchKitApp/Base.lproj/Interface.storyboard:0:0: warning: Parse XML error XML Element Error: Incorrect key ["archive"]
WatchKitApp/Base.lproj/Interface.storyboard:0:0: warning: Parse XML error XML Element Error: Incorrect key ["archive"]
WatchKitApp/Base.lproj/Interface.storyboard:0:0: warning: Parse XML error XML Element Error: Incorrect key ["archive"]

Try to use mint install IBDecodable/IBLinter to install it but failed error msg:

▶ mint install IBDecodable/IBLinter
🌱 Finding latest version of IBLinter
🌱 Cloning IBLinter 0.4.27
🌱 Resolving package
🌱 Building package
[1/11] Compiling SourceKit SourceKit.m
[2/11] Compiling Clang_C Clang_C.m
remark: Incremental compilation has been disabled: it is not compatible with whole module optimizationremark: Incremental compilation has been disabled: it is not compatible with whole module optimizationremark: Incremental compilation has been disabled: it is not compatible with whole module optimization[3/14] Compiling writer.c
[4/14] Compiling reader.c
[5/14] Compiling parser.c
[6/14] Compiling api.c
[7/14] Compiling emitter.c
[8/14] Compiling scanner.c
remark: Incremental compilation has been disabled: it is not compatible with whole module optimizationremark: Incremental compilation has been disabled: it is not compatible with whole module optimization/private/var/folders/gm/6hgr32b973373pdvf4hpfz_xyht1z0/T/mint/github.com_IBDecodable_IBLinter/.build/checkouts/Yams/Sources/Yams/Emitter.swift:338:32: warning: initialization of 'UnsafeMutablePointer<yaml_version_directive_t>' (aka 'UnsafeMutablePointer<yaml_version_directive_s>') results in a dangling pointer
            versionDirective = UnsafeMutablePointer(&versionDirectiveValue)
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/private/var/folders/gm/6hgr32b973373pdvf4hpfz_xyht1z0/T/mint/github.com_IBDecodable_IBLinter/.build/checkouts/Yams/Sources/Yams/Emitter.swift:338:53: note: implicit argument conversion from 'yaml_version_directive_t' (aka 'yaml_version_directive_s') to 'UnsafeMutablePointer<yaml_version_directive_t>' (aka 'UnsafeMutablePointer<yaml_version_directive_s>') produces a pointer valid only for the duration of the call to 'init(_:)'
            versionDirective = UnsafeMutablePointer(&versionDirectiveValue)
                                                    ^~~~~~~~~~~~~~~~~~~~~~
/private/var/folders/gm/6hgr32b973373pdvf4hpfz_xyht1z0/T/mint/github.com_IBDecodable_IBLinter/.build/checkouts/Yams/Sources/Yams/Emitter.swift:338:53: note: use 'withUnsafeMutablePointer' in order to explicitly convert argument to pointer valid for a defined scope
            versionDirective = UnsafeMutablePointer(&versionDirectiveValue)
                                                    ^
remark: Incremental compilation has been disabled: it is not compatible with whole module optimization/private/var/folders/gm/6hgr32b973373pdvf4hpfz_xyht1z0/T/mint/github.com_IBDecodable_IBLinter/.build/checkouts/SourceKitten/Source/SourceKittenFramework/Request.swift:251:58: error: cannot convert value of type 'Int' to expected dictionary value type 'Int64'
                    "key.editor.format.usetabs": useTabs ? 1 : 0
                                                         ^
🌱 Encountered error during "swift build -c release -Xswiftc -target -Xswiftc x86_64-apple-macosx12.0". Use --verbose to see full output
🌱  Failed to build IBLinter 0.4.27 with SPM

Please Help