Summary

This pull request is aimed to the issue #129 for using Foundation.Date for log timestamps

Design decisions

I've add a private time formatter shared instance for keeping the initialisation cost low, and set the format template to print hours, minutes, seconds and milliseconds. I don't know if you prefer additional information on the date or the time is enough.

Gist Download project

With snapshot 2016-4-12-a on OS X, I get "Connection reset by peer" when running this code:

import HTTPSClient

let client = try HTTPSClient.Client(uri: "https://www.googleapis.com:443")
let response = try client.get(
    "/youtube/v3/videos?part=snippet,statistics&id=1,2&key=REDACTED")

The full error:

[I] ~/work/HTTPSClient_issue                                                    
↪ ./.build/debug/HTTPClient_issue                                     0@10:36:38
fatal error: Error raised at top level: Connection reset by peer: file /Users/buildnode/jenkins/workspace/oss-swift-package-osx/swift/stdlib/public/core/ErrorType.swift, line 59
Current stack trace:
0   libswiftCore.dylib                  0x00000001007376a1 swift_reportError + 145
1   libswiftCore.dylib                  0x0000000100754a17 _swift_stdlib_reportFatalErrorInFile + 103
2   libswiftCore.dylib                  0x000000010070a193 partial apply forwarder for Swift.(_assertionFailed (Swift.StaticString, Swift.String, Swift.StaticString, Swift.UInt, flags : Swift.UInt32) -> ()).(closure #1).(closure #1).(closure #1) + 99
3   libswiftCore.dylib                  0x000000010070a1ef partial apply forwarder for reabstraction thunk helper from @callee_owned (@unowned Swift.UnsafeBufferPointer<Swift.UInt8>) -> () to @callee_owned (@unowned Swift.UnsafeBufferPointer<Swift.UInt8>) -> (@out ()).291 + 63
4   libswiftCore.dylib                  0x00000001005c09bd generic specialization <preserving fragile attribute, ()> of Swift.StaticString.withUTF8Buffer <A> (invoke : (Swift.UnsafeBufferPointer<Swift.UInt8>) -> A) -> A + 349
5   libswiftCore.dylib                  0x00000001006cf77c function signature specialization <preserving fragile attribute, Arg[1] = Owned To Guaranteed and Exploded> of Swift.(_assertionFailed (Swift.StaticString, Swift.String, Swift.StaticString, Swift.UInt, flags : Swift.UInt32) -> ()).(closure #1) + 204
6   libswiftCore.dylib                  0x00000001006e280f partial apply forwarder for Swift.(_assertionFailed (Swift.StaticString, Swift.String, Swift.StaticString, Swift.UInt, flags : Swift.UInt32) -> ()).(closure #1) + 143
7   libswiftCore.dylib                  0x00000001006adb9a function signature specialization <preserving fragile attribute, Arg[1] = Exploded> of Swift._assertionFailed (Swift.StaticString, Swift.String, Swift.StaticString, Swift.UInt, flags : Swift.UInt32) -> () + 218
8   libswiftCore.dylib                  0x00000001005d6cff swift_errorInMain + 719
9   HTTPClient_issue                    0x00000001000bd243 main + 2403
10  libdyld.dylib                       0x00007fff962145ad start + 1
11  ???                                 0x0000000000000001 0x0 + 1
fish: './.build/debug/HTTPClient_issue' terminated by signal SIGILL (Illegal instruction)

Hi, this is not finished yet, but it's clear enough for you to begin reviewing

• [x] update to Swift 3
• [x] utf8 support
• [x] convenience operators ~, ~*, ~?
• [x] Tests for match and groups
• [x] Tests for replace
• [ ] API change (needs review @paulofaria)
• [ ] get rid of one Foundation dependency (used for one method)?

These are my suggested changes, but let's keep discussing this.

What's in here:

• [x] Remove ExpressibleByNilLiteral. Making Map.null == nil is confusing, and is more similar to the null pointer mechanism that Swift discourages rather than the optional pattern. Correctness > convenience in this case IMO.
• [x] Remove get in favor of subscript
• [x] Remove set in favor of subscript
• [x] Remove remove in favor of subscript
• [x] Make subscript optional
• [x] Add asInferred method which uses type inference. It is the only generic method.
• [ ] Reintegrate with Mapper (there were API conflicts)
• [ ] Remove MapRepresentable in favor of just MapFallibleRepresentable. Having two similar API's is confusing, especially since being MapInitiliazable and MapRepresentable doesn't give you MapConvertible.
• [ ] Remove unused errors from enum
• [ ] Any ideas?

There is now exactly one way to index map (subscript), and several ways to unbox the type (int, isInt, asInt(), asInferred):

let map: Map = [
    "string": "hello world",
    "array": [1, 2, 3, 4, 5],
    "dictionary": [
        "string": "nested hello world",
        "array": [6, 7, 8, 9, 10]
    ]
]

let a: Map? = map["dictionary", "array", 2]
let b: Int? = map["dictionary", "array", 2]?.int
let c: Int = try map["dictionary", "array", 2].map.asInt()
let d: Int = try map["dictionary", "array", 2].map.asInferred()

cc @paulofaria @robertjpayne @dreymonde

For example, HTTPFile.FileResponder simply return a 404 response on any file errors, regardless of whether its permission or the file is just a directory.

I opened a pull request regarding this with a very in-elegant solution.

It looks like Zewo/RecoveryMiddleware gets us halfway there.

Hopefully I'm just doing something wrong, but when I pull this repo and build in Linux using "swift build" the cloning of packages seems to work, but after the SSL Package is cloned, I see this error:

swift-build: rename error: File exists (17): /src/Packages/CLibvenice -> /src/Packages/CLibvenice-0.1.0

I also followed the steps to install the three C libs as well.

Any ideas what I'm missing?

Wes

Segmentation Fault of Swift Reflection

I recently use swift reflection to convert json string to a struct, but got "Segmentation Fault" in runtime. As the test code is too much to write here, I committed my test code in github, can you help have a look, thanks.

Steps to reproduce

$uname -a Linux dev 4.4.0-34-generic #53-Ubuntu SMP Wed Jul 27 16:06:39 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

$ swift --version Swift version 3.0 (swift-3.0.1-PREVIEW-1) Target: x86_64-unknown-linux-gnu

$ git clone https://github.com/hikelee/SegmentationFault.git

$ cd SegmentationFault

$ swift build Cloning https://github.com/Zewo/Reflection.git HEAD is now at 2bc1a76 make mappable tests public on reflection Resolved version: 0.14.0 Compile Swift Module 'Reflection' (23 sources) Compile Swift Module 'Main' (1 sources) Linking ./.build/debug/Main

$ .build/debug/Main Person(firstName: "James") Person(firstName: "James") Person(firstName: "James") Person(firstName: "James") ------ Person(firstName: "James") Person(firstName: "pb?\0\0\0\0\0a") Person(firstName: "\u{10}\u{10}\0a") Segmentation fault

When I deliver a certain file using HTTPFile.FileResponder along with either HTTPSServer or HTTPServer, it always fails delivering the whole file. Chrome reports "net:ERR_INVALID_CHUNKED_ENCODING" in its Developer Tools Network tab.

In this gist you can see react.js file as delivered by nginx or HTTPServer. The page is super long, so it may be easier to open up the files in new tabs:

• Delivered via HTTPServer (Cuts off on line 1485)
• Delivered via nginx (delivers whole file)

I think I have experienced this occasionally on OS X, but it happens consistently on my 512 MB DigitalOcean VM running Ubuntu 14.04.3.

The plan:

• All dependencies pointed at 0.10 (with the exception of Open-Swift/S4, which should be pointed at 0.11)
• The version in the README updated to majorVersion: 0, minor: 10
• The badge in the README updated to 0.10 (i.e. )
• Once the branch satisfies the requirements, a pull request is to be created (merging into master, obviously)
• Build and run the tests locally, and fix any warnings or errors
• Create a new tag 0.10.0

List of relevant repositories:

• [ ] Zewo/Zewo
• [ ] Zewo/Router
• [ ] Zewo/HTTP
• [ ] Zewo/Mustache
• [ ] Zewo/Sideburns
• [ ] Zewo/JSON
• [ ] Zewo/JSONMediaType
• [ ] Zewo/MediaType
• [ ] Zewo/HTTPSerializer
• [ ] Zewo/URI
• [ ] Zewo/CURIParser
• [ ] Zewo/HTTPParser
• [ ] Zewo/CHTTPParser
• [ ] Zewo/OpenSSL
• [ ] Zewo/COpenSSL
• [ ] Zewo/SQL
• [ ] Zewo/PostgreSQL
• [ ] Zewo/CLibpq
• [ ] Zewo/MySQL
• [ ] Zewo/CMySQL
• [ ] Zewo/WebSocket
• [ ] Zewo/WebSocketClient
• [ ] Zewo/WebSocketServer
• [ ] Zewo/EngineIOServer
• [ ] Zewo/BasicAuthMiddleware
• [ ] Zewo/Base64
• [ ] Zewo/POSIXRegex
• [x] Zewo/POSIX
• [x] Zewo/String
• [ ] Zewo/TrieRouteMatcher
• [ ] Zewo/StructuredData
• [ ] Zewo/Log
• [ ] Zewo/LogMiddleware
• [ ] Zewo/URLEncodedForm
• [ ] Zewo/ContentNegotiationMiddleware
• [ ] Zewo/RegexRouteMatcher
• [ ] Zewo/Redis
• [ ] Zewo/Event
• [x] Zewo/XML
• [x] Zewo/CLibXML2
• [ ] Zewo/PathParameterMiddleware
• [ ] Zewo/Mapper
• [ ] Zewo/RecoveryMiddleware
• [ ] Zewo/BranchMiddleware
• [ ] Zewo/Resource
• [ ] Zewo/RedirectMiddleware
• [ ] Zewo/URLEncodedFormMediaType
• [ ] Zewo/UUID
• [ ] Zewo/SessionMiddleware
• [ ] Zewo/TodoBackend
• [ ] Zewo/Reflection
• [ ] Zewo/CUUID
• [x] Zewo/zlib
• [x] Zewo/gzip
• [x] VeniceX/Venice
• [x] VeniceX/CLibvenice
• [ ] VeniceX/ChannelStream
• [ ] VeniceX/IP
• [ ] VeniceX/TCP
• [ ] VeniceX/HTTPServer
• [ ] VeniceX/HTTPClient
• [x] VeniceX/File
• [ ] VeniceX/HTTPFile
• [ ] VeniceX/UDP
• [ ] VeniceX/TCPSSL
• [ ] VeniceX/HTTPSServer
• [ ] VeniceX/HTTPSClient

When HTTP response doesn't set Content-Length, http and https client raises and closedStream(0 bytes) error. It should calculate total length read till the end of http server connection, when this header is not set.

How to reproduce?

For this response:

HTTP/1.1 200 OK
Date: Fri, 16 Sep 2016 16:23:17 GMT
Connection: close

test

Run on the simplest http server (https://gist.github.com/vi4m/a3809caea5e4a59d27e1032f8b9657f1)

And with this swift client code:

import HTTPClient

do {
    let c = try Client(url: "http://localhost:9000")
    let request = Request(method: .get, url: "/")
    var response = try c.request(request!)
}
catch {
    print(error)
    print("Failed.")
    exit(2)
}
print("Success.")

it will fail with closedStream(0 bytes error).

When the response is completed with "Content-Lenght: 5" http request works fine.

Created by @vi4m

Optional("") returned where nil is expected

Based on TodoBackend project (https://github.com/Zewo/TodoBackend) I did very similar PSQL store for my project. When my model contains String? fields replicating the null-allowed text or varchar columns in DB, if I insert nil values when writing it to DB I expect the nil values to be returned by the get methods as well. DB correctly has NULL values in it, but values returned by get(id) or getAll() methods are Optional("") instead of nil.

Steps to reproduce

1. Create a model having the String? fields and corresponding table in DB having text or varchar fields which can be NULLs.
2. In your tests / main / whatever executable source file instantiate your model and assign nil values to fields of type String?.
3. Insert the record using the model and store.insert(model) method.
4. Save the value returned by insert into a variable.
5. Compare model object created by you and model returned by insert within the PersistedEntity.

Expected: nil values are nil values in both and comparison succeeds. Actual: nil values were replaced by Optional("")

My code:

func testAssetInsertion() throws {
    let original = Asset(id: "bc_id", name: "Test", frontCover: nil, data: nil, type: nil) 
    let inserted = try store.insertAsset(asset: original)
    XCTAssertEqual(inserted.model, original)
    let retrieved = try store.getAsset(id: "bc_id")
    XCTAssertEqual(retrieved!.model, original)
    let retrievedThroughGetAll = try store.getAllAssets()
    XCTAssertEqual(retrievedThroughGetAll.count, 1)
    XCTAssertEqual(retrievedThroughGetAll[0].model, original)
}

Test results:

/home/anatoli/workspace/StorageService/Tests/StorageLayerTests/PostgreSQLEBooksStore/PostgreSQLEBooksStoreTests.swift:45: error: PostgreSQLEBooksStoreTests.testAssetInsertion : XCTAssertEqual failed: ("Asset(id: "bc_id", name: "Test", frontCover: Optional(""), data: Optional(""), type: Optional(""))") is not equal to ("Asset(id: "bc_id", name: "Test", frontCover: nil, data: nil, type: nil)") - 
/home/anatoli/workspace/StorageService/Tests/StorageLayerTests/PostgreSQLEBooksStore/PostgreSQLEBooksStoreTests.swift:47: error: PostgreSQLEBooksStoreTests.testAssetInsertion : XCTAssertEqual failed: ("Asset(id: "bc_id", name: "Test", frontCover: Optional(""), data: Optional(""), type: Optional(""))") is not equal to ("Asset(id: "bc_id", name: "Test", frontCover: nil, data: nil, type: nil)") - 
/home/anatoli/workspace/StorageService/Tests/StorageLayerTests/PostgreSQLEBooksStore/PostgreSQLEBooksStoreTests.swift:50: error: PostgreSQLEBooksStoreTests.testAssetInsertion : XCTAssertEqual failed: ("Asset(id: "bc_id", name: "Test", frontCover: Optional(""), data: Optional(""), type: Optional(""))") is not equal to ("Asset(id: "bc_id", name: "Test", frontCover: nil, data: nil, type: nil)")

• I have implementation of insert and model very close to what is in TodoStore and related sources. So I expect it to be reproducible there. If not - please let me know and I will add more info.

I have been experimenting with swift as a replacement for nodejs micro services. It seems that the server side Swift world has cooled off a lot. As best I can tell only Vapor is in active development. But I’m not sure. Is Zewo still being ACTIVELY developed or will it?