We need an app icon else we can't distribute beta builds!

Following Apples HIG for icon design is the best place to start!

Appreciated files would be any of the following:

• .sketch
• .pdf
• 1024x1024 .png

https://github.com/realm/SwiftLint/blob/master/Rules.md#explicit-self

Enable explicit self in our swiftlint usage. This will help keep the code across the project consistent and make it more clear in a function if a variable being accessed belongs to the class or is defined somewhere in the function.

Instructions: https://github.com/realm/SwiftLint#configuration

It would be great to show a preview of the post (either a link or the description) under the title of the table view cells.

This could be accomplished by using a cell preset with two labels.

Describe the solution you'd like Add community icons to the subreddits displayed in the Subreddits VC. Community icon urls are available in the default subreddit listings.

Additional context Icons can be added to the tableview cell as shown in the screenshot below

*add avatarUrl to contributer struct *decode contributer struct using codingkeys *add avatarImageView to ContributerCell *send avatarURL to avatarImageView to load image

Here are some tests for CoreAPI. This tests the current behaviour, but I'd like to see this expanded in the future, as I'll mention below:

Notes

• I had to modify the getData(forRoute:parameters:completion) method to accept a mocked session. This doesn't affect the call site, thanks to default values.

• CoreAPI currently just returns CoreAPIError.random if there is no data. I feel this would be better returning the actual error returned by the URLSession.dataTask.

• Additionally, there may be some merit in using the status code from the URL response to check its in the 200-299 range.

• I modified the Makefile to accept an array of test schemes, then look through them to run the tests.

As referenced in this issue I have no idea if this is the approach you are looking for, but its an approach at least!

Notes:

• I have no idea what the difference between Debug.xcconfig and area51-debug.xcconfig is. I chose Debug.xcconfig.

• Example tests now run while Area51 target is set, and CMD+U pressed

• Ideally, the window.rootViewController in AppDelegate should be overridden when testing, to speed up tests somewhat further down the line.

• I have tested the target using fastlane scan and it executes the tests successfully, so there shouldn't be an issue setting this to run automatically on travis.

Is your feature request related to a problem? Please describe. I would like to add a search bar to the subreddit view to search for subreddits.

Describe the solution you'd like I would like add a search bar to filter default subreddits.

We should separate the UITableView's datasource from the UIViewController and try make it as reusable as possible.

Changes to be made:

• Separate the datasource from the FeedViewController (First 'test' case and example)
• Make the new datasource reusable.

Pros

Anytime we need to display a list of common results (In this case, Listing) we do not need to setup the UITableView's datasource - we simply instantiate it and supply it a collection of Listing objects. The rest is taken care of.

This will also separate the responsibilities a little more between the various UI layers. It as the added benefit that should we decide to change UI layout / implementation of a UITableViewCell for the given Datasource it will be all done in one place.

Cons

Don't see any immediate cons to this approach. It's an extra file in the project per datasource that we create - however I feel this is minor.

As part of this change, I will also clean up the code in FeedViewController and make it ready for a review in the next day or two.

I think we should use this as an example to implement other datasources for UiTableViews if accepted through a PR. We don't always have to aim for high reusability in every case - can judge that on a case by case basis.

Since this project is aimed at beginners and show casing latest iOS development techniques; we should also include unit testing with this project.

Thoughts?

We should add a TabBarController with two tabs to start.

• The first tab should hold the SplitViewController for the list of subreddits and feed.
• The second tab should take you to a blank ViewController where we can turn it into a settings screen.

Is your feature request related to a problem? Please describe. Currently, the reddit posts are viewed using a web view.

Describe the solution you'd like Add a screen to view posts natively.

Additional context The screen should display the following:

• Post heading
• Post OP
• Post Body
• Karma
• Number of comments

To the SubredditService module, add a method which takes a query string for the search term and returns a list of subreddits which match the query.

You can do this by adding a new route to SubredditService/Sources/APIRoute+Subreddit.swift The route is subreddits/search

You will then need to create a new api call in SubredditService module which uses CoreAPI.results... with the newly specified route. You will also need to pass through the query string as a parameter all the way through to CoreAPI which makes the call.

As noted in https://github.com/kgellci/Area51/pull/83#issuecomment-468377696 it may be useful for someone to setup Danger.

This would automate the initial QA of a Pull Request. It's easy to forget things sometimes, so this could automatically check the following:

• Does SwiftLint pass?
• Does it change significant parts of the app without unit tests?
• Is the new code missing comments?
• Have you updated the CHANGELOG?
• Did you accidentally include a copyright header?

This would probably need the project owner to setup, as it relies on a GitHub bot to run automatically. See Getting Started.

FeedViewModel has logic for formatting listings. It is doing this by mutating the Listing objects in place.

https://github.com/kgellci/Area51/blob/master/Area51/Sources/ViewModels/FeedViewModel.swift#L37

We should instead instantiate ListingViewModel from a listing which will apply the needed formatting to the required fields. We can probably convert ListingsDataSource to be a ListingViewModelDataSource which would give the added benefit of only formatting listings once instead of every time more listings are loaded.

The "Default Feeds" are currently unordered and formatting doesn't look good. The default subreddits should be in an alphabetical order and formatted like /r/AskReddit instead of /r/AskReddit/.

Screenshots

I think Reddit has sunset their default subreddits list, but we can still pre-populate the side navigation with a defaults list. Can probably start by using this one: https://www.reddit.com/r/defaults/comments/61mgs9/list_of_default_subreddits_26_march_2017/

We can make the changes here for now: https://github.com/kgellci/Area51/blob/master/ListingService/Sources/Subreddit.swift

I plan on refactoring to make less static fo future use but fine to use for now.