This pull request contains quite a few things:

• Support for Dark Mode in iOS 13
• A workaround for the UIReferenceLibraryViewController slowness in iOS 13 (see comment in initiateSearch() of AddWordViewController)
• Some subtle new branding for the app (using color and the American Typewriter font)
• A check for text on the clipboard when the app becomes frontmost
• A partial fix for a janky animation from WordListViewController to AddWordViewController

Feel free to cherry pick whatever you want.

The new feature added in #41 to automatically detect text on the pasteboard, and offer to use it as a search, should ignore pasteboard text that contains newline characters, as it is unlikely to be useful as a word search.

Hi Will, I am using the Kotoba app and it's very helpful! I am a newbie to iOS dev so my apologies in advance if I'm asking some stupid questions. I am trying to make the UIReferenceLibraryView smaller so that I can add a search bar on the top. No offense to your design, that's just how I see fit in my read-lookup workflow. I read some documentation on UIReferenceLibraryView and can't find methods to resize the view. Later I noticed that UIReferenceLibraryView inherits from UIViewController, which has a preferredContentSize instance property. Therefore I did something like this:

let dictionaryViewController = UIReferenceLibraryViewController(term: word.text)
dictionaryViewController.preferredContentSize = CGSize(width: 200, height: 300)

However, it won't work. Is this feature possible? If so, could you tell me the right way to do it? If not, could you elaborate on why not? Thanks a lot!

Yuan

The word list can now be stored on iCloud (it still defaults to local storage.) When you change to "Use iCloud" (using the Settings app), you will be prompted to merge the local words in a list stored in iCloud.

To enable iCloud, you'll need to provision your App ID using the developer portal. The brief instructions are in Setup_iCloud.txt.

I also tuned up the clipboard detection so that it won't prompt you more than once for each new word or for text that has newlines in it.

Moved some color into the navbar, too.

The new layout of the import buttons in Settings looks much better, but there's a problem: the secondary label doesn't wrap or shrink. The contents of this button can be long in English (e.g. "12,345 words", and even longer in other languages (e.g. CHOCK). Not the end of the world, but we've come this far :-)

Opening this issue to track the problem, although it's really an iOS 13 bug. Originally reported in #39, and @chockenberry implemented a workaround using background queues to do the lookup, but it's not ideal, and the delay is still much worse than it was on iOS 12.

This issue is to file a radar with Apple, but also track the problem/workarounds on the Kotoba side.

Hi,

when i type in a word and then click Search, Kotoba reacts rather slow and slugish, when run on iOS 13. Any updates for iOS 13 in sight (i am not a developer which could fix this)?

Thanks for such a useful App!

When typing very long words, the text field would scroll rather than displaying the whole word. This annoyed me, so, now it will scale down to 15pt.

(This is a revision of pull request #33, addressing the IB spam issue)

Would you consider integrating an export function into the app?

In my own crude way, I tried to accomplish this by downloading the app's container via Xcode and browsing through the files, but to no avail. If there ever comes a point where the app is no longer supported, I wouldn't want the words I've accumulated to disappear along with it.

I found the app based on @gruber's recommendation and I've been using it incessantly ever since. Your work is much appreciated. Thank you.

@gruber

can we make the search bar and text bigger? More like 20pt or 24pt or something instead of 16? Why not since it’s the only input? I tried poking around the storyboard in Xcode but don’t see any way to change that there.

This is a redux of #11, to enable syncing via iCloud Drive or other cloud services. If the user can select a save location of their choice via the Files API, and Kotoba can access/update that location without prompting the user every time, then it doesn't need iCloud access (read: doesn't need to be an App Store app).

I download the zip file and follow the instructions to modify values in info.plist. But I can't build the project. It keeps showing alert with title "Failed to install the requested application" and says "The application's Info.plist does not contain a valid CFBundleVersion. Ensure your bundle contains a valid CFBundleVersion." Does anyone have the same problem?

Would it be an idea to have an optional developer config file that can override "Team" and "Bundle identifier" settings, much like NetNewsWire does it.

This way, you only need to configure the app once, and not each time you want to install it.

I tried this myself, but I'm not an XCode warrior (more python guy), but I think it's still a good idea to implement.

(Copy & paste from chat with @gruber)

What about something to put in the Sharing sheet? I realize that once you have a text selection you can tap it and just hit Look Up in any app. But I’ve grown to resent the fact that words I look up that way don’t get saved to my history. I love my Kotoba history.

In some ways, the history really is what we told Apple it was the app store description — a description for the app above and behind a dictinoary.

So even though the best possible Share sheet extension would not be as convenient as the built-in Look Up, I would use it. Right now I often copy, switch to Kotoba, and paste, just to get it in my history.

The label is obvious: “Look Up in Kotoba”