Hi Ryan!

I've finally made this. The user can now login using their credentials. The login information is stored in the shared session which persists across the app's relaunches. There's a bar item button for login/logout, a login view and network tools for the feature.

The HNService class was modified a little bit for two reasons:

1. It can now perform POST requests alongside GET requests.
2. The stringByAppendingPathComponent: function used to compose a string representation of the URL doesn't work well with URLs actually. It's stated in the documentation: Note that this method only works with file paths (not, for example, string representations of URLs).. The downside of the function is that it turns "https://news.ycombinator.com" into "https:/news.ycombinator.com", and while the latter does allow the app to fetch data it doesn't use cookies stored for the former (during the login process).

I hope the changes feel well. If anything (hopefully that won't be the whole request though) isn't consistent with the app's design I would love to modify it.

Hey, @rnystrom

Summary:

• Use safe area layout guides
• Tested only on the iPhone X simulator

I added usage of the safe area layout guides. Next step could be migrating from the UISearchDisplayController to UISearchController and presenting search controller directly in the navigation bar?

Closes #18.

Now it looks like this:

Thanks!

Hi,

Below is what I get when I open the app. Am wondering if it has been discontinued. I have deleted it, waited for over a week and then installed it again. Same issue.

iPhone 8+. App Version: 1.3.0

Thanks

Hi @rnystrom!

I've been sitting on these changes for a while, partially because of #16, and partially because I wasn't sure you were still maintaining this. This pull request has a lot of stuff in it, so let me go over it:

• Uses SFSafariViewController wherever HNWebViewController was used. Not much to say here since it was mostly a drop-in replacement.
• Support of 3D Touch wherever it seems appropriate–the link in the feed, the comments button in the feed, and the link in the header in the comments view.
• Replace an en dash that was bothering me with a minus sign (which has the same width as a plus sign).

Also, there's a slightly controversial change of collapsing comments by tapping on them. This might not be what you want, so I'm fine with dropping it, but my rationale behind it was that there was no action performed by tapping on cells anyways so why not?

Finally, this pull request has full iOS 11 support. In particular, it fixes a couple of legacy issues and adapts the new large titles, integrated UISearchController/UIRefreshControl, etc. Plus there's a couple of fixes for warnings and whatnot. I know there are other pull requests for a subset of the things in mine, but they're not quite there. In particular, #19 doesn't actually fix the comment layout views, which fly off the screen, #22 uses private API to turn the search bar white and keeps a separate results controller, which I think introduces complexity.

You may notice that this pull request doesn't actually merge cleanly; this was done on purpose. I'm requesting that if you merge this, you do so as-is. The reason for this is that some recent commits have introduced some changes that aren't really necessary (especially with regards to updated Cocoapods), and I've gone through and manually picked out the useful bits. Of course, this makes the pull request seem behind your master branch, but Cocoapods should be up to date.

Main Thread Checker detected invalid usage of UIKit on a background thread:

Classes/ViewControllers/HNCommentViewController.m:
runtime: UI API called from background thread: -[UIView bounds] must be used from main thread only

Inside of [dataCoordinator:didUpdateObject:]

CGFloat width = CGRectGetWidth(self.view.bounds) - insets.left - insets.right;

Hey, @rnystrom !

Summary:

• Migrate to UISearchController
• Due to this issue on iOS 11.0, use the new way to show search bar

Closes #21.

On iOS 11.0 and later looks likes this:

Thanks!