let siren = Siren.sharedInstance

siren.appID = 12345

The latter does not work as the compiler cannot find appID:

AppDelegate.swift:32:9: 'Siren' does not have a member named 'appID'

This PR will usher in a head-to-tail rewrite of Siren. Specifically, the following will occur:

• [x] Interface rewrite
• [x] Move core logic from Siren.swift to configurable managers
• [x] Scope more data structures under Siren.
• [x] Implement #237 and #190
• [x] Add Documentation
• [x] Update README

This PR is a WIP.

If you're experiencing a problem integrating Siren into your app, please provide the following information when posting a new issue:

• Are you using the latest version of Siren?: Yes (5.4.0 as of now)
• What is your app's Bundle ID?: n/a
• When was the latest version of your app published to the App Store?: Not published yet
• Is your app published in the US App Store? If not, what App Store is it published in?: n/a
• Does Siren work if you plugin your app's BundleID (and countryCode, if necessary) into the Example app?: Yes and no, see below

Related issue

Potentially related issue: https://github.com/ArtSabintsev/Siren/issues/67 but it provided no clue.

Issue description

When running an app with Siren on a phone set to Japanese, the update alert showed up in English. Trying to set forceLanguageLocalization to .japanese (or other localizations) did not work either, the alert was still in English.

We ended up specifying strings manually, but this is not ideal: it does not extrapolate the app name and version number in the alertMessage.

Example app

With the example app:

• The hyperCriticalRulesExample alert shows up in English by default, even though the device is set to Japanese.
• but forceLanguageLocalization does work and shows the alert in Japanese.

Our code:

import Siren

struct UpdatesMonitor {
  static func configure() {
    let siren = Siren.shared
    // siren.presentationManager = PresentationManager(
    //   forceLanguageLocalization: .japanese
    // )
    // Unfortunately, the forceLanguageLocalization above had no effect, so:
    siren.presentationManager = PresentationManager(
      alertTitle: "アップデートのお知らせ",
      alertMessage: "新規バージョンがご利用になれます。\n今すぐアップデートしてください。",
      updateButtonTitle: "アップデート"
    )
    siren.rulesManager = RulesManager(
      globalRules: .critical,
      showAlertAfterCurrentVersionHasBeenReleasedForDays: 0
    )
    siren.wail()
  }
}

And we do UpdatesMonitor.configure() after window?.makeKeyAndVisible().

I'm getting this error when I run the app. [Siren] JSON results: ["resultCount": 0, "results": <__NSArray0 0x15de15b60>()] [Siren] Error retrieving App Store data as an error was returned.

I don't know where to specify my App Id now when that property is private. My app is active on the app store so this don't happen because of it doesn't exist there.

What am I missing?

I have implemented Siren and when updates is available it is showing popUp and onClick update it is going to app store but there is no option for update. its showing only open button. my previous version is 1.0.2 and new version is 1.0.3

This issue simply shouldn't be happening.

There needs to be another way to compare version numbers, 16.0 is certainly the same as 16 and shouldn't be treated as requiring a new version! :O I was shocked when I saw this.. Did some debugging and found the problem area... Today our app was accepted only for siren to cause our users to go into a never ending loop of installs..

• Are you using the latest version of Siren?: Yes.
• What is your app's Bundle ID?: Com.Greyscale.School-App
• When was the latest version of your app published to the App Store?: 24 june 2020.
• Is your app published in the US App Store? If not, what App Store is it published in?: published in App Store globally.
• Does Siren work if you plugin your app's BundleID (and countryCode, if necessary) into the Example app?: Can't test this. Couldn't find where to add these.

Applying this code in my App delegate in didFinishLaunchingWithOptions function

func initForceUpdate() {
            let siren = Siren.shared
            siren.apiManager = APIManager(countryCode: "\(Locale.current.languageCode ?? "")") // that is "en"

             siren.presentationManager = PresentationManager(alertTitle: "UPDATE",
                                                        nextTimeButtonTitle: "NEXT_TIME")
                let rules = Rules(promptFrequency: .immediately, forAlertType: .force)
               siren.rulesManager = RulesManager(globalRules: rules, showAlertAfterCurrentVersionHasBeenReleasedForDays: 1)
                siren.rulesManager = RulesManager(globalRules: .critical)
        siren.wail { results in
            switch results {
            case .success(let updateResults):
                print("AlertAction ", updateResults.alertAction)
                print("Localization ", updateResults.localization)
                print("Model ", updateResults.model)
                print("UpdateType ", updateResults.updateType)
            case .failure(let error):
                print(error.localizedDescription)
            }
        }
    }

And getting this error

[Siren Error] Error parsing App Store JSON data. Also, the following system level error was returned: keyNotFound(CodingKeys(stringValue: "results", intValue: nil), Swift.DecodingError.Context(codingPath: [], debugDescription: "No value associated with key CodingKeys(stringValue: "results", intValue: nil) ("results").", underlyingError: nil))

what I am doing wrong. Any help would be appreciated. Thanks

I have just installed Siren version 5.4.0 using pod 'Siren' in my pod file.

I have an app version 1.5 which was last published in the appStore approx 2 months ago.

The version details in my xcode project file are:

Version: 0.0.5 Build: 1

(AppStore published version: 1.5)

When testing I change to Version 0.0.1 then build/run the app and no alert pops up.

I am testing using the provided sample in my AppDelegate.swift file

import Siren

var window: UIWindow?

func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {

window?.makeKeyAndVisible()
defaultExampleUsingCompletionHandler()

//...other code eg; Firebase, Facebook initialisation code, present login VC if currentUser == nil

}

private extension AppDelegate {

    // The simplest implementation of Siren.
    // All default rules are implemented and the
    // results of the completion handler are ignored.
    func defaultExample() {
        Siren.shared.wail()
    }

    // The simplest implementation of Siren.
    // All default rules are implemented and the
    // results of the completion handler are returned or an error is returned.
    func defaultExampleUsingCompletionHandler() {
        
        print("defaultExampleUsingCompletionHandler")
        
        Siren.shared.wail { results in
            switch results {
            case .success(let updateResults):
                print("AlertAction ", updateResults.alertAction)
                print("Localization ", updateResults.localization)
                print("Model ", updateResults.model)
                print("UpdateType ", updateResults.updateType)
            case .failure(let error):
                print(error.localizedDescription)
            }
        }
    }
    
}//end extension

I removed the predefined text because this behaviour can be seen in the Example app too.

Steps to reproduce:

1. Click on the Example project in the Project Navigator. In the Targets select Example if it is not selected.
2. Under General tab, under Deployment Info change the Main interface option to Main.storyboard .
3. Open the Main.storyboard in the Supporting Files group/folder.
4. Put UISwitch in the scene and add constraints to it.
5. Run the application in simulator. After the popup for update appears and the user taps on something, the user can't flip the switch. If you comment the line annoyingRuleExample() in the application(_:didFinishLaunchingWithOptions:), and run the app again the user can flip the switch.

I tested it with the newest version (5.2.2) and this behaviour is happening to me in the simulator and on real device too. I don't know if it has something to do with the UIWindow the alert creates because after dismissal the window for the alert is still there in the view hierarchy.

I am glad to see new version 4 coming up. The simple method of Siren.wail is fine. Siren add observer to wait didBecomeActive. However, I'd like to trigger version check on my own, for example, after editing photos, user may see update alert. How about make Siren.performVersionCheck method to public?

Hi I am seeing a weird bug.

https://itunes.apple.com/lookup?bundleId=com.xxx.xxxx

If I visit this directly, it gives me version 2.0.

But when running Siren in the app, somehow it keeps on returning 1.3 (the previous version). I tried to debug the Siren code and the url looks correct, not sure where this is cached. This behavior is causing the update message to not show up for Apps with v1.3 installed. The region is US.

I don't think theres a delay in appstore because the url is already showing 2.0. Is this a bug, and will v1.3 users ever get the update message?

Thanks! Jason