Hi, Thank you for all your hard work. This is an awesome tool. I was wondering if you can help me with this issue. I want to change the color of the Cancel button to be red and yet keep it as a "Cancel" style. Is this possible.?

Thanks

Dear,

I've added 2 features to this project:

1. UITextFields on ActionSheet and moving action sheet to top on textField click
2. Dismissing ActionController on Background click.

Hii guys,

Iam tryng to add an tableview. I attached one print screen. What's do you think?

I can see the prints...the data is ok

    func tableView(tableView: UITableView, cellForRowAtIndexPath indexPath: NSIndexPath) -> UITableViewCell
    {
        print("came here = " + self.pickerData[indexPath.row])
        let cell:UITableViewCell = self.pickerView.dequeueReusableCellWithIdentifier("cell")! as UITableViewCell
        cell.textLabel?.text = self.pickerData[indexPath.row]

        if(indexPath.row % 2 == 0){
            cell.backgroundColor = UIColor.grayColor()
        } else{
            cell.backgroundColor = UIColor.whiteColor()
        }

        return cell
    }

//where I add the tableview
  let newFrame4 = CGRectMake(0, 170, 300, 100)// 0 center - 120 top margin
        pickerView.frame = newFrame4
        self.contentView.addSubview(pickerView)

on iOS 8, present RMActionController have a strange animation, and after animation, app froze here is preview https://vid.me/Yrpe

Sample code:

if let dateSelectionVC = RMDateSelectionViewController(style: .Default, selectAction: RMAction(title: "Select".localizedString, style: .Default, andHandler: { [weak sender] (controller: RMActionController!) in

  let date = (controller.contentView as! UIDatePicker).date
  sender?.setOrderDate(date)

}), andCancelAction: RMAction(title: "Cancel".localizedString, style: .Cancel, andHandler: { _ in

})) {
   dateSelectionVC.datePicker.datePickerMode = .Date
   dateSelectionVC.disableBlurEffects = true
   dateSelectionVC.disableBouncingEffects = true
   dateSelectionVC.datePicker?.date = date
   dateSelectionVC.datePicker?.maximumDate = NSDate()

   presentViewController(dateSelectionVC, animated: true, completion: nil)
}

Hello,

thank you for this great classes. I want to use RMActionController for an universal app and hope, you could help me with an issue with the background color of the presenting view controller. On iPhone devices the background color will change to black on portrait orientation. On landscape, the color is correct. On iPad it works well in both orientations.

kind regards

Hi,

Thank you for making this great library. I just have problem, I keep getting the following error:

Error: The view of an RMActionController has been loaded before a contentView has been set. You have to set the contentView before presenting a RMActionController.

Here is my code:

-(void)display_choice_alert {

    // Create the custom alert view actions.
    RMAction *main_action = [RMAction actionWithTitle:@"Pizza menu" style:RMActionStyleDefault andHandler:^(RMActionController *controller) {

        NSLog(@"1");
    }];

    RMAction *side_action = [RMAction actionWithTitle:@"Side orders menu" style:RMActionStyleDefault andHandler:^(RMActionController *controller) {

        NSLog(@"2");
    }];

    RMAction *dismiss = [RMAction actionWithTitle:@"Dismiss" style:RMActionStyleCancel andHandler:^(RMActionController *controller) {
        NSLog(@"3");
    }];

    // Set the custom alert view properties and actions.
    RMActionController *actionController = [RMActionController actionControllerWithStyle:RMActionControllerStyleBlack selectAction:main_action andCancelAction:dismiss];

    // Add additional actions to the custom alert.
    [actionController addAction:side_action];

    // Set the custom alert details.
    actionController.title = @"Test";
    actionController.message = @"This is a test action controller.\nPlease tap 'Select' or 'Cancel'.";

    // Display the custom alert view.
    [self presentViewController:actionController animated:YES completion:nil];
}

Can you tell me what I am doing wrong here? I just followed your example thats all.

Thanks for your time, Daniel.

Hi,

thanks for providing this control. It really makes building custom action sheets simple. Unfortunately I ran into a problem. If I am using a UITabBarController the action controller is presented behind the tab bar on the bottom.

This problem only occurs on devices lower than iOS 11 as you can see in the screenshot.

Thanks a lot an kind regards,

Phillipp

One of my projects uses custom tint color for buttons. I would like to use this customization on this awesome control as well. :)

Therefore to achieve this when the disableBlurEffects is set to YES the button is instantiated with UIButtonTypeSystem.

hello, CooperRS :) I can't show title and message at the top of controller when using basic RMActionController. It looks like dependent on layout constraints such as 'translatesAutoresizingMaskIntoConstraints' and entire VC's height. Must I write below codes for auto layout every inherited uiviewcontroller to show title and message?

...
actionController.contentView.translatesAutoresizingMaskIntoConstraints = NO;
...
NSDictionary *bindings = @{@"contentView": actionController.contentView};
        [actionController.contentView addConstraints:[NSLayoutConstraint constraintsWithVisualFormat:@"[contentView(>=300)]" options:0 metrics:nil views:bindings]];
        [actionController.contentView addConstraints:[NSLayoutConstraint constraintsWithVisualFormat:@"V:[contentView(140)]" options:0 metrics:nil views:bindings]];

i wrote like below (to add a MPVolumeView)

RMActionController *actionController = [RMActionController actionControllerWithStyle:RMActionControllerStyleBlack
                                                                                       title:@"Test"
                                                                                     message:@"This is a test action controller.\nPlease tap 'Select' or 'Cancel'."
                                                                                selectAction:nil
                                                                             andCancelAction:nil];

        [actionController addAction:[RMAction actionWithTitle:@"Done" style:RMActionStyleDone andHandler:^(RMActionController *controller) {

        }]];
        actionController.disableBouncingEffects = YES;
        actionController.disableBlurEffectsForBackgroundView = YES;

        //On the iPad we want to show the map action controller within a popover. Fortunately, we can use iOS 8 API for this! :)
        //(Of course only if we are running on iOS 8 or later)
        if([actionController respondsToSelector:@selector(popoverPresentationController)] && [UIDevice currentDevice].userInterfaceIdiom == UIUserInterfaceIdiomPad) {
            //First we set the modal presentation style to the popover style
            actionController.modalPresentationStyle = UIModalPresentationPopover;
            //Then we tell the popover presentation controller, where the popover should appear
//            actionController.popoverPresentationController.sourceView = self.tableView;
//            actionController.popoverPresentationController.sourceRect = [self.tableView rectForRowAtIndexPath:[NSIndexPath indexPathForRow:0 inSection:0]];
        }

        //Now just present the date selection controller using the standard iOS presentation method
        actionController.contentView = [[UIView alloc] initWithFrame:CGRectZero];
        actionController.contentView.translatesAutoresizingMaskIntoConstraints = NO;

        MPVolumeView * volumeView = [[MPVolumeView alloc] initWithSize:CGSizeMake(0,50)];
        volumeView.autoresizingMask = UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;
        [actionController.contentView addSubview:volumeView];

/*
        NSDictionary *bindings = @{@"contentView": actionController.contentView};
        [actionController.contentView addConstraints:[NSLayoutConstraint constraintsWithVisualFormat:@"[contentView(>=300)]" options:0 metrics:nil views:bindings]];
        [actionController.contentView addConstraints:[NSLayoutConstraint constraintsWithVisualFormat:@"V:[contentView(140)]" options:0 metrics:nil views:bindings]];
*/

        [[UIApplication sharedApplication].keyWindow.rootViewController  presentViewController:actionController animated:YES completion:nil];

and i hope to write like this (case for iphone only - just set contentview. and the end):

RMActionController *actionController = [RMActionController actionControllerWithStyle:RMActionControllerStyleBlack
                                                                                       title:@"Test"
                                                                                     message:@"This is a test action controller.\nPlease tap 'Select' or 'Cancel'."
                                                                                selectAction:nil
                                                                             andCancelAction:nil];

        [actionController addAction:[RMAction actionWithTitle:@"Done" style:RMActionStyleDone andHandler:^(RMActionController *controller) {

        }]];

        actionController.disableBouncingEffects = YES;
        actionController.disableBlurEffectsForBackgroundView = YES;

// just set contentview. and the end.
        actionController.contentView = [[MPVolumeView alloc] initWithSize:CGSizeMake(0,50)];
        actionController.contentView.autoresizingMask = UIViewAutoresizingFlexibleWidth;

        [[UIApplication sharedApplication].keyWindow.rootViewController  presentViewController:actionController animated:YES completion:nil];

Crashes in iOS 7.1 with message: dyld: Symbol not found: _UIAccessibilityIsReduceMotionEnabled

Suggested fix (if there is a better fix let me know, I can submit a Pull request)

• (BOOL)disableBouncingEffects { if ([[[UIDevice currentDevice] systemVersion] floatValue] >= 8.0) { if(&UIAccessibilityIsReduceMotionEnabled && UIAccessibilityIsReduceMotionEnabled()) { return YES; } } return _disableBouncingEffects; }
• (BOOL)disableMotionEffects { if ([[[UIDevice currentDevice] systemVersion] floatValue] >= 8.0) { if(&UIAccessibilityIsReduceMotionEnabled && UIAccessibilityIsReduceMotionEnabled()) { return YES; } } return _disableMotionEffects; }

If you init the control with “Select” and “Cancel” the actions are stored in the doneActions array, which is not check when taping outside the control.

+ (instancetype)actionControllerWithStyle:(RMActionControllerStyle)style title:(NSString *)aTitle message:(NSString *)aMessage selectAction:(RMAction *)selectAction andCancelAction:(RMAction *)cancelAction {
    ...
    if(selectAction && cancelAction) {
        RMGroupedAction *action = [RMGroupedAction actionWithStyle:RMActionStyleDefault andActions:@[cancelAction, selectAction]];
        [controller addAction:action];
    ...
}

This PR replaces the use of [UIColor whiteColor] as a container background when transparency / blur is disabled with the system-defined [UIColor secondaryBackgroundColor] on iOS 13+ as this color is impacted by dark/light mode.

Hi,

In dark mode, the header title and header message, are not visible enough, and difficult to change. I suggest that you expose (public) the headers' properties (headerTitleLabel headerMessageLabel).

Currently, the labels for title and message are not customizable at all.

Requested in: https://github.com/CooperRS/RMDateSelectionViewController/issues/84

Hey there,

As far as I understand, the only way to modify the default fonts is by subclassing.

Is there any chance you could expose those labels/buttons so we can modify them directly, instead of having to subclass? I'm currently having issues trying to subclass in Swift using Generics. I'm forced to create concrete subclasses and that's not ideal. :/

I just want to modify the font for the title/description header text, as well as the RMAction buttons I add. Not just for RMActionController but also for the RMDateSelectionViewController.

Is this something you would consider adding, a better way to modify default values without having to subclass? Even you don't want to expose the UI elements directly, using a custom "default styles" object/class would do the job as well.

What do you think?

Hi,

really appreciate your work.

Would it be possible to add a property that allows a subclass to specify the border width to be used ?

Currently the constraints are fixed to 10px when setting up the container constraints in setupConstraints. From a visual perspective it would fit better to my app if this was only 2px. The same issue I have with setupTopContainersTopMarginConstraint where you use a fixed size as well.

So ideally one would be able to set the leading, trailing, top and bottom margin from a subclass using a public float property or a function that one could override in a subclass.