I was using the 'iPhone13Family' branch because it had the iPhone 13 devices in it. That branch has now been removed, but SPM can only seem to find version 7.0.1 and not 7.0.3

I believe 7.0.3 is the version that includes iPhone 13 devices.

Hoping this is a quick fix. Thanks, Joe

Xcode compiler complains "Overlapping accesses to 'name', but modification requires exclusive access; consider copying to a local variable"

DeviceGuru.swift file (lines 23 & 25).

23. sysctl(&name, 2, nil, &size, &name, 0)
24. sysctl(&name, 2, &hw_machine, &size, &name, 0)

Hi, I was trying to upload an app to AppStore Connect with DeviceGuru framework built using Carthage and I received this error:

This bundle Payload/xxx.app/Frameworks/DeviceGuru.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion.

I checked Info.plist in the framework and version was actually missing. I checked also DeviceGuru project and it looks like bundle version is set to $(CURRENT_PROJECT_VERSION) but this option is empty in build settings.

Can you fix this by adding some value to CURRENT_PROJECT_VERSION option in build setting, so I can successfully upload my app.

Thanks

Hi,

it looks like current master doesn't work. When I try to build the project I get this error:

/.../DeviceGuru/Sources/DeviceGuru.swift:82:31: error: cannot find type 'Platform' in scope
    public func platform() -> Platform {
                              ^~~~~~~~
/.../DeviceGuru/Sources/DeviceGuru.swift:135:36: error: cannot find type 'DeviceVersion' in scope
    public func deviceVersion() -> DeviceVersion? {
                                   ^~~~~~~~~~~~~
/.../DeviceGuru/Sources/DeviceGuru.swift:180:45: error: cannot find type 'DeviceVersion' in scope
    func getVersion(from string: String) -> DeviceVersion? {
                                            ^~~~~~~~~~~~~
/.../DeviceGuru/Sources/DeviceGuru.swift:38:34: error: type 'Bundle' has no member 'module'
            if let path = Bundle.module.path(forResource: resource, ofType: type) {
                          ~~~~~~ ^~~~~~

I found that Platform.swift and DeviceVersion.swift files are not added to the project.

I'm using Xcode 12.1 and working on the code downloaded directly from the repository.

Thanks

On a iPhone 7 with iOS 12.1, using Xcode 10.1 Beta 3, the method hardwareNumber returned nil instead of the phone version (9.2 in this case). Changing the method return type from Float to Double fixed the problem.

Normally, this type of projects would have an example app, as you can see here and here. I'll create an example and push a PR.

What do you think? :smiley:

I've been using DeviceUtil which is being replaced by DeviceGuru.

Sadly, I'm not a Swift guru, so am hoping someone can provide examples on how to use DeviceGuru in my Objective-C project. Thanks.

Hello!

Basically what's happening is when I'm debugging my application, sometimes this crash occurs. The most part happens when I put a break point in some line of code or try to stop on a break point.

We also discovered that this crash happens on production code some times.

We're testing on simulator (iPhone 11 Pro 14.4)

The lib is up to date on 7.0.1 version, using cocoapods.

Adding this library into Swift Package Manager using Xcode 12 generates a following warning "The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99." There are a couple solutions to this that I know:

1. Deployment target can be increased to .iOS(.v9) in the main Package.swift file.

2. A separate Package manifest can be created to target a specific swift version.

I went the second way to make changes smaller.

According to multiple sources the iPhone11,4 belongs to the XS Max China and the iPhone11,6 belongs to the XS Max Global. I can also confirm that devices used in Germany are reporting iPhone11,6

https://gist.github.com/adamawolf/3048717 https://www.theiphonewiki.com/wiki/Models

This could be a bug, but probably more so a clarification question.

I'm on 3.0.1 and running on my iPhone X I purchased through Verizon here in the United States. However the following device info is being printed:

(lldb) po deviceGuru.hardwareString()
"iPhone10,3"

(lldb) po deviceGuru.hardwareDescription()
▿ Optional<String>
  - some : "iPhone X China/Japan"

(lldb) po deviceGuru.hardware()
DeviceGuru.Hardware.iphoneX_cn

(lldb) po deviceGuru.hardwareNumber()
10.3000002

What's the difference between China/Japan and Global?

Crashed: com.apple.main-thread
0  DeviceGuru                     0xf6f4 $s10DeviceGuru36HardwareDetailProviderImplementationV14hardwareStringSSvgTf4d_n + 816
1  DeviceGuru                     0x7894 $s10DeviceGuru0aB14ImplementationC15_hardwareString33_6D9CB63EE52D478D829B7739F6A9542CLLSSvg + 76
2  DeviceGuru                     0x7a10 $s10DeviceGuru0aB14ImplementationC8platformAA8PlatformOvg + 16
3  OurApp                        0x3bd620 SecureEnclaveService.hasSecureEnclave.getter + 14 (DeviceGuru+SecureEnclave.swift:14)

how we invoke DeviceGuru in our code:

extension DeviceGuru {
    func supportSecureEnclave() -> Bool {
        if platform == .iPodTouch { //line 14
            return false
        }
        ...    
   }

We've got a lot of crashes with such stack trace for iOS 13 and iOS 14 users. DeviceGuru version is 10.0.1

Was looking in to how this might work. With the current implementation, running on an M1 mac appears to always yield iPad8,6. However sentry seems to be able to detect the difference with their implementation. I lack much time to work on this currently, but here is a start, in case that is useful.

	<key>iMac21,1</key>
	<dict>
		<key>name</key>
		<string>iMac (24-inch, M1, 2021)</string>
		<key>enum</key>
		<string>IMAC_2021</string>
	</dict>
	<key>iMac21,2</key>
	<dict>
		<key>name</key>
		<string>iMac (24-inch, M1, 2021)</string>
		<key>enum</key>
		<string>IMAC_2021</string>
	</dict>
	<key>Macmini9,1</key>
	<dict>
		<key>name</key>
		<string>Mac mini (M1, 2020)</string>
		<key>enum</key>
		<string>MAC_MINI_2020</string>
	</dict>
	<key>MacBookAir10,1</key>
	<dict>
		<key>name</key>
		<string>MacBook Air (M1, 2020)</string>
		<key>enum</key>
		<string>MACBOOK_AIR_2020</string>
	</dict>
	<key>Mac14,2</key>
	<dict>
		<key>name</key>
		<string>MacBook Air (M2, 2022)</string>
		<key>enum</key>
		<string>MACBOOK_AIR_2022</string>
	</dict>
	<key>MacBookPro17,1</key>
	<dict>
		<key>name</key>
		<string>MacBook Pro (13-inch, M1, 2020)</string>
		<key>enum</key>
		<string>MACBOOK_PRO_2020</string>
	</dict>
	<key>MacBookPro18,1</key>
	<dict>
		<key>name</key>
		<string>MacBook Pro (16-inch, 2021)</string>
		<key>enum</key>
		<string>MACBOOK_PRO_16_2021</string>
	</dict>
	<key>MacBookPro18,2</key>
	<dict>
		<key>name</key>
		<string>MacBook Pro (16-inch, 2021)</string>
		<key>enum</key>
		<string>MACBOOK_PRO_16_2021</string>
	</dict>
	<key>MacBookPro18,3</key>
	<dict>
		<key>name</key>
		<string>MacBook Pro (14-inch, 2021)</string>
		<key>enum</key>
		<string>MACBOOK_PRO_14_2021</string>
	</dict>
	<key>MacBookPro18,4</key>
	<dict>
		<key>name</key>
		<string>MacBook Pro (14-inch, 2021)</string>
		<key>enum</key>
		<string>MACBOOK_PRO_14_2021</string>
	</dict>
	<key>Mac14,7</key>
	<dict>
		<key>name</key>
		<string>MacBook Pro (13-inch, M2, 2022)</string>
		<key>enum</key>
		<string>MACBOOK_PRO_2022</string>
	</dict>

diff --git a/Generator/main.swift b/Generator/main.swift
index 09c145b..87d7449 100755
--- a/Generator/main.swift
+++ b/Generator/main.swift
@@ -98,6 +98,8 @@ func main() {
     let unknownIpadCase = "unknownIpad"
     let unknownAppleWatchCase = "unknownAppleWatch"
     let unknownAppleTVCase = "unknownAppleTV"
+    let unknownImacCase = "unknownImac"
+    let unknownMacCase = "unknownMac"
 
 
     var deviceList: [String: [String: AnyObject]] = [:]
@@ -128,7 +130,9 @@ func main() {
         + "\n\(tabSpacing)case \(unknownIpodCase)"
         + "\n\(tabSpacing)case \(unknownIpadCase)"
         + "\n\(tabSpacing)case \(unknownAppleWatchCase)"
-        + "\n\(tabSpacing)case \(unknownAppleTVCase)\n"
+        + "\n\(tabSpacing)case \(unknownAppleTVCase)"
+        + "\n\(tabSpacing)case \(unknownImacCase)"
+        + "\n\(tabSpacing)case \(unknownMacCase)\n"
 
         + "\n\(tabSpacing)case simulator\n"
 
@@ -166,6 +170,20 @@ func main() {
         let swiftEnumCase = normalizedEnum($0.enumCase)
         enumString += "\n\(tabSpacing)case \(swiftEnumCase)"
     }
+    enumString += "\n"
+
+    let iMacModels = getUniqueSortedModels(havingPrefix: "iMac", from: generatorDeviceList)
+    iMacModels.forEach {
+        let swiftEnumCase = normalizedEnum($0.enumCase)
+        enumString += "\n\(tabSpacing)case \(swiftEnumCase)"
+    }
+    enumString += "\n"
+
+    let macModels = getUniqueSortedModels(havingPrefix: "Mac", from: generatorDeviceList)
+    macModels.forEach {
+        let swiftEnumCase = normalizedEnum($0.enumCase)
+        enumString += "\n\(tabSpacing)case \(swiftEnumCase)"
+    }
 
     print("Creating \(enumFile)")
     do {
@@ -206,7 +224,9 @@ func main() {
             + "\(tabSpacing)\(tabSpacing)if (hardwareString.hasPrefix(\"iPod\")) { return .\(unknownIpodCase) }\n"
             + "\(tabSpacing)\(tabSpacing)if (hardwareString.hasPrefix(\"iPad\")) { return .\(unknownIpadCase) }\n"
             + "\(tabSpacing)\(tabSpacing)if (hardwareString.hasPrefix(\"Watch\")) { return .\(unknownAppleWatchCase) }\n"
-            + "\(tabSpacing)\(tabSpacing)if (hardwareString.hasPrefix(\"AppleTV\")) { return .\(unknownAppleTVCase) }\n\n"
+            + "\(tabSpacing)\(tabSpacing)if (hardwareString.hasPrefix(\"AppleTV\")) { return .\(unknownAppleTVCase) }\n"
+            + "\(tabSpacing)\(tabSpacing)if (hardwareString.hasPrefix(\"iMac\")) { return .\(unknownImacCase) }\n"
+            + "\(tabSpacing)\(tabSpacing)if (hardwareString.hasPrefix(\"Mac\")) { return .\(unknownMacCase) }\n\n"
             + "\(tabSpacing)\(tabSpacing)return .unknownDevice\n"
             + "\(tabSpacing)}\n"
             + "}\n"

Right now (Oct 2022) the size of the file is 19.2 KB which is not that significant, but eventually it will grow. I think we should start thinking to split this plist based on multiple platforms. It might not be a huge improvement to iPhone/iPad but can be significant to watch OS

Although we already made improvement by loading the plist file only first time and subsequent information is read from user defaults which is quite cheap. Let's gather some data and then take the decision.