In the current version of Swift NSStringFromClass(ClassName) returns // ProjectName.Pokemon.

So we can easily add a new function in NSManagedObject that returns only the ClassName without forcing the user to add @objc(ClassName) to each NSManagedObject.

What do you think @michaelarmstrong?

Hi,

I have created a sample test that could be a good starting point.

Changes:

1. Created sample Model, with two entities: Pokemon and Type.
2. Created sample test
3. Changed extensions visibility to public, to allow framework use.
4. Added completionHandler (default values is nil) in findAllWithPredicate and findFirstOrCreateWithPredicate. The completion handler is necessary to allow async test and it should be added to all the function that call findAllWithPredicate or findFirstOrCreateWithPredicate
5. Added SuperRecordTestsTestCase : XCTestCase, ovveriding setUp function initializing the test managedObjectContext.

I've fixed an error that can affect some Simulator (mine for example) running unit-test.

2015-10-21 17:10:24.579 xctest[703:8687] CoreData: error: (522) I/O error for database at /Users//Library/Developer/CoreSimulator/Devices/5E7487DC-2883-45F6-8CC1-FB90A2EB73C1/data/Documents/Pokemon.sqlite. SQLite error code:522, 'not an error' fatal error: 'try!' expression unexpectedly raised an error: Error Domain=NSCocoaErrorDomain Code=522 "(null)" UserInfo={NSSQLiteErrorDomain=522, NSUnderlyingException=I/O error for database at /Users//Library/Developer/CoreSimulator/Devices/5E7487DC-2883-45F6-8CC1-FB90A2EB73C1/data/Documents/Pokemon.sqlite. SQLite error code:522, 'not an error', NSFilePath=/Users/*/Library/Developer/CoreSimulator/Devices/5E7487DC-2883-45F6-8CC1-FB90A2EB73C1/data/Documents/Pokemon.sqlite}: file /Library/Caches/com.apple.xbs/Sources/swiftlang/swiftlang-700.0.59/src/swift/stdlib/public/core/ErrorType.swift, line 50

Running multiple tests the database seems to be corrupted, maybe caused by sqlite temporary files.

I've improved NSPersistentStore deletion in tearDown.

Thanks

SuperRecord doesn't want to compile with the changes in Swift 1.2.

The major issue is the introduction of the failable cast as! over as, and there are some minor issues with optionality in CoreData and UIKit, and a few type checking issues too. I have to ship something before weekend, so I'll be working on this. Have you started any work on it yet? Or shall I just get stuck into it?

Thanks

hello, the demo will not build.

error is SuperRecordDemo.xcodeproj cannot be opened because it is missing its project.pbxproj file.

xcode 6.1.1 iOS 8.1

So one of the things I liked about magical record is that it if your store changes.. instead of crashing on app launch (and loading of the persistent store from file system).. it attempts to just delete the existing store and create a new one.

This is useful while your app is in development because currently if you're pushing out builds every day or couple of days to your team of internal test users, you have 3 options for handling database changes.

1. Do a migration for every build
2. Tell them if it crashes, to delete and reinstall

With this implementation.. you can just tell them that they may lose data between installs.

Discussion areas:

1. This currently blindly deletes and recreates the store on any error.. would be interested in narrowing that.. and have some ideas for how to do that, but thought I'd ask for ideas on what other errors can come through this.
2. Might be good to just have this as a feature that can be enabled/disabled. Or available for development only? Interested in thoughts!

Hi!

I have removed all:

let context = SuperCoreDataStack.defaultStack.managedObjectContext!

using swift optional values, so functions like

class func findFirstOrCreateWithAttribute(attribute: NSString!, value: NSString!, context: NSManagedObjectContext) -> NSManagedObject 

Became

class func findFirstOrCreateWithAttribute(attribute: NSString!, value: NSString!, context: NSManagedObjectContext = SuperCoreDataStack.defaultStack.managedObjectContext!) -> NSManagedObject 

We need to get this finalized and merged in ASAP... Swift 2.0 is out guys. @PGLongo @rromanchuk I've made a couple of small changes, but it needs some attention still.

If the target contains space the model is automatically named with '_' instead of ' ', for example 'Pokemon Ruby Omega' became 'Pokemon_Ruby_Omega'

let stackName = (infoDictionary!["CFBundleName"] as NSString

We could change stackName like this

let stackName = (infoDictionary!["CFBundleName"] as NSString).stringByReplacingOccurrencesOfString(" ", withString: "_")

Maybe we can also change NSString to String.

@michaelarmstrong I have added Travis CI support, but I cannot change the settings of the repo so I can't enable the GitHub Webhook. It's very simple, follow this instructions.

Thanks

Added predicateBuilder that create a NSPredicate from 3 parameters:

1. Attribute name
2. Attribute value (any object)
3. NSPredicateOperator

enum NSPredicateOperator : String {
    case And = "AND"
    case Or = "OR"
    case In = "IN"
    case Equal = "=="
    case NotEqual = "!="
    case GreaterThan = ">"
    case GreaterThanOrEqual = ">="
    case LessThan = "<"
    case LessThanOrEqual = "<="
}

    class func predicateBuilder(attribute: String!, value: AnyObject, predicateOperator: NSPredicateOperator ) -> NSPredicate? {
        var predicate = NSPredicate(format: "%K \(predicateOperator.rawValue) $value", attribute)
        predicate = predicate?.predicateWithSubstitutionVariables(["value" : value]);
        return predicate
    }

For example:

NSPredicate.predicateBuilder("level", value: 16, predicateOperator: .LessThan)
NSPredicate(format: "level < 16")
...
NSPredicate.predicateBuilder("name", value: "Charmender", predicateOperator: .Equal)
NSPredicate(format: "name == \"Charmender\"")

Using predicateBuilder I have improved findFirstOrCreateWithAttribute, now it works with all value and not only with strings

class func findFirstOrCreateWithAttribute(attribute: String!, value: AnyObject!, context: NSManagedObjectContext = SuperCoreDataStack.defaultStack.managedObjectContext!, handler: ((NSError!) -> Void)! = nil) -> NSManagedObject {
        var predicate = NSPredicate.predicateBuilder(attribute, value: value, predicateOperator: .Equal)
        return findFirstOrCreateWithPredicate(predicate, context: context, handler)
}

I have also added a new init method to allow the creation of more complex NSPredicate (the kind of firstCondition AND ( secondCondition OR thirdCondition)

 convenience init?(firstPredicate : NSPredicate, secondPredicate: NSPredicate, predicateOperator: NSLogicOperator ) {
            self.init(format: "(\(firstPredicate)) \(predicateOperator.rawValue) (\(secondPredicate))")
}

I think that we could change NSManagedObject extension using generics.

For example:

Now

func createNewEntity(context:) -> NSManagedObject {}
...
let pokemon = Pokemon.createNewEntity() as! Pokemon

After

class func createNewEntity <T> (context:) ->  T {}
...
let pokemon : Pokemon = Pokemon.createNewEntity()

In my opinion is more secure because you receive a compile error if the type is not explicit!

If the target as a name with space like "Super Record" iOS replace the space with an "_" so the correct name for the model become "Super_Record.momd"

I have solved temporarily changing:

let infoDictionary = NSBundle.mainBundle().infoDictionary as NSDictionary?
let stackName = (infoDictionary!["CFBundleName"] as! String)
let storeName = stackName + ".sqlite"

with

let infoDictionary = NSBundle.mainBundle().infoDictionary as NSDictionary?
let stackName = (infoDictionary!["CFBundleName"] as! String).stringByReplacingOccurrencesOfString(" ", withString: "_")
let storeName = stackName + ".sqlite"

@michaelarmstrong you should considering it if you are writing the new stack.

This extension is a great class, but it needs to be decoupled. https://github.com/michaelarmstrong/SuperRecord/blob/master/SuperRecord/NSFetchedResultsControllerExtension.swift#L102

We use a more advanced stack so this line gives us problems. In general it's probably better to force the callee to be responsible for sending the MOC, always. In general calling back up to the delegate for the moc is bad practice, especially when there isn't just a single MOC being used everywhere.

SuperCoreDataStack assumes your backing store is named the same as your App name. Additionally it uses the Apple boiler-plate and does not support any CoreData configuration other than a single main thread context.

Calls also require an explicit mention of either defaultStack or inMemoryStack... this pattern needs improving to a single line of setup in the AppDelegate on app launch.

It should firstly allow the user to specify which stack to use. Something like:

SuperCoreDataStack.setup(type: SuperRecordStackType, storeURL: NSURL = someDefault)

So you can do...

SuperCoreDataStack.setup(.inMemoryStore)

or something like the following.

 //let sharedURLForAppGroup = NSFileManager.defaultManager().containerURLForSecurityApplicationGroupIdentifier("com.someidentifier")

let sharedURLForCloud =      NSFileManager.defaultManager().URLForUbiquityContainerIdentifier("com.someidentifier")

SuperCoreDataStack.setup(.persistentStore, sharedURLForAppGroup)

which gives the user much more flexibility.

This will also make the stack: property in all related calls purely optional and an override of this setting.

I will begin this part of the work today.

The threading model i'll open a separate issue for as I have some ideas which i'd like to share and get commentary back on.