I did not do much apart from running it through the Xcode converter. The main changes are instead of using the full names for calendar components (eg CalendarUnitYear) we now use the enum (eg .Year).

This part is messing around

    private func NSDateTimeAgoLocalizedStrings(key: String) -> String {
      // get framework bundle
      let bundleIdentifier = "com.akosma.SwiftMoment"
      guard let frameworkBundle = NSBundle(identifier: bundleIdentifier) else {
        return "" <<----
      }

PS: I'm using pods

testCanCreateWeirdDateFromComponents() and testFormatDates() fail if run in Chicago, IL because the expected result is time zone-specfic. This is because NSDateFormatter uses the local time zone.

Line 413 in Moment.swift will cause unexpected result.

cal.timeZone = NSTimeZone(abbreviation: "UTC")!

For example:

I have a date: "2016-07-01 00:00:00 GMT+08:00", then I called date.add(1, .Months), I expect to get "2016-08-01 00:00:00 GMT+08:00", but I only got "2016-07-30 16:00:00 GMT+00:00", which is "2016-07-31 00:00:00 GMT+08:00". You just convert my original date to "2016-06-30 16:00:00 GMT+00:00", then add a month. Bang!

I modified this line as below:

cal.timeZone = timeZone
cal.locale = locale

Then it went right, but I don't know is there any other errors it would cause.

Added an OS X Target and Test Target

Supports OS X 10.10 and links to the original tests Tests Pass!

To use in your OS X Project: http://stackoverflow.com/questions/24993752/os-x-framework-library-not-loaded-image-not-found

Including The Framework Drag the created .framework file into the Xcode Project, be sure to tick 'Copy Files to Directory' In the containing applications target, add a new 'Copy File Build Phase' Set the 'Destination' to 'Frameworks' Drag in the created .framework

I use carthage. The version 0.7 can't be built but 0.6 works.

Here is the failure output

MomentTests.swift:13:1: error: Type Body Length Violation: Type body should span 350 lines or less excluding comments and whitespace: currently spans 400 lines (type_body_length)

I'm trying to create a moment with GMT-0300 date, from a GMT date string with format "yyy-MM-dd'T'HH:mm:ss" by doing let timeZone = TimeZone(secondsFromGMT: -10800) let locale = Locale(identifier: "en_US_POSIX") let teste = moment(dateString, dateFormat: "yyy-MM-dd'T'HH:mm:ss", timeZone: timeZone!, locale: locale)

For example: dateString = "2016-10-12T10:02:50" And I want my moment to store hour = 7, minute = 02

No matter which TimeZone I use to create it, it always returns the time that was given in dateString. I couldn't find any documentation on this. Is there any way to to do so?

Instantiate NSDateFormatter is expensive operation and you use it exactly that way. You can read this in Apple documentation:

Creating a date formatter is not a cheap operation. If you are likely to use a formatter frequently, it is typically more efficient to cache a single instance than to create and dispose of multiple instances. One approach is to use a static variable.

It is needed to support swift 2.3 and I found out that just replacing codes in MomentFromNow.swift#104 to

#if swift(>=2.3)
  let path = NSURL(fileURLWithPath:resourcePath).URLByAppendingPathComponent(bundleName)!
#else
  let path = NSURL(fileURLWithPath:resourcePath).URLByAppendingPathComponent(bundleName)
#endif

makes XCode 8 build fine.

So i'm ready for pulling request.

Which is better?

1. Support both version (swift2.2 and swift2.3) in master branch using #ifswift like above.
2. Make another branch swift2.3 and split build environment into Xcode 7 and Xcode 8

Marked Xcode scheme as shared to support Carthage. I think a new tag will need to be created too - see here.

Fixes this error when trying to use SwiftMoment with Carthage: Project "SwiftMoment.xcodeproj" has no shared schemes

• Fixed two tests and changed Moment isEqual comparator
• Added fastlane to simplify testing
• Changed .travis.yml to use fastlane
• Fastlane does not support instrumenting macOS tests so we just build

Detailed Description

When I try to parse the date in specific format I get one year backdate.

Possible Implementation

let day = moment("178-06-2019", dateFormat: "DD-MM-YYYY") returns // 2018-12-23 00:00:00 GMT+05:30

Your Environment

• Version used: (0.7)
• Operating System and version: Xcode Playground

I'm having problems running the framework in Swift 4 the project simply stops running when it comes to checking the framework SwiftMoment I'm in the latest version of Swift 4 and Xcode. If I'm not mistaken in this last update, the class set that started with NS was untouched. Xcode basically complains about all Swift class that starts with NS it complains.

I'm trying to get tomorrow's date like this, but it just returns today's.

moment().add(1, "days").format("MMMM do")

This works fine in Javascript moment().add(1, "days").format("MMMM Do")

Your Environment

Swift 4.0 Xcode Version 9.2 (9C40b)

It seems to subtract 30 days instead of 1 whole month.

Detailed Description

If the starting date is 1/30/2018, and I subtract 1 month, it becomes 12/31/2017, I would have expected 12/30/2017. If I subtract 2 months, it becomes 12/01/2017. I would have expected it to be 11/30/2017.

Your Environment

• Version used: 0.7
• Operating System and version: latest version of Swift, Xcode

Detailed Description

getLanguageBundle is returning nil. Strangely, locale.identifier is returning zh-TW, without the "Hant".

The 2nd part of getLanguageBundle therefore only get the language code as zh.

Since now the bundle only has zh-Hant, no localized string is found.

Context

Localization does not work for Taiwan app users.

Possible Implementation

I believe another fallback using Bundle to load will work.

Your Environment

• Version used: 0.7
• Operating System and version: 11.2
• Link to your project: -