GitHub iOS client in RxSwift and MVVM-C clean architecture

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

1. Go to 'Setting'
2. Click on 'Theme' open status
3. Click on other tabbar 'Theme' status update Not in time
4. See error

in User events, there are 2 segments received and performed. when you tap on received it shows the performed ones instead.and vice versa.

I debugged this line https://github.com/khoren93/SwiftHub/blob/master/SwiftHub/Modules/Events/EventsViewModel.swift#L138 the segment returns received when you tap on Performed segment.

I added another segment, so we have now 3 segments, it returns wrong segment index each time.

Same for Issues.

Is your feature request related to a problem? Please describe. I have used this awesome App, but I found the markdown file not render.

Describe the solution you'd like Can you add the feature for markdown file render?

Describe alternatives you've considered

Additional context If App can render markdown file and add a toc. It will be perfect.

Hey,

I tried to use this new binder you created in an extension of UINavigationBar var largeTitleTextAttributes: Binder<[NSAttributedString.Key: Any]?>

When I am trying to bind something on it it says Property 'largeTitleTextAttributes' requires that 'UINavigationItem' inherit from 'UINavigationBar' do you have any ideas why it wouldn't work?

Thank you!

Describe the bug When downloaded from App Store with not login status, pull up on home page, the footer refresh animation will not show, as the gif shows: To Reproduce Steps to reproduce the behavior:

1. Go to 'Home Page'
2. Scroll down to `load more'
3. See error

Expected behavior It should animate footer naturally

Screenshots

Desktop (please complete the following information):

• OS: [ iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 1.6.0 App Store]

Smartphone (please complete the following information):

• Device: [e.g. iPhoneX]
• OS: [e.g. iOS12.1.4]

Hey just want to let you know that your Firebase plist is included in your Repo. Not sure if you have anything critical in there but it could be exposing any DB contents you have or access to your services. Thanks for contributing this great work, looking forward to playing around with it.

Describe the bug The flex debug menu opens in the app store version of the app when swiping back with only one finger.

To Reproduce Steps to reproduce the behavior:

1. Start the App Store version of the app.
2. Swipe from the left edge of the screen to the right edge / middle of the screen.

Expected behavior The flex debug menu shall not appear in the app store build.

Smartphone (please complete the following information):

• Device: iPhone Xs
• OS: 12.2 (16E5201e)

I found a minor issue that in HomeTabBarController, the WhatsNewController will be present at viewDidLoad, rather than viewDidAppear.

Actually, the input.whatsNewTrigger in HomeTabBarViewModel is not accessed at all, which should be considered as an issue and here is the fix.

Is your feature request related to a problem? Please describe. We were using the app and decided to test how it reacted to loss of internet mid use. If we suddenly lost internet connection, there was no feedback.

Describe the solution you'd like We suggest to add a constant Network Manager (a singleton class) that informs the user when he is out of internet. This is just as a reminder, because if a user tries to use the app but doesn’t have internet, he could be waiting forever for it to load.

Describe alternatives you've considered We developed a version that works for our apps in Swift 5.0. We tried implementing it in SwiftHub to do a Pull Request but since it’s Swift 4.0, it had some issues. I’m adding some screenshots of our solution. The “Toast” class is simply a way to present messages in a Toast fashion like Android.

Additional context

Is your feature request related to a problem? Please describe. Some icons (Snapshot below) are hard to understand, i had to press them and take a moment to see what changed to understand what was their purpose.

Describe the solution you'd like Perhaps a hover text with a description should be created when the user holds an icon.

Describe alternatives you've considered text fields below the icons describing their use.

[17:26:23]: fastlane finished with errors

Looking for related GitHub issues on fastlane/fastlane...

bundler: failed to load command: fastlane (/usr/bin/fastlane) FastlaneCore::Interface::FastlaneShellError: [!] Exit status of command 'brew install node' was 1 instead of 0. Error: Running Homebrew as root is extremely dangerous and no longer supported. As Homebrew does not drop privileges on installation you would be giving all build scripts full access to your system.

Thanks for sharing such a complete project. Now I have a problem, I need to set the status of loading more components to "no more data", how to do it

Hi, I want to run your project use Xcode 13.4.1. I have clean Xcode cache, and used "bundle exec fastlane update" and "pod install". But still report the following errors...What should I do? Thanks very much.

Pods project errors: artifact not found for target 'GoogleAppMeasurementIdentitySupport' artifact not found for target 'FirebaseAnalytics'

Package Loading errors: Missing package product 'FirebaseCrashlytics' Missing package product 'FirebaseAnalytics'

Uncategorized: Command EmitSwiftModule failed with a nonzero exit code Command CompileSwift failed with a nonzero exit code

First of all, thank you for publishing such a great project.

There is a little issue regarding to the consistency of user interface. As you can see from the following screenshots, the situation can be reproduced when you slightly swipe up the screen.

Screenshots

Describe the bug Can you handle when I disconnect internet and try refresh the list data ? I can handle the error in the Networking.swift, but how can I let my refresh trigger not competed with error. I can't refresh the tableview again By using headerRefreshTrigger or footerRefreshTrigger ， because the subject is competed if receive the error.

To Reproduce Steps to reproduce the behavior:

Go to one TablView Controller disconnect the wifi refresh the data again loading forever didn't send the subject signal and can't send request again ,so the tableview is loading forever

Describe the bug Can you handle when I disconnect internet and try login button or other API request. The loading will forever and user can not touch any more.

To Reproduce Steps to reproduce the behavior:

1. Go to 'Login screen'. Turn of internet connection
2. Fill data and Click on 'Login button'
3. See error: loading forever