Open a 'About repository' interface.

1. Click the 'Favorite' button,
2. then click the 'Unfavorite' button
3. finally click the 'Favorite' button. The APP crashed.

Reason: When you click the 'Unfavorite' button, the repository is delete from Realm

    func delete(_ object: Object) {
        // Deletes an object from the Realm. Once the object is deleted it is considered invalidated.
        write { $0.delete(object) }
    }

Now, the repository is considered invalidated and can no longer be accessed.

When finally click the 'Favorite' button, you access the deleted repository, so that APP crashed.

    @objc func favoriteButtonTapped() {
        if !viewModel.repository.isFavorite {  // crash
        ...

1.https://github.com/Karambirov/GitHubSearch/issues/47 2.https://github.com/Karambirov/GitHubSearch/issues/43 3.https://github.com/Karambirov/GitHubSearch/issues/46

Codable and Realm objects should not be in the same class. It would be better if Realm object has convenience init with Codable object like so:

class UserRealm: Object {
    // ...
    convenience init(with: User) { 
        // ...
    }
}

https://github.com/volkanbicer/RealmStore

Maybe it worth it to create a service for searching instead of doing a search in VC.

What needs to be done:

• [ ] Searching service that encapsulates searching logic. Search for "SearchComponent"

https://www.lordcodes.com/articles/a-modular-analytics-layer-in-swift https://www.swiftbysundell.com/articles/building-an-enum-based-analytics-system-in-swift/

If you try to open from Search a repository that already has been saved, navigation bar button title in Details will be "Favorite".

• [x] While opening Details, check if the repository already saved.

If a user taps "Favorite" in Details, the repository saves to the Realm file (it works correctly, the entry appears in Realm Browser). However, fetching in Favorites doesn't work – the table stays empty.

• [x] Fix Favorites fetching

Just after search's table view has been populated with data from a network everything works as expected. But if you decide to switch tab to Favorites and back, Search will be black (maybe it's been deallocated).

• [x] Figure out what's wrong

Right now all errors in the app are printed into the console. There should be correct error handling, not just printing.

• [ ] Add Result type
• [ ] Handle errors correctly.

https://www.swiftbysundell.com/articles/providing-a-unified-swift-error-api/ https://www.swiftbysundell.com/basics/result/ https://www.swiftbysundell.com/articles/the-power-of-result-types-in-swift/ https://www.swiftbysundell.com/tips/result-type-convenience-apis/

When a user reached the end of the search results a new request should be sent.

• [ ] Show 25 results at a time (twice of what iPhone screen can show).
• [ ] Send a new request when a user reached the end of the list. Or send the request after the first half of the results have been shown.

UI must be user-friendly, so a user should be aware of loading, errors, absence of results.

• [ ] Handle error state. Show a message that something went wrong.
• [ ] Handle loading state. Show a spinner when trying to get results from a server.
• [ ] Handle empty state. Show a label in the middle of the screen that there are no results.

From Details screen user should be able to open Readme screen.

• [ ] Should be opened from Details.
• [ ] Should be available without an Internet connection.
• [ ] Markdown should be rendered like in a browser.