📹 Your next favorite image and video picker

I recently started using this library and really like the layout and that it takes care of some things like maximum length and saving photos/videos (so to say edited since only the first seconds allowed are saved) to the photos automatically. However, I now encountered a problem which I cannot solve. I initially used the following code in the didSelectVideo function (very similar to what is presented in the README.md):

internal var gallery: GalleryController?
internal let editor: VideoEditing = VideoEditor()

func galleryController(_ controller: GalleryController, didSelectVideo video: Video) {    
    controller.dismiss(animated: true, completion: nil)
    
    editor.edit(video: video) { (editedVideo: Video?, tempPath: URL?) in
        DispatchQueue.main.async {
            if let tempPath = tempPath {
                let controller = AVPlayerViewController()
                controller.player = AVPlayer(url: tempPath)
                
                self.present(controller, animated: true, completion: nil) 
            }
        }
    }
}

The video in the parantheses of edit seems to have the right properties when I set a breakpoint somewhere (i.e. right amount of seconds the selected video lasts). Moreover, the values match those which can be found under self > gallery > cart > videos. But if I now enter the edit function and the breakpoint at DispatchQueue.main.async is hit, it tells me editedVideo equals nil. In addition to that, tempPath appears to be some(?) and only becomes a path when AVPlayer(url: tempPath) is hit although this doesn't seem to be a problem. The problem is no viewcontroller is presented. If I add a simple print in the completion handler of the present function, nothing is ever printed.

Since video wasn't nil I tried the following code (in `didSelectVideo) - which didn't work either:

    print(video) //prints "Gallery.Video"

    controller.dismiss(animated: true, completion: nil)
    
    video.fetchPlayerItem { (playerItem) in
        DispatchQueue.main.async {
            let avPlayer = AVPlayer(playerItem: playerItem)
            
            let avPlayerViewController = AVPlayerViewController()
            avPlayerViewController.player = avPlayer
            
            //nothing happens
            self.present(avPlayerViewController, animated: true, completion: {
                print(1)
            })
        }
    }

On top of all this, there appears to be a memory leak I couldn't find a soltuion for either. Can someone help me and explain why this is happening? I would really appreciate your help!

First of all,thanks for this amazing plugin. Actually i want to select only one image and on done button action ,show a preview of that image in a new viewController. i used this code to show it within the did selectImages delegate method, `func galleryController(_ controller: GalleryController, didSelectImages images: [UIImage]) {

    imageSelected = images
    let storyboard = UIStoryboard(name: "Main", bundle: nil)
    let cont = storyboard.instantiateViewController(withIdentifier: "FilterAndEdit")
   
   // self.navigationController?.pushViewController(controller, animated: true)
   self.present(cont, animated: true, completion: nil)
    
   let appDelegate = UIApplication.shared.delegate as! AppDelegate
    //show
   appDelegate.window?.rootViewController = cont
  
}

it show another viewController with the selected image,And on back button action on that viewController,its moving back to Gallery also.. Then comes the problem,After coming back from previewVC,the close button of gallery is not working.it pops the gallery again and again. i using this code in galleryControllerDidCancel delegate method.func galleryControllerDidCancel(_ controller: GalleryController) {

controller.dismiss(animated: false) {
    
    self.tabBarController?.selectedIndex = 0

    }
    
}

` Im opening this gallery on tapping a tabbar under the screen.Also i getting a warning like

Attempt to present <XXXXX.FilterAndEdit: 0x7fbd8955ee40> on <XXXXX.uploadTab: 0x7fbd89511dc0> whose view is not in the window hierarchy!

Please help me to solve this.

Hi guys!

I want to give Gallery a try but the build with Carthage fails: error:(my project path)/Carthage/Checkouts/Gallery/Sources/Gallery.bundle: No such file or directory

** BUILD FAILED ** The following build commands failed: CpResource Sources/Gallery.bundle (my user path)/Library/Caches/org.carthage.CarthageKit/DerivedData/Gallery/1.0.0/Build/Products/Release-iphoneos/Gallery.framework/Gallery.bundle

(I removed my project and user path from the text above). Do you have any idea of what might be wrong? Thanks a lot :)!

Demo project contains many features like:

public struct Config {

@available(*, deprecated, message: "Use tabsToShow instead.")
public static var showsVideoTab: Bool {
    // Maintains backwards-compatibility.
    get {
        return tabsToShow.index(of: .videoTab) != nil
    }
    set(newValue) {
        if !newValue {
            tabsToShow = tabsToShow.filter({$0 != .videoTab})
        } else {
            if tabsToShow.index(of: .videoTab) == nil {
                tabsToShow.append(.videoTab)
            }
        }
    }
}
public static var tabsToShow: [GalleryTab] = [.imageTab, .cameraTab, .videoTab]
// Defaults to cameraTab if present, or whatever tab is first if cameraTab isn't present.
public static var initialTab: GalleryTab?

public enum GalleryTab {
    case imageTab
    case cameraTab
    case videoTab
}

}

But When I install pods (tried Carthage also)

public struct Config {

public static var showsVideoTab: Bool = true
public struct PageIndicator {
    public static var backgroundColor: UIColor = UIColor(red: 0, green: 3/255, blue: 10/255, alpha: 1)
    public static var textColor: UIColor = UIColor.white
}

public struct Camera {
    
    public static var recordLocation: Bool = false
    
    public struct ShutterButton {
        public static var numberColor: UIColor = UIColor(red: 54/255, green: 56/255, blue: 62/255, alpha: 1)
    }
    
    public struct BottomContainer {
        public static var backgroundColor: UIColor = UIColor(red: 23/255, green: 25/255, blue: 28/255, alpha: 0.8)
    }
    
    public struct StackView {
        public static let imageCount: Int = 4
    }
    
    public static var imageLimit: Int = 0
    
}

}

## This code just an example for issue reference. Is there is anything wrong? I tried pod update and Carthage update. But I can see the latest version of both but I can't find the code. I know I can add project directly (drag n drop) but I don't want to do that. This will restrict me to get an updated framework in future.

Description

When building the project with Xcode 11, the default value for PHImageRequestOptions.resizeMode is .fast. This causes the PHImageManager to send lower resolution images which appear blurred when displayed in the photo picker cells.

Xcode 10, iPhone 6s, default value ->.none: 256x342, sometimes 256x454 Xcode 11, iPhone 6s, default value -> .fast: 92x124 (looks blurred)

Changes

• Explicitly set resizeMode to .none

.none is the default value when building the project with Xcode 10.

Change 1
Before	After

(Open in new tab for better comparison)

Fixes an issue where images taken with the camera are returning low resolution 1080p images, regardless of device.

By adding the .photo preset, the highest possible image quality will be used for photos.

Reference: https://developer.apple.com/documentation/avfoundation/avcapturesessionpresetphoto?language=objc

iPhone camera photo size reference: https://www.cameracompany.com/blog/how-large-can-you-print-iphone-photos/

Fixes #160

Photos that are airdropped from mac to iPhone don't show up in the Gallery's camera roll (but are present in the phone's photo's app/camera roll). However, if you move photos to a new album they show up fine when you open Gallery and select that album.

Is there any setting to have airdropped photos show up by default in the users camera roll when they open Gallery?

My requirements are I have to open Gallery from Tab Bar Controller on pressing camera button. So it open video in full screen after selection hopefully for editing. I could not edit or play more with video. I got this crash.

2017-10-08 22:19:09.430663+0500 MOD[1368:468010] *** Terminating app due to uncaught exception 'UIViewControllerHierarchyInconsistency', reason: 'child view controller:<AVFullScreenPlaybackControlsViewController: 0x102805200> should have parent view controller:<AVPlayerViewController: 0x1020c7a00> but actual parent is:<AVFullScreenViewController: 0x101be8550>' *** First throw call stack: (0x1820bafe0 0x180b1c538 0x1820baf28 0x188267ccc 0x1881f4914 0x1881f3d88 0x1881f3bc8 0x18f959aa8 0x18f9585c0 0x182ae5050 0x182ac0d08 0x182ac0830 0x182aab790 0x18f9530e4 0x18f952df4 0x188203760 0x181fa9e34 0x181fa9d30 0x1881f2440 0x1881e649c 0x1883813e8 0x188380ec0 0x18831de64 0x18827be5c 0x18838196c 0x188222020 0x188366668 0x1882a6704 0x1881f3710 0x188261a80 0x188261a54 0x1882e66dc 0x18855c440 0x18855dcd0 0x1885607e4 0x1882dd794 0x18f95aa00 0x18f95db44 0x18f983a58 0x188221c54 0x188221bd4 0x18820c148 0x1882214b8 0x1887b60e8 0x1887b2434 0x1820689a8 0x182066630 0x182066a7c 0x181f96da4 0x183a01074 0x188251c9c 0x100047df0 0x180fa559c) libc++abi.dylib: terminating with uncaught exception of type NSException

Use this page configuration: Config.tabsToShow = [.imageTab, .cameraTab]

When I open the camera page with my iPhone(iPhone XR or iPhone 11 Pro) and do continuous rotate, it causes crash. It seem that PagesController`s UIScrollViewDelegate extension case Index out of range

I try install in xcode 10 and get the issue: Ambiguous type name 'State' in 'TripleButton' Please fix it. p/s: I rename 'State' to other name (ex: State1), the project will run success. I think admin should change it for someone.

i'v found camera man saves photos into assets. It means that Photos permission is always required. Also, if user wants to pickup images from gallery, but do not want to use camera, we also have to show gallery controller instead of permission blocker.

Hi guys, here are some of the warning alerts from Xcode: These are all in the CameraMan.swift file

'AVCaptureStillImageOutput' was deprecated in iOS 10.0: Use AVCapturePhotoOutput instead. 'devices()' was deprecated in iOS 10.0: Use AVCaptureDeviceDiscoverySession instead. 'AVCaptureStillImageOutput' was deprecated in iOS 10.0: Use AVCapturePhotoOutput instead. 'AVVideoCodecJPEG' was deprecated in iOS 11.0: renamed to 'AVVideoCodecType.jpeg' 'AVCaptureStillImageOutput' was deprecated in iOS 10.0: Use AVCapturePhotoOutput instead. 'isFlashModeSupported' was deprecated in iOS 10.0: Use AVCapturePhotoOutput's -supportedFlashModes instead. 'flashMode' was deprecated in iOS 10.0: Use AVCapturePhotoSettings.flashMode instead.

Can someone please rewrite the code in the GitHub CameraMan.swift file? Thank you.

I love this library a lot. Referred this library to several of my developer friends. And, I learnt a lot from this codebase. Thank you Contributors.

I understand it takes a lot of personal time to maintain open source libraries. But, it would help us a lot if could you please let us know if this library is going to be maintained further?

I see many open Pull Requests and Issues pending attention. Last update on master branch is done on 13 months ago.

Thank you!

Cc Contributors: @3lvis @onmyway133 @iosg1sw @Ruberik @scaraux @lars-fosaas @JohnSundell @hershalle @150vb @bemusementpark @telip007 @vcalfa @petekeller2 @weakfl @neilabdev @bruno-aguiar @richardtop @Hyperseed

When I select camera tab and capture a photo, that photo is saved to gallery. Please add feature where saving photo to gallery is optional. Thanks in advance.

Please add description how to add dependency as SPM and specify the version

When I try to add dep: Package.swift has no Package.swift manifest for version 2.4.0 in https://github.com/hyperoslo/Gallery

On package file:

    dependencies: [
        // Dependencies declare other packages that this package depends on.
        .package(url: "https://github.com/hyperoslo/Gallery", from: "2.4.0")
    ],
    targets: [...]

error:

https://github.com/hyperoslo/Gallery has no Package.swift manifest 
for version 2.4.0 in https://github.com/hyperoslo/Gallery