date.split('/') is undefined.

TypeError: date.split is not a function

This error is located at:
    in ScoresScreen (created by Connect(ScoresScreen))
    in Connect(ScoresScreen) (at SceneView.js:17)
    in SceneView (at CardStack.js:385)
    in RCTView (at View.js:71)
    in View (at createAnimatedComponent.js:147)
    in AnimatedComponent (at Card.js:12)
    in Card (at PointerEventsContainer.js:39)
    in Container (at CardStack.js:414)
    in RCTView (at View.js:71)
    in View (at CardStack.js:348)
    in RCTView (at View.js:71)
    in View (at CardStack.js:347)
    in CardStack (at CardStackTransitioner.js:66)
    in RCTView (at View.js:71)
    in View (at Transitioner.js:142)
    in Transitioner (at CardStackTransitioner.js:19)
    in CardStackTransitioner (at StackNavigator.js:38)
    in Unknown (at createNavigator.js:13)
    in Navigator (at createNavigationContainer.js:214)
    in NavigationContainer (at SceneView.js:17)
    in SceneView (at TabView.js:30)
    in RCTView (at View.js:71)
    in View (at TabView.js:29)
    in RCTView (at View.js:71)
    in View (at TabViewPagerPan.js:251)
    in RCTView (at View.js:71)
    in View (at createAnimatedComponent.js:147)
    in AnimatedComponent (at TabViewPagerPan.js:238)
    in TabViewPagerPan (at TabView.js:117)
    in RCTView (at View.js:71)
    in View (at TabViewAnimated.js:194)
    in TabViewAnimated (at TabView.js:178)
    in TabView (at withCachedChildNavigation.js:44)
    in withCachedChildNavigation(TabView) (at TabNavigator.js:32)
    in Unknown (at createNavigator.js:13)
    in Navigator (at createNavigationContainer.js:214)
    in NavigationContainer (at App.js:29)
    in Provider (at App.js:28)
    in App (at renderApplication.js:35)
    in RCTView (at View.js:71)
    in View (at AppContainer.js:102)
    in RCTView (at View.js:71)
    in View (at AppContainer.js:122)
    in AppContainer (at renderApplication.js:34)
handleException @ ExceptionsManager.js:65
handleError @ InitializeCore.js:115
reportFatalError @ error-guard.js:44
__guardSafe @ MessageQueue.js:318
callFunctionReturnFlushedQueue @ MessageQueue.js:117
(anonymous) @ debuggerWorker.js:72

In other apps when you tap on a tab button it will perform a function (ex: Instagram: search for a user, click their profile, click search tab button takes you back to the initial search screen).

When you click the tab button while in a nested scene for that tab, you should go back to the root scene (ex: Scores screen -> game -> boxscore -> * tap scores tab button * -> back to Scores screen).

Something along the lines of the following would go in navigationOptions({...}) of the tab navigator:

source: https://reactnavigation.org/docs/tab-navigator.html#tabbaronpress

The player's screen currently only shows game stats for the current season. A great enhancement to this screen would be the option to show a player's career stats.

Right now in the player page, a list of their games is displayed along with points, rebounds, and assists for the game. Clicking on a game from the player page should go to a new page that displays more stats from that game.

Bundling index.ios.js Transforming modules ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓░ 99.0% (391/393)...(node:11817) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 668): UnableToResolveError: Unable to resolve module ./App/Assets/Images/back_button_white.png from /Users/open/NodeProjects/react-projects/NBAreact/App/NBAreact.js: Directory /Users/open/NodeProjects/react-projects/NBAreact/App/App/Assets/Images/back_button_white.png doesn't exist

When the date is set to a date for a past season, the following happen:

• Indivdual player page doesn't load
• Player image does not render for the player cell

Why? There is no player_id returned from the endpoints.

When a user clicks on the team logo from GameStatsTeam page, they will be taken to that team's own page. Possible ideas on what to include are season record, stat rankings, roster, player stats; will look into.

When one of the game cells are pressed on the scores page, provide more details. Ideas: points scored by quarter, team stats, maybe player stats. We'll see what direction this idea takes.

when scrolling to the right you lose context of which player the stats are representing. might be nice to prevent diagonal scrolling as well as it makes it feel unpolished.

Currently when looking at the TeamScreen only the Roster is shown. It would be nice to see the list of games played by the team and their outcome. Clicking on the game would take you to the DetailedGameScreen

As much as I loved having the team logos and player images in Swish, they had to be removed for release on the App Store. There is a branch (swish_with_images) that contains Swish before the images were taken out.

As the development of Swish continues, I will try to update that branch as well with features that make it to master so the full app could still live on.

In the future if I can acquire rights to use the actual team logos or some custom made alternative version, then I will add them back in.

Title says it all. Ex:

• Move similar styles into a common/styles.js file
• Break up large components into smaller ones
• Create stateless components when appropriate
• Bind functions with functionName = () => {}
• Remove props in class extends Component<Props>

Currently the ScoresScreen is populated with data from data.nba.net. There is another endpoint from stats.nba.com that provides game info as well, sometimes with more information. This ticket is a place to gather info for if I want to change the source or even extend to include data from both sources.

Example endpoints:

|Source|URL| Notable Data | |-------|----|--------------| | data.nba.net | https://data.nba.net/prod/v2/20180507/scoreboard.json | - Faster data updates (not verified, based on observation)
- All data for a game is contained in one object
- Playoff matchup information | | stats.nba.com | http://stats.nba.com/stats/scoreboardV2/?gamedate=2018-05-07&leagueid=00&dayoffset=0 | - TeamLeaders for game
- Playoff matchup information
- Last Meeting
- Win Probability (empty)

Related to #62

Steps:

• standings tab -> select team -> team games -> select a game [1] -> scores tab -> select new game [2] -> standings tab
• should be back at the game selected as [1]
• game [1] team colors are now the team colors from game [2]

Screenshots: [1] [2] [1]