I integrated using Pod, but couldn't able to access LoadingShimmer class due to default internal access of class.

I made public access to that class by putting public keyword.

public class LoadingShimmer: NSObject {
    public static let shared = LoadingShimmer()

    public class func startCovering(_ view: UIView?) {
        shared.coverSubviews(view)
    }

    public class func stopCovering(_ view: UIView?) {
        shared.removeSubviews(view)
    }

}

Would you please do the same changes in repo.

Thanks.

let coverableCellsIds = ["Cell1", "Cell1", "Cell1", "Cell1", "Cell1"] if type(of: view!) === UITableView.self { for i in 0..<coverableCellsIds.count { getTableViewPath(view, index: i, coverableCellsIds: coverableCellsIds) } addCover(view) return }

This PR addresses Issue #27

Changes: _viewCover?.backgroundColor is now default clear.

It then gets assigned to the target view to cover background color viewCover?.backgroundColor = view?.backgroundColor

The way the animation is taking place (colors with low alpha), we need to give the colorLayer a background color as to not expose the element that is being 'loaded'. Attempt to match the targetViews background color as well, otherwise fall back to white

Screenshot of the change:

@jogendra I did not want to over extend my boundaries so will leave podspec update / example project update to integrate this change in your hands.

Cheers

Actual Behaviour Using Loading Shimmer changes a view's background color (always white background).

Expected Behaviour Using Loading Shimmer honors the target view's background color, via using it as the backdrop while blurring its contained elements.

Steps to reproduce it

1. Have a view with a background color.
2. Cover that view with a loading shimmer via LoadingShimmer.startCovering(view)
3. Hide the loading shimmer via LoadingShimmer.stopCovering(view)

Observe that the original background color is not honored.

Actual Behaviour

I try to open example project but it shows me errors "Multiple commands produce...". I use Xcode 10.1

Expected Behaviour

The example app should open

Steps to reproduce it Follow the guideline README in the project. Screenshots of the issue

Would you like to work on the issue? yes

Actual Behaviour

Currently, no any hook for checking PR quality and testing.

Expected Behaviour

Integrate Circle-CI

Steps to reproduce it

Screenshots of the issue

N/A

Would you like to work on the issue?

Yes

imjog/AnimatedMaskLabel now has a Chat Room on Gitter

@imjog has just created a chat room. You can visit it here: https://gitter.im/AnimatedMaskLabel/Lobby.

This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.

Happy chatting.

PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Actual Behaviour No animation displayed after calling LoadingShimmer.startCovering(view, with: nil)

Expected Behaviour Animation displayed

Steps to reproduce it override func viewDidLoad() { super.viewDidLoad()

    let animationView = UIView()
    view.addSubviews(animationView)
    
    animationView.snp.makeConstraints {
        $0.edges.equalToSuperview()
    }
    
    LoadingShimmer.startCovering(animationView, with: nil)
}

LogCat for the issue

No crash there

Clear view. Changing backgroundColor of the view has no affect

Would you like to work on the issue?

Maybe

Actual Behaviour

There is no shimmer

Expected Behaviour

Shimmer should occur

Steps to reproduce it

1. Create a view controller in storyboard
2. Create views and outlets to the views.
3. Set the background of the view to a different color and the created subviews to a different color.
4. Connect the outlets.

Would you like to work on the issue? No thank you.

import UIKit
import LoadingShimmer

class BugTest2ViewController: UIViewController {

    @IBOutlet var blackview: UIView!
    @IBOutlet var greenview: UIView!
    override func viewDidLoad() {
        super.viewDidLoad()
        LoadingShimmer.startCovering(blackview)
        LoadingShimmer.startCovering(greenview)
        // Do any additional setup after loading the view.
    }
}

Actual Behaviour

Currently, it is supporting normal views and UITableView.

Expected Behaviour

Add support for UICollectionView

Screenshots of the issue

N/A

Would you like to work on the issue?

Anyone can take the issue. Feel free to open the PR.