Hi,

thank you very much for this. A good code editor is urgently needed for SwiftUI! This really fills a void. Would be so cool not to have to use Ace in a WebView anymore.

Some questions:

1. Will it be possible to have sessions, i.e. when you have several source files to switch between source sessions which restores the cursor / scroll location for that session (and the messages if possible) ?
2. Will it be possible to to provide custom syntax highlighting for custom languages from the outside ? I have my own scripting language.

IMHO focus on making the core usable for a v1 and add all the options / features later ...

Thanks

Is there an easy way of adding new language support? I am really interested in using this library to support another language. Right now, it looks like the only way to do so is to change the LanguageConfiguration file. If that is true, it would be nice to be able to create an external file for my own language support that gets added to the existing language support. That way, anybody can create and submit language configurations to the project.

Using the exact sample code as shown in the readme:

struct ContentView: View {
  @State private var text:     String                = "My awesome code..."
  @State private var messages: Set<Located<Message>> = Set ()

  @Environment(\.colorScheme) private var colorScheme: ColorScheme

  var body: some View {
    CodeEditor(text: $text, messages: $messages, language: .swift)
      .environment(\.codeEditorTheme,
                   colorScheme == .dark ? Theme.defaultDark : Theme.defaultLight)
  }
}

Pressing the backspace key to delete one character causes an immediate crash. Inputting more text is not affected, crash seems to only occur when deleting any character.

Here's a screen recording of the crash (window does not close since Xcode is attached to the app). Xcode printed out the stack trace (which is included below) immediately after I backspaced the 'd' character.

Here's the stack trace of the crash:

022-02-04 13:59:11.334073+0800 CPEdit[90289:4724934] [General] An uncaught exception was raised
2022-02-04 13:59:11.334204+0800 CPEdit[90289:4724934] [General] -[__NSCFString getLineStart:end:contentsEnd:forRange:]: Range {60, 0} out of bounds; string length 59
2022-02-04 13:59:11.339149+0800 CPEdit[90289:4724934] [General] (
	0   CoreFoundation                      0x00000001bccd01cc __exceptionPreprocess + 240
	1   libobjc.A.dylib                     0x00000001bca217b8 objc_exception_throw + 60
	2   CoreFoundation                      0x00000001bcda0488 -[__NSCFString characterAtIndex:].cold.1 + 0
	3   CoreFoundation                      0x00000001bccb4750 CFStringGetLineBounds + 0
	4   Foundation                          0x00000001bdcef0cc -[NSString lineRangeForRange:] + 64
	5   CPEdit                              0x0000000100f329d8 $s14CodeEditorView0aC0C17setSelectedRanges_8affinity14stillSelectingySaySo7NSValueCG_So19NSSelectionAffinityVSbtFSo8_NSRangeVSgSiXEfU_ + 392
	6   CPEdit                              0x0000000100f32a54 $sSiSo8_NSRangeVSgs5Error_pIgydzo_SiACsAD_pIegnrzo_TR + 32
	7   CPEdit                              0x0000000100f3da80 $sSiSo8_NSRangeVSgs5Error_pIgydzo_SiACsAD_pIegnrzo_TRTA + 28
	8   libswiftCore.dylib                  0x00000001c9c02c44 $sSq7flatMapyqd__SgABxKXEKlF + 448
	9   CPEdit                              0x0000000100f32210 $s14CodeEditorView0aC0C17setSelectedRanges_8affinity14stillSelectingySaySo7NSValueCG_So19NSSelectionAffinityVSbtF + 1016
	10  CPEdit                              0x0000000100f33aa0 $s14CodeEditorView0aC0C17setSelectedRanges_8affinity14stillSelectingySaySo7NSValueCG_So19NSSelectionAffinityVSbtFTo + 108
	11  UIFoundation                        0x00000001c063ba6c -[NSLayoutManager textStorage:edited:range:changeInLength:invalidatedRange:] + 372
	12  CPEdit                              0x0000000100f3c510 $s14CodeEditorView0A13LayoutManagerC14processEditing3for6edited5range14changeInLength16invalidatedRangeySo13NSTextStorageC_So0pQ11EditActionsVSo8_NSRangeVSiAOtF + 544
	13  CPEdit                              0x0000000100f3cad4 $s14CodeEditorView0A13LayoutManagerC14processEditing3for6edited5range14changeInLength16invalidatedRangeySo13NSTextStorageC_So0pQ11EditActionsVSo8_NSRangeVSiAOtFTo + 140
	14  UIFoundation                        0x00000001c0662934 -[NSTextStorage _notifyEdited:range:changeInLength:invalidatedRange:] + 188
	15  UIFoundation                        0x00000001c066e3b4 -[NSTextStorage endEditing] + 116
	16  CPEdit                              0x0000000100f18374 $s14CodeEditorView0A7StorageC17replaceCharacters2in4withySo8_NSRangeV_SStF + 3220
	17  CPEdit                              0x0000000100f18ec4 $s14CodeEditorView0A7StorageC17replaceCharacters2in4withySo8_NSRangeV_SStFTo + 100
	18  AppKit                              0x00000001bfb19fbc -[NSTextView(NSPrivate) _userReplaceRange:withString:] + 260
	19  AppKit                              0x00000001bfb19a40 _NSDoUserReplaceForCharRange + 480
	20  AppKit                              0x00000001bfb6511c -[NSTextView(NSKeyBindingCommands) deleteBackward:] + 824
	21  AppKit                              0x00000001bfa86e60 -[NSTextView doCommandBySelector:] + 216
	22  AppKit                              0x00000001bfa86d48 -[NSTextInputContext(NSInputContext_WithCompletion) doCommandBySelector:completionHandler:] + 264
	23  AppKit                              0x00000001bf9b0f6c -[NSKeyBindingManager(NSKeyBindingManager_MultiClients) interpretEventAsCommand:forClient:] + 2008
	24  AppKit                              0x00000001bf9b9c9c __84-[NSTextInputContext _handleEvent:options:allowingSyntheticEvent:completionHandler:]_block_invoke_5 + 376
	25  AppKit                              0x00000001c01845d8 __84-[NSTextInputContext _handleEvent:options:allowingSyntheticEvent:completionHandler:]_block_invoke_3.1027 + 108
	26  AppKit                              0x00000001bf9b9ae0 -[NSTextInputContext tryHandleEvent_HasMarkedText_withDispatchCondition:dispatchWork:continuation:] + 148
	27  AppKit                              0x00000001c0184530 __84-[NSTextInputContext _handleEvent:options:allowingSyntheticEvent:completionHandler:]_block_invoke.1024 + 324
	28  HIToolbox                           0x00000001c58207dc __TSMProcessRawKeyEventWithOptionsAndCompletionHandler_block_invoke_5 + 96
	29  HIToolbox                           0x00000001c5831c3c ___ZL23DispatchEventToHandlersP14EventTargetRecP14OpaqueEventRefP14HandlerCallRec_block_invoke + 148
	30  AppKit                              0x00000001c017f11c __55-[NSTextInputContext handleTSMEvent:completionHandler:]_block_invoke.341 + 592
	31  AppKit                              0x00000001bf9b2fb0 __55-[NSTextInputContext handleTSMEvent:completionHandler:]_block_invoke_2 + 108
	32  AppKit                              0x00000001bf9b2ef4 -[NSTextInputContext tryHandleTSMEvent_HasMarkedText_withDispatchCondition:dispatchWork:continuation:] + 148
	33  AppKit                              0x00000001bf9b23a0 -[NSTextInputContext handleTSMEvent:completionHandler:] + 2004
	34  AppKit                              0x00000001bf9b1b50 _NSTSMEventHandler + 340
	35  HIToolbox                           0x00000001c57bf418 _ZL23DispatchEventToHandlersP14EventTargetRecP14OpaqueEventRefP14HandlerCallRec + 1116
	36  HIToolbox                           0x00000001c57be884 _ZL30SendEventToEventTargetInternalP14OpaqueEventRefP20OpaqueEventTargetRefP14HandlerCallRec + 356
	37  HIToolbox                           0x00000001c57be714 SendEventToEventTargetWithOptions + 44
	38  HIToolbox                           0x00000001c581cd54 SendTSMEvent_WithCompletionHandler + 432
	39  HIToolbox                           0x00000001c581d298 __SendUnicodeTextAEToUnicodeDoc_WithCompletionHandler_block_invoke + 440
	40  HIToolbox                           0x00000001c581d0b4 __SendFilterTextEvent_WithCompletionHandler_block_invoke + 224
	41  HIToolbox                           0x00000001c581cdac SendTSMEvent_WithCompletionHandler + 520
	42  HIToolbox                           0x00000001c581cb5c SendFilterTextEvent_WithCompletionHandler + 256
	43  HIToolbox                           0x00000001c581c788 SendUnicodeTextAEToUnicodeDoc_WithCompletionHandler + 292
	44  HIToolbox                           0x00000001c581c524 __utDeliverTSMEvent_WithCompletionHandler_block_invoke_2 + 320
	45  HIToolbox                           0x00000001c581c2a8 __utDeliverTSMEvent_WithCompletionHandler_block_invoke + 284
	46  HIToolbox                           0x00000001c581c10c TSMKeyEvent_WithCompletionHandler + 600
	47  HIToolbox                           0x00000001c581be94 __TSMProcessRawKeyEventWithOptionsAndCompletionHandler_block_invoke_4 + 320
	48  HIToolbox                           0x00000001c581bca4 __TSMProcessRawKeyEventWithOptionsAndCompletionHandler_block_invoke_3 + 352
	49  HIToolbox                           0x00000001c581b9a0 __TSMProcessRawKeyEventWithOptionsAndCompletionHandler_block_invoke_2 + 352
	50  HIToolbox                           0x00000001c581b69c __TSMProcessRawKeyEventWithOptionsAndCompletionHandler_block_invoke + 344
	51  HIToolbox                           0x00000001c5809b84 TSMProcessRawKeyEventWithOptionsAndCompletionHandler + 3372
	52  AppKit                              0x00000001c01843dc __84-[NSTextInputContext _handleEvent:options:allowingSyntheticEvent:completionHandler:]_block_invoke_3.1020 + 148
	53  AppKit                              0x00000001c018408c __204-[NSTextInputContext tryTSMProcessRawKeyEvent_orSubstitution:dispatchCondition:setupForDispatch:furtherCondition:doubleSpaceSubstitutionCondition:doubleSpaceSubstitutionWork:dispatchTSMWork:continuation:]_block_invoke.971 + 192
	54  AppKit                              0x00000001bf9b0620 -[NSTextInputContext tryTSMProcessRawKeyEvent_orSubstitution:dispatchCondition:setupForDispatch:furtherCondition:doubleSpaceSubstitutionCondition:doubleSpaceSubstitutionWork:dispatchTSMWork:continuation:] + 344
	55  AppKit                              0x00000001bf9aff20 -[NSTextInputContext _handleEvent:options:allowingSyntheticEvent:completionHandler:] + 1528
	56  AppKit                              0x00000001bf9af8e8 -[NSTextInputContext _handleEvent:allowingSyntheticEvent:] + 136
	57  AppKit                              0x00000001bf9af708 -[NSView interpretKeyEvents:] + 196
	58  AppKit                              0x00000001bf9af518 -[NSTextView keyDown:] + 712
	59  AppKit                              0x00000001bf916d98 -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] + 5920
	60  AppKit                              0x00000001bf91540c -[NSWindow(NSEventRouting) sendEvent:] + 348
	61  AppKit                              0x00000001bf914878 -[NSApplication(NSEvent) sendEvent:] + 4064
	62  AppKit                              0x00000001bfbcd010 -[NSApplication _handleEvent:] + 76
	63  AppKit                              0x00000001bf7959dc -[NSApplication run] + 636
	64  AppKit                              0x00000001bf767088 NSApplicationMain + 1064
	65  SwiftUI                             0x00000001e16b14c4 $s7SwiftUI6runAppys5NeverOSo21NSApplicationDelegate_So11NSResponderCXcFTf4e_nAA07TestingdG0C_Tg5 + 148
	66  SwiftUI                             0x00000001e21dba40 $s7SwiftUI6runAppys5NeverOxAA0D0RzlF + 260
	67  SwiftUI                             0x00000001e1c6b658 $s7SwiftUI3AppPAAE4mainyyFZ + 128
	68  CPEdit                              0x0000000100f0f6c0 $s6CPEdit0A3AppV5$mainyyFZ + 40
	69  CPEdit                              0x0000000100f0f778 main + 12
	70  dyld                                0x00000001014590f4 start + 520
)

If relevant, I'm including some information about my machine and environment:

• Model: 2021 14" MBP
• macOS version: 12.2 RC
• Xcode version: 13.2.1
• Swift version: 5
• App was running in debug mode and Xcode was attached to it
• CodeEditorView version 0.9.0 was installed thru SPM

They get scoped and slightly more expressive names. (The names are still partially abbreviated; otherwise, the regular expressions just get too big, negatively affecting readability.)

I've changed the accessor used to get the editor theme to EnvironmentValues.codeEditorTheme, which vends the same value. This avoids the warnings for not using CodeEditorTheme.self when accessing with the EnvironmentKey subscript on EnvironmentValues

If I want to change the default font size, what is the best way to do that? I tried to create a new theme with a different font size to pass into the CodeEditor call, but I get

'Theme' initializer is inaccessible due to 'internal' protection level

I don't see any other obvious way to make that change.

Thanks

Just moving the cursor one character seems to invalidate the entire visible gutter.

There is also an interaction with gutter invalidation and change management or similar that can lead to an endless loop (or at least, extreme slowness) during start up if there is a window with a large file open. Gutter invalidation happens async on the main thread, but on a large file that may run too early after all. In any case, it is fragile.

I'm seeing a crash when emptying all text, when accessing message[0].

Worked around here:

https://github.com/mchakravarty/CodeEditorView/compare/main...ronyfadel:CodeEditorView:main

In CodeEdit, our goal is to reach editor feature parity with Xcode. We'd like to use CodeEditorView as opposed to rolling our own editor view. That considered the question arises, what is the responsibility of the editor and what is the responsibility of the application built around it?

I am thinking the Code Review might be the responsibility of the editor as it is the editor that draws the new lines, line highlights etc. What are your thoughts here? If it is not the responsibility of the editor, without looking into it too much, is CodeEditor extensible enough to build this on top of it outside the editor?

We seem to generally be following the editor visual style of Xcode. There are a few things that need to be addressed to get be more visually consistent. (left - Xcode, right - CodeEditorView)

• Better syntax highlighting
• Increased line height
• Smaller and more narrow line number font.
• General editor font styling is off (maybe smaller font size by 1px and increased font weight?).

• General message styling (typography, iconography, colors, animation, dismiss popover button, etc) needs work

Currently the redrawing of the gutter view lacks behind resizing operations because it needs to wait until the layout manager has finished laying out the text. This can be clearly observed when switching between fullscreen and windowed mode.

It should be possible to avoid this by using a CALayer appropriately. By continuing to use the last layer (in GutterView) until the recomputed layout allows us to draw a new layer, the gutter view ought to be able to handle animations, such as going into fullscreen, more elegantly.