When I tried to use CodeEditTetView on macOS, and only used to parse JSON, I found that it depends on many parsing libraries in other languages, is there a way to remove other libraries according to personal needs?

Because I only need methods related to json parsing.

Thanks!

Description

This PR adds incremental highlighting to the text editor. When an edit occurs, it applies the edit in tree-sitter and calculates what other indices may need re-highlighting. This lets us take full advantage of tree-sitter and make our editor much more efficient for large code files.

Todo

• [x] Apply Edits to tree-sitter
• [x] Calculate changed ranges due to an edit
• [x] Invalidate ranges & queue highlights after an edit
• [x] Query tree-sitter for highlights for a range
• [x] Restrict all highlights to visible text
• [x] Highlight newly visible text on scroll
• [x] ~Fix memory bug~

Related Issues

#27 🚀 Performance: Incremental Highlighting #45 #55 #21

Checklist

• [x] I read and understood the contributing guide as well as the code of conduct
• [x] My changes generate no new warnings
• [x] My code builds and runs on my machine
• [x] I documented my code
• [x] Review requested

Description

When using a custom font, the editor appears to only apply that font to select areas when the file has syntax highlighting.

To Reproduce

1. Open CodeEdit Settings > Text Editing.
2. Change the font to anything other than the default.
3. Open a file in CodeEdit.
4. Notice the inconsistent font application.

Expected behavior

The same font should be used throughout the entire editor view, regardless of syntax highlighting.

Version information

CodeEdit: 1.0 Hash: (Commit) 095abfec2475ca053bb7783572e4ae9a38d514ea MacOS: 13.0 beta 4 (22A5311f) Xcode: 14.0 beta 4 (14A5284g)

Additional context

This is an example screenshot demoing the behavior. I've set my font to Fira Code Retina (size 13). Notice that, here, the identifier "Foundation" uses the correct font, as well as the line gutter, whereas everything else doesn't.

Description

Adds the default text color to the default attributes applied to text in the editor. Fixes an issue where the base text color wouldn't change when changing themes.

Issues

• #713 in CodeEdit

Checklist

• [x] I read and understood the contributing guide as well as the code of conduct
• [x] My changes generate no new warnings
• [x] My code builds and runs on my machine
• [x] I documented my code
• [x] Review requested

https://user-images.githubusercontent.com/88234730/177717085-9b40d21b-b6b4-4365-a423-a3c3437905b3.mov

When typing in a file (doesn't matter what the file extension is, so long as CodeEdit can syntax highlight it), the text changes from bold to non-bold, and/or the font size changes.

This fixes an issue where the text Binding wouldn't update. CodeEditTextView would receive updates to input just fine, but the client wouldn't get any updates about the changes in the string.

A bug was fixed at this commit: https://github.com/krzyzanowskim/STTextView/commit/6a3ed085c26ba06fcd365c5056b31755cbddfa87 A release tag need to be created for STTextView, so it's a logic change to target the version of SPM to from:

In order to cut down the time of our CI with Github Actions, dependencies are now cached using actions/cache.

This action plugin checks Package.resolved and when there are no changes, it downloads the cached build folder instead of fetching each dependency one-by-one.

This saves about ~5-7 minutes per test run. Once there are changes in Package.resolved, of course, it will result in a longer test run.

Hello!

The maintainer of the Swift tree-sitter parser has just merged in SPM support. I'd like to remove my personal branch, but wanted to let you know first before I do that. Unlike some other parsers, the branch with-generated-files is still required.

https://github.com/alex-pinkus/tree-sitter-swift/tree/with-generated-files

Description

Pasted text is black despite using dark mode.

To Reproduce

1. open new CodeEdit window
2. paste some text

Expected behavior

Text should be white on dark background but is black.

Version information

CodeEdit: 1.0 (1) macOS: 13.1

Additional context

Current Situation

Currently all tree-sitter parsers are fetched from source every time Swift Package Manager resolves dependencies. This can easily take a couple of minutes even with a good internet connection. This also applies to the CodeEdit repo.

Proposal

Since Languages usually don't need to be updated very often, they could be bundled as pre-built *.xcframework binaries in an extra repository. This would also include the CodeLanguage class. By doing so the fetching occurs only from a single Swift Package which in turn hugely benefits package resolution.

Further Information

Once there are additional languages or updates to existing ones, it's as simple as running a script to re-build the frameworks.

I know this sounds like a lot of overhead but I think in the long term this will pay off since waiting for packages to fetch/resolve on a daily basis definitely adds up.

I'm curious what you guys think about this!

Background

This addresses bug #84 , and fulfills some of the requirements of #66 (the rest of which will be implemented in CodeEdit in a nascent PR).

Technical Details

Two things to note:

1. This will likely regress highlighting behavior- more detailed discussion available on this discord channel, but TLDR: @thecoolwinter has plans to obviate the need for the removed NSLayoutManager code when he migrates that work to TextKit 2.

2. I went ahead and removed the invocation of STTextView's static scrollableTextView() helper function. It sets a number of properties which are immediately overwritten by our code in loadView(). It only obfuscates what's really happening here.

Is your feature request related to a problem? Please describe.

In the enhancement requested by https://github.com/CodeEditApp/CodeEdit/issues/868, the request to add configurable indentation to wrapped lines is beyond the current capabilities of CodeEditTextView.

Describe the solution you'd like

Add a parameter or option which allows custom indentation to be added for wrapped lines. May require enhancement + PR in STTextView

Additional Context

Example behavior in Xcode:

4 spaces

12 spaces

Description

Cursor remains an arrow when hovering over editor.

To Reproduce

Hover over the editor.

Expected behavior

When hovering over editor, cursor should change to an I-beam to indicate editable text.

Description

Pasted text will just appear black and small instead of formatted.

https://user-images.githubusercontent.com/93644977/199779964-5bd6e52f-b683-41e2-8cc1-21fbf8f27aa6.mov

To Reproduce

1. Open a file inside of a project
2. Copy some unformatted text from another program
3. Paste it

Expected behavior

Should just be formatted like any other text.

Version information

CodeEdit: 1.0 (1) macOS: 13.0 Beta (22A5311f) Xcode: 14.1 (14B47b)

Additional context

No response

Description

When changing the width of the view the text won't unwrap or wrap lines as the width changes. However, if you scroll away from the text and scroll back to it, it is laid out correctly.

This might just require forcing a layout when the view's width changes.

To reproduce

• Open a file with a long line of text
• Change the width of the screen so that the long line should either wrap more or unwrap
• Scroll away so the text is no longer visible
• Scroll back up to the original line (it should now be wrapped correctly according to the new width)

Expected Behavior

The lines should update as the view width changes, instead of needing a scroll to re-layout.

Additional Context

https://user-images.githubusercontent.com/35942988/198495074-e7c43f4d-48c3-4e21-8297-cf8ee66de283.mov

Relate Issues

• CodeEditApp/CodeEdit#868

This issue should be worked on with the above issue.