I want to use this in artsy/eidolon but I want to keep it as swifty as possible.

So I've added another flag to add support for outputting as swift and updated the README. You had a lot of training whitespace, so my editor cleaned those up as I was digging around in the source.

When I tried to just run it from master I couldn't get the templates to run, so I made the head / body instance vars because I couldn't figure out how the data gets passed through. Good old ruby.

Looks like this:

// Auto generated file from SBConstants - any changes may be lost

enum SegueIdentifier : String {
    case bid = "bid"
}

enum ViewControllerStoryboardIdentifier : String {
    case EnterYourBidDetails = "Enter Your Bid Details"
    case FulfillmentContainerViewController = "FulfillmentContainerViewController"
    case GetYourBidderDetails = "Get Your Bidder Details"
    case PlaceYourBid = "Place Your Bid"
    case SwipeCreditCard = "Swipe Credit Card"
}

random side-note, I also spent 2 years in the 3 years ago :)

I'm not sure if this will cause any issue. I don't think it should be behind a feature switch as it seems like something that should just be default behaviour.

@tp does this resolve your issue?

I don't fully understand the template format yet, so I don't know if this only requires a template update.

Could we include constants for the storyboard name? As used in + (UIStoryboard *)storyboardWithName:(NSString *)name bundle:(NSBundle *)storyboardBundleOrNil

I have tried everything to make this part of my build phases with no luck. If I run this outside Xcode it works as expected; but running it like this will fail:

sbconstants destinationFile.h

This will fail with: sbconstants command not found.

If I run it like this:

`which sbconstants` destinationFile.h

The build phase won't fail but no data will be generated to destinationFile.h.

After reading your blog post you say it needs to be installed as "System Ruby" but since I have rvm in theory I don't have access to "System Ruby"; but running it with which should actually generate something (unless I'm missing something).

I tried different options with no luck; even adding -v won't produce any output to the build phase.

Hi, is it possible to have custom formatting for the different nodes as well? Something like this for eg:

pragma mark - segue.identifier

NSString * const PSBMasterToDetail = @"PSBMasterToDetail-Segue"; NSString * const PSBMasterToSettings = @"PSBMasterToSettings-Segue";

pragma mark - storyboardNames

NSString * const Main = @"Main-Name";

pragma mark - tableViewCell.reuseIdentifier

NSString * const PSBAwesomeCell = @"PSBAwesomeCell-ReuseIdentifier";

also, thanks for the awesome project!

Hi, I would like to suggest a change from enums to structs

That way the resulting .swift file will be something like this, and will allow us to use them without calling .rawValue on each of them

public struct SegueIdentifiers {
        static let AttachmentsScreen = "AttachmentsScreenSegue"
        static let TagsScreen = "TagsScreenSegue"
        static let TeamsScreen = "TeamsScreenSegue"
}

.../Source/Storyboard/StoryboardIdentifiers.m:3:9: In file included from error: unknown type name 'NSString' extern NSString * const SomeCell;

There is no Foundation import for generated objc file. If I add id manual it works

File Content

// Auto generated file - any changes will be lost


#pragma mark - tableViewCell.reuseIdentifier
extern NSString * const SomeCell;

I am using some helper methods and swift extensions to work with the enums provided by SBConstants. However, if e.g. there is no segue identifier setup in the storyboard, the generated SBConstants file omits the enum altogether.

This of course breaks any custom code that directly references the enums, e.g. SegueIdentifier.

I think it would be fine to output the empty enum in case there are no constants defined. Any opinions?

The default template is always used for objc_body.

See: https://github.com/paulsamuels/SBConstants/commit/0edae9903462c840783dea2bf03553f7ff818030#diff-a7b70ae59847e3f939f89777f94834c8R36

This has been a pretty valuable tool for us; now not having to depend on manual addition of constants. However the generated code didn't match our coding standards and with Objective-Clean build phase in place we had to manually fix the code after generating it.

I forked the gem and added an option that removes this space if the option is present; if not it will generate the code like you have it (keeping default behavior to avoid issues with people already using the gem).

New option is -r and will produce constants like this:

extern NSString *const HSGuidedFlow; // On the .h

NSString *const HSGuidedFlow = @"HSGuidedFlow"; // On the .m

Everything else is kept the same; the only change is now the ability to specify wether or not to have a space after the *. Don't know if this is valuable for anyone else but I figure if I was going to fork and add it I might as well make it available for you to judge if its worth merging.

Generated constant file doesn't contain raw String Value identifiers.

example:

public enum TableViewCellReuseIdentifier : String {
    case MessageCell
}

The code below is based on Reusable and uses the StoryboardNames generated to init VCs

extension UIStoryboard {

    /// Convenience Initializers
    convenience init(storyboard: StoryboardNames, bundle: Bundle? = nil) {

        self.init(name: storyboard.rawValue, bundle: bundle)
    }

    /// Class Functions
    public static func storyboard(storyboard: StoryboardNames = .Main, bundle: Bundle? = nil) -> UIStoryboard {

        return UIStoryboard(name: storyboard.rawValue, bundle: bundle)
    }

    /// View Controller Instantiation from Generics
    func instantiateViewController<T: ViewControllerInitializer>(_: T.Type) -> T {

        guard let viewController = self.instantiateViewController(withIdentifier: T.storyboardIdentifier) as? T else {
            fatalError("Couldn't instantiate view controller with identifier \(T.storyboardIdentifier) ")
        }

        return viewController
    }
}

Usage: let vc = UIStoryboard(storyboard: .Main)

extension UIViewController {
    
    public static func instantiateFromStoryboard(name storyboard: StoryboardNames = .Main) -> Self {
        
        func instantiateFromStoryboard<T: UIViewController>(_: T.Type) -> T {
            
            let sb = UIStoryboard(storyboard: storyboard)
            return sb.instantiateViewController(withIdentifier: String(describing: T.self)) as! T
        }
        
        return instantiateFromStoryboard(self)
    }
}

Usage: let vc = SearchViewController.instantiateFromStoryboard(name: .Main)

I'm new to ruby or I'd make the PR myself, leaving the idea here if anyone does want to implement it.

This PR fixes the issue raised in #52.

This is useful when the storyboard file name on disk has spaces or other characters that are stripped by the string sanitiser.

Before the changes introduced in this PR:

public enum StoryboardNames: String {
    case ConstantsProperties
    case DebugLog // filename is actually "Debug Log.storyboard"
    case DocumentProperties   
}

After the changes introduced in this PR:

public enum StoryboardNames: String {
    case ConstantsProperties
    case DebugLog = "Debug Log"
    case DocumentProperties
}

I'm not sure if the existing collectionViewController in identifiers.yml is the version for iOS, but in macOS projects, collection views are stored in collectionViewItem XML nodes in the Storyboard.

I've added support for both collectionViewItems, tableColumn and tableCellView.

This PR adds these items to the identifiers list.

I've noticed that when sbconstants encounters a file with spaces in the name, it tokenises it to strip whitespace, like so:

New Document.storyboard → StoryboardNames.NewDocument

That's great, but it results in an unusable enum entry. It would be great if this were handled automatically, i.e.:

public enum StoryboardNames: String {
    case NewDocument = "New Document"
}

Currently sbconstants creates the enums in the format below public enum SegueIdentifier : String Most of the patterns and styleguides, and even Apple sample code recommend the format as below (no space between name and column) public enum SegueIdentifier: String Considering this is more of a stylistic and opinionated change, would it make sense to update swift_body.erb to match the common conventions? I can create a PR if so.

I know the templates directory parameter solves it for any tweaks users need, but I am guessing there would be a lot who prefer it without the extra space, because the rest of the lines do follow common convention - so this comment