Hey. When using new XCode 10.2 with Swift 5 I was not able to install this library as a dependency, because of the value of swift version inside .swift-version file, which is 3.0. I think it would be nice to have proper version inside this file. Thank you for your work. This library is small and easy to use.

I use it in a cell and the component width is not updated when I update the numberOfPages. The result being that the dots are not centered in the view anymore.

An easy fix is to force the intrinsicContentSize to be updated and call https://developer.apple.com/documentation/uikit/uiview/1622457-invalidateintrinsiccontentsize

はじめまして！

レイアウトが完了してから再度numberOfPagesを変更するような処理をすると、Viewの位置がズレるようです。こちらを修正してみました。いかがでしょうか？

Demoで以下のようなコードを追加すると再現できます。

    override func viewDidAppear(_ animated: Bool) {
        super.viewDidAppear(animated)
        pageControl1.numberOfPages = 10
        pageControl2.numberOfPages = 10
    }

scrollView.frameを変更せず、bounds.sizeを変更することで位置を変えずに大きさだけ変更するようにしました。

ページ数を都度変えるような実装もあるかと思いますので、ご確認よろしくお願いいたします 🙇

Thanks for the library! The initialiser for Config structure is not available. Because it is not defined as public. The solution is to write like this:

    // MARK: public

    public struct Config {

        public var displayCount: Int
        public var dotSize: CGFloat
        public var dotSpace: CGFloat
        public var smallDotSizeRatio: CGFloat
        public var mediumDotSizeRatio: CGFloat
        
        public init(displayCount: Int = 7,
                    dotSize: CGFloat = 6.0,
                    dotSpace: CGFloat = 4.0,
                    smallDotSizeRatio: CGFloat = 0.5,
                    mediumDotSizeRatio: CGFloat = 0.7) {
            self.displayCount = displayCount
            self.dotSize = dotSize
            self.dotSpace = dotSpace
            self.smallDotSizeRatio = smallDotSizeRatio
            self.mediumDotSizeRatio = mediumDotSizeRatio
        }
    }

    // default config

    private var config = Config()

This way you can also specify default values right in the initialiser. So users of the library will be able to override only properties, that they need to override 🙂

Hey there, love it, just added it today. While testing I found an issue, which I thought I might mention here. While swiping before the item has stopped decelerating it seems to jump and confuse the library. Is this something you're reproducing or might it be my problem?

(normal view below)

Thanks!

Hey! Thanks for the awesome lib. Do you have any plans to add views reusing? In my app I can add up to 100 photos in a roll and performance may be low because of 100 views

add swift version to podspec

$ pod lib lint

 -> FlexiblePageControl (1.0.8)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | [iOS] xcodebuild:  note: Planning build
    - NOTE  | [iOS] xcodebuild:  note: Constructing build description

FlexiblePageControl passed validation.

Now, there is no way to change smallDotSizeRatio or mediumDotSizeRatio, because FlexiblePageControl doesn't pass it to underlying ItemView. We also couldn't set it manually, because ItemConfig is private class inside FlexiblePageControl.

So, I fix this problem by creating item config during update and passing it to items. It will work properly in both situation when we set config manually or initialise FlexiblePageControl with config.

There are some logs indicating the size of the dots:

None None None Normal Normal Medium Small Small Small Small

line 270 of the FlexiblePageControl.swift file

print(item.state)

I get the following error when using Storyboard.

fatal error: init(coder:) has not been implemented: file ... /Pods/FlexiblePageControl/FlexiblePageControl/FlexiblePageControl.swift, line 98

So, I fixed the error function as follows.

required public init?(coder aDecoder: NSCoder) {
        //fatalError("init(coder:) has not been implemented")
        super.init(coder: aDecoder)

        setup()
        updateViewSize()
}

This works well on the Storyboard. Could you put this code in it?

Example:

Set numberOfPages to 1, displayCount will be set to 1:

displayCount = min(displayCount, numberOfPages)

Now set numberOfPages to 2, displayCount will remain 1:

displayCount = min(displayCount, numberOfPages)

@shima11 you should probably use a separate private var for all calculations related to the displayCount value.

Hi development team, how can I achieve infinite scroll on FlexiblePageControl? Everything works just fine but I couldn't find the way the make it become infinite scroll, It might be disappear or all the dot become same in size when the index reset. I use FlexiblePageControl along with FSPagerView. Thank for any helping !

hello, thanks for the amazing PageControl first,

I would like to ask,

when numberOfPages greater than displayCount

the default dots only display for 3 dots, others are hidden/clear color

is it possible to set always 5 dots?

it my config below

static let pageControlConfig = FlexiblePageControl.Config( displayCount: 5, dotSize: 6, dotSpace: 4, smallDotSizeRatio: 0.5, mediumDotSizeRatio: 0.7 )

The proposed changes allow FlexiblePageControl to be customizable via UIAppearance, for instance:

let config = FlexiblePageControl.Config(
	displayCount: 5,
	dotSize: 6,
	dotSpace: 4,
	smallDotSizeRatio: 0.5,
	mediumDotSizeRatio: 0.7
)
FlexiblePageControl.appearance().pageIndicatorTintColor = UIColor.systemGray
FlexiblePageControl.appearance().currentPageIndicatorTintColor = UIColor.systemBlue
FlexiblePageControl.appearance().setConfig(config)

• Add @objc dynamic to setConfig(), pageIndicatorTintColor, currentPageIndicatorTintColor, animateDuration
• Make Config class and inherit from NSObject.

When load first time ( Storyboard ) works ok. But when open presenting view controller and close, call it again, to reload content ( number of subviews can change, content is dynamic ), all dots was not centralising anymore, debugging first time and second time, can see this. Try to centralising with .center = CGPoint(params correct here), first time works, second, align all to left. Not working.