Hi! First of all thanks for such control!

There is a bug when trying to zoom a small image with double tap If you try to zoom such image with gesture everything is fine (it just not scale)

Here is an example

I used 1.8.6 , it works fine. But since I updated to the new version （1.8.8）, an error occurred var skPhotos = [SKPhoto]() let photoDatas = self.item.photos do{ for photoData in photoDatas{ let data = try photoData.getData() skPhotos.append(SKPhoto.photoWithImage(UIImage(data: data)!)) } }catch{ } let skPhotoBrowser = SKPhotoBrowser(photos: skPhotos)//Throw that error! Fatal Error: Array cannot be bridged from Objective-C

I had some issues regarding the transitions while opening and closing. I also updated the demo app to reflect the changes.

• Changed content mode to .aspectFill so images don't become squished
• Add support for cornerRadius transition when opening/closing
• Option to bounce transition when opening/closing
• Offset/size fixed when closing from zoomed/panned state

After device rotation if you change between images all are good but current image frame for initial state (after first rotation) is not good, have to be refreshed

SKPhotoBrowserOptions.displayCounterLabel = true SKPhotoBrowserOptions.displayBackAndForwardButton = true

Some options don't work in release 4.1.1 I think you have introduced a bug cause I reverted back to 4.1.0 and they worked fine.

I am not sure why, please give some feedback

Hi, When using multiple actions the default share action is not accessible (the action button is not public so you cannot use it as an anchor for a popup -for presenting a UIDocumentInteractionController) I solved the problem by not using the UIDocumentInteractionController and and changing this function

func actionButtonPressed(ignoreAndShare ignoreAndShare: Bool) {
        delegate?.willShowActionSheet?(currentPageIndex)

        guard numberOfPhotos > 0 else {
            return
        }
//CHANGES STARTS HERE
        if ignoreAndShare {
            let photo = photos[currentPageIndex]
            guard let underlyingImage = photo.underlyingImage else {
                return
            }

            var activityItems: [AnyObject] = [underlyingImage]
            if photo.caption != nil {
                if let shareExtraCaption = SKPhotoBrowserOptions.shareExtraCaption {
                    activityItems.append(photo.caption + shareExtraCaption)
                } else {
                    activityItems.append(photo.caption)
                }
            }
            activityViewController = UIActivityViewController(activityItems: activityItems, applicationActivities: nil)
            activityViewController.completionWithItemsHandler = {
                (activity, success, items, error) in
                self.hideControlsAfterDelay()
                self.activityViewController = nil
            }
            if UI_USER_INTERFACE_IDIOM() == .Phone {
                presentViewController(activityViewController, animated: true, completion: nil)
            } else {
                activityViewController.modalPresentationStyle = .Popover
                let popover: UIPopoverPresentationController! = activityViewController.popoverPresentationController
                popover.barButtonItem = toolbar.toolActionButton
                presentViewController(activityViewController, animated: true, completion: nil)
            }
            return
        }
        //CHANGES ENDs HERE
        if let titles = SKPhotoBrowserOptions.actionButtonTitles {

I call it in

   func didDismissActionSheetWithButtonIndex(buttonIndex: Int, photoIndex: Int) {
      if buttonIndex == indexOfButtonUsedToShare {
            browser.actionButtonPressed(ignoreAndShare: true)}
      }else{
            //action for ther button
      }
}

Do you think this is the right way or it would be better to make the action button visible? (I don't know how to do it with the latest version of the browser)

I start it from a collectionView with 100+ images, someone bigger than 5MB SKPhotoBrowser(originImage: images[indexPath.row].underlyingImage, photos: images, animatedFromView: cell) when select a cellview the browsers shows but when I scroll the images the memory occupation continues to increase until the app crashes for excessive memory usage (500+MB) the memory of the not visible images don't seem to be released and neither the browser itself when closed

using ios 10.3.2

I saw the delete function. But I want to offer a different resolution. If another developer need a function delete images, it is best to make subclass () and there to override this feature. Since we can not guess where to store the image. I show you my solution

This is in SKPhotoBrowser

public func deleteButtonPressed(sender: UIButton) {

    }

    public func deleteImage() {
        if photos.count > 1 {
            photos.removeAtIndex(currentPageIndex)
            gotoPreviousPage()
            updateToolbar()
        } else if photos.count == 1 {
            dismissPhotoBrowser()
        }
        reloadData()
    }

This is a SKPhotoBrowser subclass

class ImageBrowser: SKPhotoBrowser {

    override func deleteButtonPressed(sender: UIButton) {
        print("ImageBrowser")
        let userDefault = NSUserDefaults.standardUserDefaults()
        let documents = "documents"
        let deleteController = UIAlertController(title: nil, message: "Вы действительно хотите удалить документ?", preferredStyle: .Alert)
        deleteController.addAction(UIAlertAction(title: "Нет", style: .Cancel, handler: nil))
        deleteController.addAction(UIAlertAction(title: "Да", style: .Destructive, handler: { (action) -> Void in
            var allDocuments = [DocumentEntity]()
            if let data = userDefault.objectForKey(documents) as? NSData {
                allDocuments = (NSKeyedUnarchiver.unarchiveObjectWithData(data) as? [DocumentEntity])!
            }
            allDocuments.removeAtIndex(self.currentPageIndex)
            let newData = NSKeyedArchiver.archivedDataWithRootObject(allDocuments)
            userDefault.setObject(newData, forKey: documents)
            userDefault.synchronize()
            self.deleteImage()
        }))
        presentViewController(deleteController, animated: true, completion: nil)
    }
}

And we can to use this subclass like

 let imageBrowser = ImageBrowser(photos: imageArray)
        imageBrowser.delegate = self
        imageBrowser.isForceStatusBarHidden = true
        imageBrowser.displayDeleteButton = true
        imageBrowser.initializePageIndex(indexPath.row)
        presentViewController(imageBrowser, animated: true) { () -> Void in
        }

I checked it and it fine works. What do you think about it?

Is there a way to dismiss the shown image back to the originImage/animatedFromView?

Using the latest swift 3 version I get a nice animation from the animatedFromView to the SKPhotoBrowser but when dismissing the image is just faded out.

Anything I'm missing?

Hello. With the newest version of SKPhotoBrowser ( 3.0.0 ) i am getting this fatal error when the browser loads and displays one of the pictures. It is marking this line from the code guard let page = self.pagingScrollView.pageDisplayingAtPhoto(photo), let photo = page.photo else { and using the debugger to get some information it shows that (lldb) p pagingScrollView (SKPhotoBrowser.SKPagingScrollView!) $R1 = nil and (lldb) po pagingScrollView fatal error: unexpectedly found nil while unwrapping an Optional value expression produced error: /var/folders/gv/hmkzdb493jbcg1drw2m_6h_80000gn/T/lldb/410/expr127.swift:1:95: error: 'SKPagingScrollView' is not a member type of '$__lldb_context' (aka 'SKPhotoBrowser') $__lldb__DumpForDebugger(Swift.UnsafePointer<Swift.ImplicitlyUnwrappedOptional<SKPhotoBrowser.SKPagingScrollView>>(bitPattern: 0x11f483eb0).memory) ~~~~~~~~~~~~~~ ^ /var/folders/gv/hmkzdb493jbcg1drw2m_6h_80000gn/T/lldb/410/expr127.swift:1:45: note: while parsing this '<' as a type parameter bracket $__lldb__DumpForDebugger(Swift.UnsafePointer<Swift.ImplicitlyUnwrappedOptional<SKPhotoBrowser.SKPagingScrollView>>(bitPattern: 0x11f483eb0).memory) And now im using version 2.0.3 since i don't have that problem there.

How can I use a custom cache and downloader? I use Kingfisher as my MainImageManager, so when loading a new image from url, both SKPhotoBrowser and Kingfisher downloading the photo.

P.S: I had one other problem: I have a floating view (like FAB button), when dismissing a photo by swipe, it's animation covers the floating view till it's fit in the source rect. How can I manage this? (I've tried to send the animating view to back of the floating view, but in another view I have two floating buttons that this workaround won't work.)

Also when a photo is dismissed by swipe where source rect is not in view, the animation is weird (flickering till disappears), I've managed it by manipulating the SKPhotoBrowser class, but I just wanted to know do you have any straight solution for that?

Thanks! 😊

Undefined symbols for architecture arm64: "_swift_stdlib_isStackAllocationSafe", referenced from: _$ss10_NativeSetV11subtractingyAByxGqd__7ElementQyd__RszSTRd__lF14SKPhotoBrowser19SKZoomingScrollViewC_SayAIGTg5Tf4ng_n in libSKPhotoBrowser.a(SKPagingScrollView.o) ld: symbol(s) not found for architecture arm64

SKPhotoBrowser is a beautiful tool which save million of lives, only thing which I was missing is the video support, I tried my level best to write code following the same footprint, I hope my pull request will be accepted and I will become part of the community

If the Arabic share button is on the left, it will cause the button to be unclickable. I hope to release a version as soon as possible, and now I will overwrite the modified code every time I execute pod install.

1. It will fix #425.
2. Added some tests for SKPhoto to guarantee SKPhoto instances are functional.
3. I'm willing to adjust the code if you had a better approach.

• When SKZoomingScrollView is initialized, the setup() method is called twice: once in init(frame:) and then once more in init(frame:browser:)
• Double call of setup() results in UI elements (such as SKDetectingImageView) created twice
• Even though SKZoomingScrollView’s properties (e.g. imageView) are reassigned on the second call of setup(), the UI elements remain in the view hierarchy and device’s memory
• To fix this, init(frame:browser:) has been to changed to be a designated initializer, and init(frame:) has been removed