Hi, thanks for all your work!.

I noticed the tagged release is on 1.0.4 but the spec file is on 1.0.3. I import this project via github and grabs that version. Another issue is that on cocoapods the version available is 1.0.2 which doesn't build on swift 5, maybe also update that?

The latest release won't build in Carthage with Xcode 10.2 due to Swift 3.0 being deprecated.

The master branch is compatible, but a new release hasn't been created yet. @toineheuvelmans would it be possible to create a new release including the new changes on master?

Hi! Great library!

I'm getting this error when attempting to run the example playground:

error: /var/folders/y0/p7w_bnh91nv7vsl4kcymcxbh0000gq/T/playground6-adf4ec..swift:3:8: error: no such module 'Metron_Sources'
import Metron_Sources

Any ideas?

BTW, suggest adding a note about running pod install. From the Playground:

NOTE: Run pod install in the Example folder and then open the Xcode workspace. You will need to build the project first before Metron is available in these playgrounds. Ensure that you have a Simulator-type device selected when building.

Fixes #15. When a line is defined as vertical line, the contains method returned false, even though the given point is contained within the line. The fix for this issue considers both definition types and checks whether the x-position matches with the x-coordinate of the given point. If this is the case it is guranteed that the given point is contained in the line.

Hi, It seems like there is an issue with the calcul used in intersection(with:) function. If you try this small example, you won't find any intersect point whereas it actually exist

let lineA = LineSegment(a: CGPoint(x:187.5, y:108.873626373626), b: CGPoint(x:352.335164835165, y:108.873626373626))
let lineB = LineSegment(a: CGPoint(x:272.0, y:88.0), b: CGPoint(x:354.0, y:388.0))
let point = lineA.intersection(with: lineB) //return nil

I get the following error when trying to build my project after adding Metron via Podfile.

Polygon.swift
Error:(233, 34) contextual closure type '(CGPoint, CGPoint) -> Bool' expects 2 arguments, but 1 was used in closure body

I'm using the following swift compiler: Apple Swift version 4.0.3 (swiftlang-900.0.74.1 clang-900.0.39.2) Target: x86_64-apple-macosx10.9

Build error using XCode9 / Swift 4. Polygon, sorted requires two arguments.

Link: https://github.com/toineheuvelmans/Metron/blob/712905ebd8efe7340f86bb74694de637cccd85fa/Metron/Classes/Polygon.swift#L233

Confirming that LineSegment.intersection(with:) may return nil for valid intersection cases:

let s1 = LineSegment(a: .init(x: 187.50440979003906, y: 543.5147094726562), b: .init(x: 333.1461486816406, y: -109.8446273803711))
let s2 = LineSegment(a: .init(x: 0, y: 0), b: .init(x: 375, y: 0))
let intersection = s1.intersection(with: s2) // nil

Should not be nil, as the two segments are intersecting at a point:

My polygon CGPoints:

(0.0, 0.0), (0, 4.6849846839904785), (-3.7979183197021484, 8.482921600341797), (-8.482903480529785, 8.482928276062012), (-13.167887687683105, 8.48293399810791), (-16.965824127197266, 4.685009002685547), (-16.965829849243164, 0), (-16.965837478637695, -4.684959888458252), (-13.167911529541016, -8.48289680480957), (-8.482927322387695, -8.482903480529785), (-3.7979419231414795, -8.482909202575684), (0, -4.6849846839904785), (0.0, 0.0)

My point:

(-14.683422088623047, 1.410199522972107)

Result:

polygon.contains(point) // false

It does contain the point

let lineSegment1 = Metron.LineSegment(a: CGPoint(x: 5.203594207763672, y: 3.6903457641601562), b: CGPoint(x: -9.671459197998047, y: 9.507403373718262))
let lineSegment2 = Metron.LineSegment(a: CGPoint(x: (3.9301047325134277), y: 3.930098295211792), b: CGPoint(x: 3.930110216140747, y: 8.778124809265137))
	
let intersection = lineSegment1.intersection(with: lineSegment2)

Intersection returns nil, when it should return as CGPoint(x: 3.9301050246323883, y: 4.18835808998847)

You can see these numbers on Desmos: https://www.desmos.com/calculator/aqc2syqz2s

I have another function in my project which does the same job, which may be able to give a hint as to why the Metron function isn't working properly:

extension CGPoint {
    static func intersectionOfLines(line1: (a: CGPoint, b: CGPoint), line2: (a: CGPoint, b: CGPoint)) -> CGPoint? {
	
        let distance = (line1.b.x - line1.a.x) * (line2.b.y - line2.a.y) - (line1.b.y - line1.a.y) * (line2.b.x - line2.a.x)
        if distance == 0 {
            print("intersection issue, parallel lines")
                return nil
        }
	
	let u = ((line2.a.x - line1.a.x) * (line2.b.y - line2.a.y) - (line2.a.y - line1.a.y) * (line2.b.x - line2.a.x)) / distance
	let v = ((line2.a.x - line1.a.x) * (line1.b.y - line1.a.y) - (line2.a.y - line1.a.y) * (line1.b.x - line1.a.x)) / distance
	
	if (u < 0.0 || u > 1.0) {
		print("intersection issue, intersection not inside line1")
		return nil
	}
	if (v < 0.0 || v > 1.0) {
		print("intersection issue, intersection not inside line2")
		return nil
	}
	
	return CGPoint(
		x: line1.a.x + u * (line1.b.x - line1.a.x),
		y: line1.a.y + u * (line1.b.y - line1.a.y))
        }
}

If you should choose to pursue implementing a Bezier cubic curve, my repository CeranPaul/SketchCurves has class "Cubic" that could be helpful to you.

I haven't spent any time on a quadratic curve, but can see the usefulness of that for importing and exporting SVG's.

My repository needs to have its Ellipse class fleshed out. I'll be in touch when I have something useful.

 Paul

Metron is a lovely little library and has saved me a ton of time! Circle works for some cases, but not for ellipses. Seeing this officially supported would be great.