⬆️ A SwiftUI view component sliding in from bottom

The way to reproduce is to put a simple Rectangle in the BottomSheet and start with isPresented = false. While the GeometryReader is loading, the offset is incorrect and creates a flicker.

Hello authors,

I have a simple cart list. After add Bottom sheet to my project, I have unespected margin:

https://user-images.githubusercontent.com/7614148/109086117-bde08e80-76e9-11eb-9460-9281139417e4.png

Before add BottomSheet:

https://user-images.githubusercontent.com/7614148/109086184-e49ec500-76e9-11eb-8e2f-96dd4b1446cf.png

CartView source code: https://gist.github.com/MarcusAdriano/9affed479cd7b47cbedb5d9d940628aa

I can't think of any instance where the geometry reader has a size of 0 where we would want to display the bottom sheet. I have tested this in my own app and it appears to work quite well. This fixes "flickering" when using bottom sheet anywhere that is not a top-level view.

Here the param geometry in: should be just geometry: https://github.com/weitieda/bottom-sheet/blob/72b1809abaf0c7697f4f3633c619c3f7ceda3415/Sources/BottomSheet/BottomSheet.swift#L73

Forgive me please, as this is my first attempt at an issue and I'm new to programming. I am trying to utilize your wonderful SPM project in my own application.

@State var presentedLocation: Location?
           
 .sheet(item: $presentedLocation) { place in
    SelectedBusinessSheet(selectedBusiness: place)
}

Above is how I would call this sheet and display the data. the presentedLocation is an identifiable struct that is used to create an array of data. This method displays the sheet as desired but it looks poorly and would look better in a BottomSheet.

I am unable to mimic this method however, as displayed below, I get the following errors.

.bottomSheet(isPresented: $presentedLocation, height: 700, content: { place in
   SelectedBusinessSheet(selectedBusiness: place)
})

• Cannot convert value of type 'Binding<Location?>' to expected argument type 'Binding'
• Contextual closure type '() -> SelectedBusinessSheet' expects 0 arguments, but 1 was used in closure body

I apologize if these are obvious errors that can be easily rectified. Any help is appreciated!

Hello. I am in the process of publishing a framework to cocoa pods. I have two dependencies, this package and kingfisher. I am able to add the dependency to kingfisher no problem in the podspec file. But this package seems to be have it specs hosted in a private repository. I am not able to use it as a dependency. I was wondering if anyone knew the url that the spec is hosted at or if anyone knew how i could handle this.

Thank you very much!

I think that some actions are needed when bottom sheet is closed. it is little tricky to dismiss the keyboard to TextField on iOS 14, so I added escaping function. Please consider it for the next version! Thank you so much for your library.

The home-gesture on iOS devices without a physical home button can collide with the DragGesture that is attached to the bottom sheet. The gesture allows to hide the presented bottom sheet by dragging the top bar down to the edge of the screen.

However, when swiping up from the bottom to send the app to the background, the gesture still receives changes. When the bottom sheet is hidden, this can lead to a miscalculation of the sheet position. See the attached video:

The fix is to ignore the swipe-up gesture when the bottom sheet is hidden.

News

Lists used on example (iOS Example) has some unespected padding (iOS 14+):

Current issue open: #5

Padding was removed using: .listStyle(PlainListStyle())

After code fix:

Now we can customize top bar corner radius and top bar height using topBarCornerRadius and topBarHeight parameter.

topBarHeight / 3 is used as top bar corner radius like before unless topBarCornerRadius parameter is given.

30 is used as top bar height like before unless topBarHeight parameter is given.

Screenshot: top bar corner radius to 16pt, top bar height to 16pt

This PR fixes https://github.com/weitieda/bottom-sheet/issues/13.

With this PR, it is now possible to show/hide the Botton sheet based on an item being nil or not.

@State var presentedLocation: Location?

.bottomSheet(item: $presentedLocation, height: 700) { place in
   SelectedBusinessSheet(selectedBusiness: place)
}

This is similar to https://developer.apple.com/documentation/swiftui/form/sheet(item:ondismiss:content:)

When my horizontal scrollView is longer than the bottomSheet width, we didn't see extra items: https://user-images.githubusercontent.com/29228517/121769865-47677f80-cb66-11eb-87a9-0962f55db6d8.mp4

Can now customize the animation of the BottomSheet View opening and closing by adding the optional animation parameter. When deciding not to provide the animation parameter the default animation is continued left as .interactiveSpring() otherwise it requires an Animation modifier.

Example Video: the custom animation added to Map Settings is set to Animation.spring(response: 0.5, dampingFraction: 2.0, blendDuration: 1.0)

https://user-images.githubusercontent.com/36911172/115977902-0ed5fd00-a54a-11eb-99dc-48a7f33e4f93.mov

Hey, is there a way to move the outer view by dragging only the inner scroll? (like in Apple Maps app, Find My by Apple, Google Maps)

for example UIKit solutions: UBottomSheet - https://github.com/OfTheWolf/UBottomSheet ClassPass app - https://medium.com/classpass-engineering/creating-a-fluid-scroll-experience-on-ios-faeb29be3bdb

Thanks for creating this library

I am trying to use TextEditor inside .bottomSheet. UI works as expected

However, as soon as I tap inside TextEditor, keyboard pops up and covers the bottom sheet

What can be done to readjust the bottom sheet?