Hi! I compile framework with Carthage, and add PasscodeLockView.xib, PasscodeSignButton.swift, PasscodeSignPlaceholderView.swift to project. For PasscodeLockView.xib set owner PasscodeLockViewController class. After compile passcode show normal, but after tap on number pad got error "PasscodeLock was compiled with optimization - stepping may behave oddly; variables may not be available." What am i doing wrong ?

If I toggle the passcode switch to 'on', set a passcode, and then leave the app. Upon returning, I'm greeted with the new passcode, but no touchID authentication modal. I have to kill the app, and then enter it to get the touchID authentication modal to present.

I've an app written in Swift 4, but it crashes at the end of Passcode set. Here the lines of code I used to open Passcode set interface:

let passcodeVC = PasscodeLockViewController(state: .setPasscode, configuration: configuration)
present(passcodeVC, animated: true, completion: nil)
passcodeVC.successCallback = { lock in
    passcodeVC.dismiss(animated: true, completion: nil)
}

Here what the console has printed:

Simultaneous accesses to 0x1c40ed9c8, but modification requires exclusive access.
Previous access (a modification) started at Smartface`PasscodeLock.addSign(_:) + 912 (0x104a269bc).

That is the highlighted function when the app crashes (it's in PasscodeLock.swift):

open func changeStateTo(_ state: PasscodeLockStateType) {
    self.lockState = state // this assignment is highlighted when the app crashes
    delegate?.passcodeLockDidChangeState(self)
}

Great repository, thanks for sharing! :clap:

Do you have any plans for supporting passcodes longer than 4 digits? i.e. would be great.

If not, do you want to give me some pointers on how to do it?

Thanks! :panos

By default .SetPasscode state has the cancel button. But in .EnterPasscode state cancel button is missing. Is there a simple way to enable cancel button in .EnterPasscode state?

Awesome lib! Thanks! @ziogaschr , @szappanyos , @yankodimitrov , @maximbilan , @gblotter

Hello @yankodimitrov. Thanks for the great work you've done so far in this lib.

I have added cocoapods support. I left your PasscodeKeychainRepository and PasscodeNSUserDefaultsRepository out, as I think that there is no need for someone to load them both in his code and this will be different for each app.

I was thinking that you might want to create a second pod, like SwiftPasscodeLockFull, that will include them. Which I don't really like as an idea.

Also I have added support for overwriting PasscodeLock.strings and/or PasscodeView.xib in your app. So as dev can easily change things without worrying about broken library updates using cocoapods.

Please check everything in .podspec, like version and license.

Can I pass segue from passcode ViewController to another ViewController wherein I allow to select folders where user want to enable password and dissmis that ViewController on Save?

I don't now if this is an Xcode 7 beta issue, or if I'm the only one... But when I tried implementing a custom xib file, as described here:

"PasscodeLock comes with two view components: PasscodeSignPlaceholderView and PasscodeSignButton that you can use to create your own custom designs. Both classes are @IBDesignable and @IBInspectable, so you can see their appearance and change their properties right inside the interface builder"

Interface Builder couldn't/wouldn't recognize the PasscodeSignPlaceholderView or PasscodeSignButton classes when I tried associating them with UIButtons, UIViews, etc.

First of all, great stuff!

Second, I have the scenario where a user reaches the max number of passcode attempts. When this happens, I want to delete all the sensitive information of the app and destroy the PasscodeViewController.

How can I do the latter?

Thanks! :panos

Hello @yankodimitrov. Here are all the changes I had todo so as this excellent lib works with an app we have released at Apple Store. I think all the below changes will/can help other developers integrate your lib based on their needs.

Please take a look, and let me know if you want me to change something or you need me to explain anything.

p.s: Sorry for having merged the #8 in this branch, but it helped me using it in our project. I can remove this commit from the branch if you think so.

Cheers, Chris

I have the need to set a successCallback to PasscodeLockViewController. I see that there are two options:

1. add a public var successCallback: ((lock: PasscodeLockType) -> Void)? which is then set as passcodeLockVC.successCallback
2. make the passcodeLockVC a public var.

p.s.: Why the successCallback passes the lock: PasscodeLockType. Can you give me a good example? I might benefit from that.

Perforce branch might be sync'ed multiple times with different revision numbers (by the command "git p4 sync --branch=NAME //perforce/path...")

In such situation, git p4 will see multiple perforce branches with same name and different revision numbers. The problem is that to make a shelve, git-p4 script will try to find "origin" branch, if not specified in command line explicitly. And previously script selected any branch with same name and don't mention particular revision number. Later this may cause failure of the command "git diff-tree -r $rev^ $rev", so shelve can't be created (due to wrong origin branch/commit).

This commit fixes the heuristic by which git p4 selects origin branch: first it tries to select branch with same perforce path and perforce revision, and if it fails, then selects branch with only same perforce path (ignoring perforce revision number).

Thanks for taking the time to contribute to Git! Please be advised that the Git community does not use github.com for their contributions. Instead, we use a mailing list ([email protected]) for code submissions, code reviews, and bug reports. Nevertheless, you can use GitGitGadget (https://gitgitgadget.github.io/) to conveniently send your Pull Requests commits to our mailing list.

Please read the "guidelines for contributing" linked above!

Originally posted by @kfrolov in https://github.com/git/git/pull/1229

Simultaneous accesses to 0x1c02f2248, but modification requires exclusive access. Previous access (a modification) started at PasscodeLock`PasscodeLock.addSign(:) + 912 (0x1059637bc). Current access (a modification) started at: 0 libswiftCore.dylib 0x0000000105cf1358 swift_beginAccess + 468 1 PasscodeLock 0x0000000105963b7c PasscodeLock.changeStateTo(:) + 168 2 PasscodeLock 0x00000001059649d8 protocol witness for PasscodeLockType.changeStateTo(:) in conformance PasscodeLock + 64 3 PasscodeLock 0x000000010594bc20 SetPasscodeState.acceptPasscode(:fromLock:) + 516 4 PasscodeLock 0x000000010594c304 protocol witness for PasscodeLockStateType.acceptPasscode(:fromLock:) in conformance SetPasscodeState + 196 5 PasscodeLock 0x000000010596342c PasscodeLock.addSign(:) + 1060 6 PasscodeLock 0x0000000105964910 protocol witness for PasscodeLockType.addSign(:) in conformance PasscodeLock + 92 7 PasscodeLock 0x000000010595de54 PasscodeLockViewController.passcodeSignButtonTap(:) + 216 8 PasscodeLock 0x000000010595df54 @objc PasscodeLockViewController.passcodeSignButtonTap(_:) + 72