Hi fellows!

I'm using your excellent library in one of the apps i'm working on and i've come across a weird problem when using LTHPasscodeViewController to secure the access.

I show the lock screen at application:didFinishLaunchingWithOptions: so the user encounters the lock screen on application launch. Subsequently i call the method to lock the screen in applicationWillEnterForeground for when the user puts the app in background, switches between app, etc...

Everything works fine except for when i'm in the app, locked or not, then i double tap the home button to bring the app switcher and try to close the app. I slide the app up to terminate, the app terminates but immediately the prompt for the user's fingerprint appears again preventing the app from closing.

I can close the app only by switching to another app then bring the app switcher and terminate the app.

Any ideas?

Thanks in advance.

Even if you rotate on previous page and then open passcode view in a portrait mode.

Was able to reproduce on demo application by enabling landscape orientations in project, then launching the app, rotating it to landscape, rotating back to portrait and pressing button "enable" in the demo app.

To show the full keyboard we call this:

- (void)setIsSimple:(BOOL)isSimple inViewController:(UIViewController *)viewController asModal:(BOOL)isModal

But it requires viewController to be non-nil. So how can I show it when app is coming from background, as I call

- (void)showLockScreenWithAnimation:(BOOL)animated withLogout:(BOOL)hasLogout andLogoutTitle:(NSString*)logoutTitle

from the AppDelegate?

On an iPad, if you tap on the close keyboard button at the bottom right.

Even if you tap on the digits, there is no way for the keyboard to come back up

I don't know what that screen in which you can swipe an app up to kill the process is called...

So I double press Home button and this screen appears right?

Notice the app "EZDiary". That is the app using LTHPasscodeViewController. Now I swipe the app up to kill the process:

if the device doesn't have a TouchID, it kills the process just fine. However, if TouchID is enabled, just after I swiped the app up, the app opens again and ask me for the TouchID! Because of this, I can't kill the process! It's like an infinite loop!

I basically put this code in viewDidLoad of the initial view controller:

    if LTHPasscodeViewController.doesPasscodeExist() {
        LTHPasscodeViewController.sharedUser().showLockScreenWithAnimation(true, withLogout: true, andLogoutTitle: nil)
    }

Why did this happen? viewDidLoad certainly doesn't get called when I swipe the app up, right?

Yeah I know I didn't put the code in the app delegate. But it doesn't seem to work if I put it there. The passcode view controller just doesn't show up. It only works if I put it in viewDidLoad.

On devices, there's a number of times when I can pretty reliably end up with the Passcode prompt instead of TouchID.

My setup:

1. On applicationWillResignActive I call

if self.passcodeEnteredRight {
     LTHPasscodeViewController.saveTimerDuration(60 * 5)
     LTHPasscodeViewController.saveTimerStartTime()
    }

2. On applicationDidBecomeActive I call:

if LTHPasscodeViewController.doesPasscodeExist() {
      if LTHPasscodeViewController.didPasscodeTimerEnd() {
        //immediately clear that it was previously entered correctly
        self.passcodeEnteredRight = false
        LTHPasscodeViewController.sharedUser().showLockScreenWithAnimation(true, withLogout: false, andLogoutTitle: "ResidentAdvantage")
      }

(In didFinishLaunchingWithOptions I've tried adding LTHPasscodeViewController.sharedUser().disablePasscodeWhenApplicationEntersBackground(), which doesn't seem to change the outcome below)

3. I run the app on my iPhone, validating with TouchID. Then if you directly lock the device, wait for the timer to end, and then unlock, I'm usually presented with the keypad to enter passcode. This also happens if you press the home button and then switch back to the app after the timer has expired.

(This is in the setting of before the patch I sent the pull request in, combined in with the other pull request, where you would never be able to get to passcode before with TouchID. I haven't had a chance to figure out the lifecycle of this issue.)

If I launch the app from the background, LTHPVC does not properly register number input. We never actually ask LTHPVC to show the lock screen, it just shows up automatically. Which is great, but it doesn't actually work properly.

Really cool stuff! Would love to put this into our app, but I have a few suggestions.

It would be neat if some of the define macros could be turned into public properties to make it more customizable.

My main issue is with the kLocalizationTableName. I'd love to be able to provide my own localization table. Our app is localized in german and we're using the informal way ("Du") of addressing to our users, whereas the pre-defined localization uses the formal "Sie". If the localization table name was an exposed property instead of a defined macro, it would be easy to address this issue.

Further, making the UI more customizable to really integrate well with the look and feel of the apps that use this component (by turning constants like the label font/color definitions etc. into public properties) would be really awesome.

Happy to create a PR if you're open to those suggestions!

:sunflower:

If App starts directly in Landscape Mode, app crashes in Method "supportedInterfaceOrientations".

- (NSUInteger)supportedInterfaceOrientations {
    if (_beingDisplayedAsLockscreen) return UIInterfaceOrientationMaskAll;
    // I'll be honest and mention I have no idea why this line of code below works.
    // Without it, if you present the passcode view as lockscreen (directly on the window)
    // and then inside of a modal, the orientation will be wrong.
    return UIInterfaceOrientationPortraitUpsideDown;
}

Possible Fix:

return [super supportedInterfaceOrientations];

But now: App starts without a crash in landscape mode, but orientation of the PasscodeView is wrong.

Setup: LTHPasscodeViewController is used for an iPad Project with the following Device Orientations:

Any quick idea how to fix this?

This isn't a bug in the library, but you are now required to add a NSFaceIDUsageDescription with some string value if you support Face ID for your passcode unlock. I'm not sure if there's a way to check the plist for this value at runtime and avoid initiating Face ID if it's missing, but the docs should probably be updated and I'm leaving this here for others to reference.

To reproduce the issue:

1. Launch an iPhone X or iPhone X simulator on iOS 11.4 with Face ID enabled and with faces enrolled
2. Add a passcode to your app with biometric support enabled
3. Re-launch the app to trigger the passcode lock
4. You should get a crash at this point instead of a Face ID prompt.

When launching an app from a UILocationNotification the keyboard is missing or behind the controller..

Can be reproduced by firign a local notification and launching the app via the notification.

Adds support for SPM. See README.md for instructions on how to add it to your project.

Finally got around to fixing this up again. Now that Apple supports Resources I was able to import the Localizations. I added to the LTHPasscodeViewControllerStrings method to search for the SPM bundle if it didn't find a localized string since Apple moves those localizations into its own bundle.

This key is absent in Korean strings. Would you add this key string? "Cannot reuse the same passcode" = "이전에 사용한 암호를 재사용할 수 없습니다.";