Depends on #179.

The project uses Pantry for deserialisations and storage. As noted in Pantry's README, it is no longer going to be supported.

So we should probably refactor to use the Codable protocol available in Swift 4. Not a small job.

First pass at fixing #214. I am using the CSS file used for other parts of the app for now (see results below).

Should we create a custom CSS just for Issues? Or does this look okay?

Also the app takes a lot longer to startup due to Markdown parsing. May look to what we can do to speed that up a bit. May compare other Markdown parsers for speed.

Not sure why or how this happened, but @nickoneill reported this.

I thought it was maybe Transparency turned off in Accessibility but that wasn't it. Hopefully someone has seen similar and can help reproduce this one.

When rotating from Portrait -> Landscape -> Portrait the cells do not resize correctly. There is too much vertical space.

Scrolled cells do resize though.

#174 - Group by category on the more issues page

Hi people - I am late to the party, this is my first open source PR :). Let me know if I need to make any changes.

• Changes to group issues by categories on the 'more issues' screen. No changes to Home: still shows just the 'active' issues.
• Issues are now fetched using the all==true flag — that means issues are not refetched again on the 'more issues' screen.

Details:

• Fetching issues:

  • Removed the Query (active, inactive) enum - now FetchIssuesOperation fetches all issues whenever 'fetchIssues' method IssuesManager is called.
  • IssuesViewController now does not create its own instance of IssuesManager. Instead the caller has to create and pass IssuesManager instance to IssuesViewController. This way issues that are already downloaded are shared between Home and More issues screen (this is because Home passes its own IssueManager reference to More issues in prepare segue).

• Showing only 'active' issues on Home:

  • Because IssuesManager now fetches all issues - IssuesViewController has to selectively display only 'active' issues.
  • Instead of filtering on the main thread - hiding the row (by returning height 0) for inactive issues.

• Grouping issues by category on more issues screen:

  • After downloading all issues, IssuesManager creates the category->[Issues] relationship.
  • This step also involves creating 'Uncategorised issues' section for issues that are not part of any category (this matches with the way things are implemented on the web front end)
  • Finally categories are alphabetically sorted. All three steps happen on a BG thread.

• UI changes:

• Home:

  • 'Whats important' header is now not sticky (scrolls away as the user scrolls). This is because earlier this was implemented as a section header - whereas in this PR 'whats important' is now a tableHeader.
  • This impacts Home.

• More issues screen:

  • 'Whats important' header is now NOT displayed on the more issues screen - I am not sure if this is expected behaviour. Did this because this header along with the first category header was not looking nice.
  • Category headers are displayed in the same style as existing header style - may be we can improve the UI a bit here (see the attached screen shots).
  • Uncategorised issues are always shown last - after all other categories.

in -[UIPageViewController queuingScrollView:didEndManualScroll:toRevealView:direction:animated:didFinish:didComplete:]

• Number of crashes: 1
• Impacted devices: 1

There's a lot more information about this crash on crashlytics.com: https://fabric.io/fickle-bits/ios/apps/org.fivecalls.fivecalls-ios/issues/58a1d1600aeb16625b3dc43f

We just posted a new call and it appears near the bottom of the results on iOS. Previously (at least I'm pretty sure?) the order was the same as the website.

As of yet, the order is determined only by the order in which it appears in the json, we have a proper ordering value on the server side though that we could pass through to clients if it makes more sense.

vs

I'm getting the Split Congressional District alert even when I use the Core Location option in lieu of entering my Zip code. If there's something about my location that makes the lookup unreliable, perhaps the dialog should be reworded?

I can see about collecting some additional info later for you folks.

Implemented to allow user to selectively choose weekdays

• created a multipleSelection view
• added a time selector, but the same time is applied to all

Updated 10 Oct 18

This PR adds basic Dynamic Type support (#144) to the IssueDetailViewController & CallScriptViewController.

Approach

The changes for full Dynamic Type support are going to land up touching each screen so I'd suggest we break this into multiple PR's if that sounds good with everyone? There are a lot of Gotchas when trying to support the Extra large AX1 - AX5 sizes so I'd suggest we break this down as follows:

• Pull Request into master for 1-2 screens at a time
• First iteration -> Best effort to support xSmall -> xxxLarge with minimal refactoring. (Largely storyboard changes)
• Future iterations -> Improvements to AX1-AX5 font sizes or that require larger code changes (Moving to StackViews, etc)
• I'd like to suggest we ignore visual defects that:
  • are only reproducible when changing Dynamic Type while a ViewController is on screen. This is such a low usage scenario that it’s not worth focusing on imho.
  • only occur at the extra large sizes AX1-AX5 for the first few passes.

Does that sound like a reasonable approach to everyone?

Changes in the PR

|Screen | small | xxxLarge | | --- | --- | --- | | Issue Detail | | | | Issue Detail + profile | | | | Call Page | | |

Deferred to later

• The Call Script page uses a collectionView for the dynamic buttons. To support dynamic height here we'd either have to look at resizable CollectionViewCells or potentially move to a simpler Stack View layout that can easily switch between a grid and a vertical stack.
• The Call Script header breaks down at AX2

An attempt at addressing #142 with the following changes.

1. Nice green result buttons
2. The checkmark view was turned into a Progress View. It draws the progress in green around the bordering circle. A checkmark is still shown as before if you are 100% complete.

An app clip to support a "QR" code that could be added to emails, flyers, posters etc regarding an issue.

The app clip would support loading the Issue detail, getting the general location and providing the contact details of relevant representatives.

https://developer.apple.com/app-clips/

We're a perfect fit for one of the latest improvements in privacy for iOS 14: one time use location prompts. We only get your location once when setting it and then we never use it again unless the user needs to change their location so providing access whenever the app is open is excessive.

• If a user is on iOS 14, when getting location automatically prompt for one-time access only.
  • Users on iOS 13 and before should get the old behavior.

Ideas coming out from WWDC 2020: we should add a widget or two. Open to more ideas for what we should display. I'll go into detail about one that I've thought of below:

Your Reps

Once users have a location set we have a cached set of your main reps (2 senators, 1 house rep) and it would be nice to give people a Rep Speed Dial widget on their home screen. Medium format, three circles with names and titles below. I'll do a little wireframe when I have a moment to describe it better.

in

• Number of crashes: 1
• Impacted devices: 1

There's a lot more information about this crash on crashlytics.com: https://fabric.io/fickle-bits/ios/apps/org.fivecalls.fivecalls-ios/issues/7ca730e0c4f464ad326629f9aed501dc?utm_medium=service_hooks-github&utm_source=issue_impact

Some folks want to just get reps phone numbers and call about issues not on the list. It would be good to have a generic page showing all your reps and their numbers for this.