Hi there,

I'm trying to test your lib. With the demo project (after pod install) I have this issue from compiler :

/LNRSimpleNotifications/LNRSimpleNotificationsDemo/LNRSimpleNotificationsDemo/ViewController.swift:56:60: Use of unresolved identifier 'LNRNotification'

This was the default behaviour in Swift 3 - the compiler inferred all these annotations automatically. Now in Swift 4, the compiler does not automatically infer these anymore and its necessary to explicitly add these @objc annotations to methods that should be available in ObjC.

It seems the version is not included in https://github.com/CocoaPods/Specs/tree/master/Specs/e/4/1/LNRSimpleNotifications either. So I guess it is not me.

pod search LNRSimpleNotifications (after repo update) will show the output:

-> LNRSimpleNotifications (0.6.1)
   Simple Swift in-app notifications.
   pod 'LNRSimpleNotifications', '~> 0.6.1'
   - Homepage: https://github.com/LISNR/LNRSimpleNotifications
   - Source:   https://github.com/LISNR/LNRSimpleNotifications.git
   - Versions: 0.6.1, 0.6.0, 0.5.3, 0.5.2, 0.4.2, 0.4.1, 0.4.0, 0.3.0, 0.2.3, 0.2.2, 0.2.1, 0.2.0, 0.1.2, 0.1.1, 0.1.0 [master
   repo]

I think nobody executed pod trunk push LNRSimpleNotifications.podspec. For more information see https://guides.cocoapods.org/making/making-a-cocoapod.html

Closes #21

With these changes, notifications can be configured to be displayed in a queue.

To enable the feature simply add in the class that triggers notifications:

notificationManager.notificationsQueueEnabled = true

Defaults to false to keep previous behaviour.

Notifications are stored in an array of:

class LNRNotification {
    var title: String
    var body: String
    var onTap: LNRNotificationOperationCompletionBlock

    init(title: String, body: String, onTap: @escaping LNRNotificationOperationCompletionBlock) {
        self.title = title
        self.body = body
        self.onTap = onTap
    }
}

When i receive a number of notifications simultaneously or in a short period of time, I would like them to remain in a queue.

Instead of immediately replacing each other as they get triggered, they would wait for the currently displayed notification to be dismissed.

This way all notifications can be seen and read easily by the user.

When an app is in multitasking mode (on iPad), the width of the notification extends beyond the width of the window.

This happens on iPad when apps are in side-by-side mode.

I changed these lines in LNRNotificationView

let notificationWidth: CGFloat = (UIApplication.sharedApplication().keyWindow?.bounds.width)!

override public func layoutSubviews() {
        super.layoutSubviews()
        self.notificationViewHeightAfterLayoutOutSubviews(kLNRNotificationViewMinimumPadding, notificationWidth: (UIApplication.sharedApplication().keyWindow?.bounds.width)!)
    }

Hello!

Exists any way for show a different notification from sharedInstace?

I have this code :

let notification = LNRSimpleNotifications()

    notification.notificationsPosition = LNRNotificationPosition.Top
    notification.notificationsBackgroundColor = UIColor.blueColor()
    notification.notificationsTitleTextColor = UIColor.whiteColor()
    notification.notificationsBodyTextColor = UIColor.whiteColor()

    notification.showNotification("Guardada correctamente", body: nil, callback: nil)

Show a notification and crashes!

The width of the titleLabel was set to the whole notificationWidth, not respecting the padding and not respecting the presence of an image.

This lead to the following Bug:

Fixed

With this fix these now look like that:

Autolayout

Btw, would it not be better to use Autolayout?

Xcode 9.1 is throwing 2 warnings of the type: 'characters' is deprecated: Please use String or Substring directly

when including the pod directly as pod 'LNRSimpleNotifications' in the podfile.

This should solve the issue

Allows for async UIImageView Allows for customizing the UIImageView with a block

notificationManager1.notificationsIconImageViewSetup = { imageView in
            imageView.backgroundColor = UIColor.red
}
notificationManager1.notificationsIconAsyncLoader = { completionHandler in
            let url = URL(string: "https://homepages.cae.wisc.edu/~ece533/images/airplane.png")
            URLSession.shared.dataTask(with: url!, completionHandler: { (data, response, error) in
                guard let data = data  else { return }
                let downloadedData = UIImage(data: data)
                completionHandler(downloadedData)
            }).resume()
}

When an app is in multitasking mode (on iPad), the width of the notification extends beyond the width of the window.

This happens on iPad when apps are in side-by-side mode.

I changed these lines in LNRNotificationView

let notificationWidth: CGFloat = (UIApplication.sharedApplication().keyWindow?.bounds.width)!

override public func layoutSubviews() {
        super.layoutSubviews()
        self.notificationViewHeightAfterLayoutOutSubviews(kLNRNotificationViewMinimumPadding, notificationWidth: (UIApplication.sharedApplication().keyWindow?.bounds.width)!)
    }

Notifications with Async Image Loader

Perhaps you'd like an asynchronous image. You'll need to create a variable of LNRNotificationAsyncImageBlock and pass it in on the show showNotification method.

Important: You will need to set an image on the Manager Instance like so:

notificationManager.notificationsIcon = UIImage(named: "lisnr-cir-bw-notifications-icon")

let imageAsyncLoader : LNRNotificationAsyncImageBlock = { completionHandler in
            let url = URL(string: "https://homepages.cae.wisc.edu/~ece533/images/airplane.png")
            URLSession.shared.dataTask(with: url!, completionHandler: { (data, response, error) in
                guard let data = data  else { return }
                let downloadedData = UIImage(data: data)
                completionHandler(downloadedData)
            }).resume()
        }


// Important to set the placeholder image
notificationManager.notificationsIcon = UIImage(named: "lisnr-cir-bw-notifications-icon")
// Call the showNotification method
notificationManager.showNotification(
            title: "Hipster Ipsum",
            body: "I love nier",
            imageAsyncLoader:  imageAsyncLoader
        )

Customizing the Icon UIImageView

You'll need to create a variable conforming to the block LNRNotificationImageViewSetupBlock. Then you can pass it into the showNotification block.

let imageViewSetup : LNRNotificationImageViewSetupBlock = { imageView in
            imageView.backgroundColor = UIColor.red
        }

// Important to set the placeholder image
notificationManager.notificationsIcon = UIImage(named: "lisnr-cir-bw-notifications-icon")
// Call the showNotification method
notificationManager.showNotification(
            title: "Hipster Ipsum",
            body: "I love nier",
            imageViewSetup:  imageViewSetup
        )