Summary

I've experienced an issue where it seems that "deep linking" more than 1 screen (via NavigationLink) "down" doesn't work as expected.

Steps to reproduce

1. Replace the body function in the PopToRootExample.swift with the following:

  var body: some View {
    NavigationView {
      RootView(store: Store(
        initialState: RootState(
            timer: .init(),
            first: .init(
                timer: .init(),
                second: .init(timer: .init())
            )
        ),
        reducer: Self.rootReducer.debug(),
        environment: ()
      ))
    }
    .navigationViewStyle(StackNavigationViewStyle())
  }

2. Run the app
3. Tap the "Pop To Root Example"

Expected behavior

I'd expect the app to display the Second Screen in the PopToRoot Example.

Actual behavior

The app opens up displaying the First Screen, and tapping the "Present Second" button doesn't do anything.

Thanks so much for your work on this library! I started using the previous iteration of the project in an app with recursive navigation with frequent effects and found that excessive calls to .cancellable and .cancel were causing performance issues. I've updated to this new version and really like the changes you made to how cancellation is handled.

Summary

This change refines how cancellation occurs in presented states. Both when effects are wrapped n .cancellable and when .cancel is sent. These effects are fairly costly in TCA [1], and since any action of a presented reducer is wrapped it can really add up.

Additionally, I introduced a @Presented property wrapper that allows presentation to be further optimized. To minimize change, the library works with property-wrapped values via presented or non-wrapped values via presents. The property-wrapped version is better in all cases though.

[1] Perhaps additionally so because they incur a lock. I'm looking into that.

What was done

• [x] Modify presents to only run the child reducer if the action is in the child domain. This reduces unnecessary wrapping with .cancellable.
• [x] Add tests for presents to confirm how often .cancel is sent
• [x] Introduce presented variation of presents that works with the @Presented property wrapper. This version is further optimizes to only .cancel when state goes from non-nil to nil.
• [x] Signification changes to combine to enable these changes.

Review notes

• [ ] It feels like combine should not be public. It's a great utility but now very specific to the internals.
• [ ] I couldn't find a cleaner way to assert on calls to cancel, thus the DEBUG-only global vars
• [ ] I'm not yet sure how these changes would adapt to CasePath presentation
• [ ] The Example should probably be updated to use @Presented
• [ ] I'm working on a larger sample of recursive navigation based on this, but it's looking good so far - I'll link it when it's finished. I'm also updating my app, which is looking good but I've yet to fully confirm the performance improvements.

Here is some code we can follow :) working CODE

public struct HidableTabView<SelectionValue, Content>: View where SelectionValue: Hashable, Content: View {
  let isHidden: Bool
  let selection: Binding<SelectionValue>?
  let content: () -> Content

  @State private var currentTabBarHeight: CGFloat = 0

  init(
    isHidden: Bool,
    selection: Binding<SelectionValue>?,
    @ViewBuilder content: @escaping () -> Content
  ) {
    self.isHidden = isHidden
    self.selection = selection
    self.content = content
  }

  public init(
    isHidden: Bool,
    @ViewBuilder content: @escaping () -> Content
  ) where SelectionValue == Int {
    self.isHidden = isHidden
    self.selection = nil
    self.content = content
  }

  public var body: some View {
    tabView
      .stackNavigationViewStyle()
      .padding(.bottom, isHidden ? -self.currentTabBarHeight : 0)
  }

  @ViewBuilder var tabView: some View {
    if selection != nil {
      TabView(selection: self.selection!) { self._content }
    } else {
      TabView { self._content }
    }
  }

  // swiftlint:disable identifier_name
  @ViewBuilder var _content: some View {
    self.content()
      .background(tabBarHeightReader)
  }

  var screenBottomSafeAreaInset: CGFloat {
    (UIApplication.shared.windows.first { $0.isKeyWindow }?.safeAreaInsets.bottom ?? 34)
  }

  var tabBarHeightReader: some View {
    GeometryReader { proxy in
      Color.clear
        .onAppear {
          self.currentTabBarHeight = proxy.safeAreaInsets.bottom + screenBottomSafeAreaInset
        }
        .onReceive(NotificationCenter.default.publisher(for: UIDevice.orientationDidChangeNotification)) { _ in
          self.currentTabBarHeight = proxy.safeAreaInsets.bottom + screenBottomSafeAreaInset
        }
    }
  }
}

Fixed: Pinned combine-schedulers to 0.7.3, which removes an errant @_exported import Foundation. This change may be breaking and require you to add import Foundation in your code.

so import Foundation fixed issue

I am using this package inside another package when I start the test I am getting this error I can't run my test here is my app link https://github.com/AddaMeSPB/AddaMeIOS/blob/feature/git_workflow/AddameSPM/Tests/EventViewTests/EventsViewTests.swift#L19

Steps to reproduce

you can just grab my app and run test

Actual behavior

test should run without any error

Attachments

Showing All Messages The package product 'ComposableArchitecture' requires minimum platform version 10.15 for the macOS platform, but this target supports 10.10

Summary

This PR adds NavigationDestinationWithStore SwiftUI helper, which can be used on iOS >= 16. It wraps the native navigation-destination view modifier and drives it with provided store of optional State and Action.

What was done

• [x] Add NavigationDestinationWithStore SwiftUI helper
• [x] Update DestinationExample

Summary

This PR adds PresentingCaseReducer for presenting given case of provided enum.

struct First: ReducerProtocol {
  // ...
}

struct Second: ReducerProtocol {
  // ...
}

struct Main: ReducerProtocol {
  struct State {
    enum Destination {
      case first(First.State)
      case second(Second.State)
    }

    var destination: Destination?
  }

  enum Action {
    case first(First.Action)
    case second(Second.Action)
  }

  var body: some ReducerProtocol<State, Action> {
    // ...
    .presenting(
      unwrapping: \.destination,
      case: /State.Destination.first,
      id: .notNil(),
      action: /Action.first,
      presented: { First() }
    )
    .presenting(
      unwrapping: \.destination,
      case: /State.Destination.second,
      id: .notNil(),
      action: /Action.second,
      presented: { Second() }
    )
  }
}

What was done

• [x] Update package dependencies
• [x] Add PresentingCaseReducer
• [x] Add DestinationExample
• [x] Add documentation

Summary

This PR adds presentationID parameter Reducer and ReducerProtocol methods. The presentationID identifies the presentation and is used to cancel effects on dismission.

What was done

• [x] Add presentationID parameter to ReducerProtocol.presenting method.
• [x] Add presentationID parameter to ReducerProtocol.presentingForEach method.
• [x] Add presentationID parameter to legacy Reducer.presenting method.
• [x] Add presentationID parameter to legacy Reducer.presentingForEach method.

Review notes

The presentationID parameter defaults to a new UUID and can be customized to AnyHashable value that should uniquely identify the presenting reducer. If this requirement is not met, the effects might not be canceled on dismission, which could lead to unexpected behavior.

Summary

This PR adopts ReducerProtocol.

More details:

• https://github.com/pointfreeco/swift-composable-architecture/discussions/1282
• https://github.com/pointfreeco/swift-composable-architecture/pull/1283

What was done

• [x] Switch to protocol-beta branch of Composable Architecture.
• [x] Add ReducerProtocol version of Reducer+Presenting extension.
• [x] Add ReducerProtocol version of Reducer+PresentingForEach extension.
• [x] Soft-deprecate legacy Reducer extensions.
• [x] Add documentation for ReducerProtocol extensions.
• [x] Switch to a stable release of Composable Architecture when available.

Review notes

~~⚠️ This is a draft PR with a beta release of the Composable Presentation library. Not suitable for production.~~

Summary

For some reason, Swift Package dependency resolving started to fail after the latest release of ComposableArchitecture library (v0.34.0). Not sure what is causing the problem (probably external changes in the dependency graph), but updating version requirement to the latest version solves it.

What was done

• [x] Update ComposableArchitecture requirement to v0.34.0

Review notes

This should fix the following dependency resolver issue:

Dependencies could not be resolved because no versions of 'swift-identified-collections' match the requirement 0.3.2..<1.0.0 and root depends on 'swift-composable-architecture' 0.33.1..<1.0.0. 'swift-composable-architecture' >= 0.33.1 practically depends on 'swift-identified-collections' 0.3.2..<1.0.0 because 'swift-composable-architecture' 0.33.1 depends on 'swift-identified-collections' 0.3.2..<1.0.0. 'swift-composable-architecture' >= 0.33.2 practically depends on 'swift-identified-collections' 0.3.2..<1.0.0 because no versions of 'swift-composable-architecture' match the requirement {0.33.2..<0.34.0, 0.34.1..<1.0.0} and 'swift-composable-architecture' 0.34.0 depends on 'swift-identified-collections' 0.3.2..<1.0.0.

Summary

This PR updates package dependencies.

What was done

• [x] Update swift-collections to v1.0.2
• [x] Update swift-case-pats to v0.8.0

Review notes

This change should fix #28