Hey foursquare people!

I love the lightweight design of FSNetworking and we're looking to use it on a new iOS project at HubSpot. We use CocoaPods for dependency management -- could you add this podspec to your repo so people can pull it in with CocoaPods instead of manually inserting the files?

(Right now, it links to my fork of the repo, but once the Podspec is in yours, I imagine we'd want to move it over.)

Hello i am trying to add many upload requests to a "queue". in your example you do: self.connection = [self makeConnection]; [self.connection start];

i have 2 questions: 1st -> how can i upload many requests to a single queue? 2nd -> how can i cancel a specific one from the queue?

thanks a lot

I am trying to integrate FSNetworking into my application. When I debug [FSNConnection start], I see the URL is invalid and I get the error "message sent to deallocated instance." When printed, I get: (lldb)po self.url (NSURL *) $4 = 0x07e81150 [no Objective-C description available]. The NSAssert(self.url, @"nil url") passes, I am guessing this is a dangling pointer.

My project is compiled with ARC enabled, and I set -fno-objc-arc as suggested in the readme file.

I have added a convenience method arrayFromJSONWithError: for the sake of completeness, in an effort to at least clarify issue #5. Additionally, I have silenced recent warnings for the demo projects.

I am adding a few things to FSNData, and I would like to know the why straight C code was used for NSString *stringForMimeType(MimeType type); over a class level method. Is it a preferred style, or some other reason?

Along with this method:

// convenience method to ensure that top-level json object is a dictionary
- (id)dictionaryFromJSONWithError:(NSError **)error; // error pointer must not be nil

it would be really great if you provide arrayFromJSONWithError that internally calls this one and returns NSArray of NSDictionary instances from JSON, that would be good. I guess you also have such a need in 4sq API. Am I missing an obvious workaround?

Thanks.

There is stuff accumulating in my fork that i would like to see upstream; most recently I did a small refactor of adam's isAcceptableValue changes and he asked me to open an issue. It is all very straightforward stuff.

My change set does not fix the missing NSArray urlEncodedString implementation, but it does add one for NSNumber that replaces the old inlined conditional logic.

Thanks! -g

No empty line / seperator after parameter value before the next boundary. http://www.ietf.org/rfc/rfc1867.txt doesn't specify this newline. This is an issue when uploading an object upload to Amazon's S3 API. It seems their HTTP server treats the newline as part of the value, which is correct according to the RFC. Removing the empty line made the object upload work.

Hi guys, i went back in this problem, basically we can't post NSArray as params, so, i thought to create an NSMutableDictionary variable, and dynamically putting in it all my params, creating subarray, like this 'params[object][][field1]' and so on. But my problem is that him is overwriting always the same value, not creating subarray. :-1: i tried to create params like this: [NSString stringWithFormat:@"supply[%i][description]", i], but is really ugly.

any better ideas to solve this problem? any workaround much better? thanks guys.

FSNConnection.m:523:36: Implicit conversion loses integer precision: 'NSUInteger' (aka 'unsigned long') to 'int'

Reason: The count method of NSArray returns an NSUInteger.

I changed type of concurrencyCountAtStart to NSUInteger.

We believe that #8 is caused by a race between a failing parse block in the background thread and a background task expiration triggered by UIKit.

In the event that this happens, an assertion exception is not appropriate. The user will not be able to catch this exception in a reasonable way, and the user will typically prefer to be notified of at least one error via c.error in the completion block.

@gwk, does this seem reasonable to you? We are hoping this will help us with this issue.

Hi I experience some problems with [self.connection cancel] in the dealloc method. I have a feeling it sometimes also cancel other ongoing request in the queue. Is this possible ? I have experimented both with and without FSN_QUEUED_CONNECTIONS.

- (void)dealloc {

    NSAssert(!self.connection, @"non-nil connection: %@", self.connection);

#if TARGET_OS_IPHONE
    // if this task was set to run in background then the expiration handler should be retaining self
    NSAssert1(self.taskIdentifier == UIBackgroundTaskInvalid,
              @"deallocated request has background task identifier: %@", self);
#endif


    [self clearBlocks]; // not cleanup; assert no taskIdentifer above instead

    // just to be safe in production
    FSNVerbose(@"%p: dealloc", self);

    [self.connection cancel];
}

I don't know if its supported, but it seems to work. Mostly.

In FSNConnection, there is the mutableset of current connections.

mutableConnections

It is a NSMutableSet and is a global, but accessed by eac h object with no @synchronize() {} block.

So the code need to change in two places -

In cleanup

NSMutableSet *requests = [self.class mutableConnections];
@synchronized(requests) {
    [requests removeObject:self];
}

And in start NSMutableSet *connections = [self.class mutableConnections]; @synchronized(connections) { [connections addObject:self]; }

I got a crash (as would make sense) when using about 3 of these on threads on 10.8.4 Mac, with XCode 5. With Zombies and what not on, it pointed right at the cleanup line.

--Tom

I’ve recently added FSNetworking to the CocoaPods package manager repo.

CocoaPods is a tool for managing dependencies for OS X and iOS Xcode projects and provides a central repository for iOS/OS X libraries. This makes adding libraries to a project and updating them extremely easy and it will help users to resolve dependencies of the libraries they use.

However, FSNetworking doesn't have any version tags. I’ve added the current HEAD as version 0.0.1, but a version tag will make dependency resolution much easier.

Semantic version tags (instead of plain commit hashes/revisions) allow for resolution of cross-dependencies.

In case you didn’t know this yet; you can tag the current HEAD as, for instance, version 1.0.0, like so:

$ git tag -a 1.0.0 -m "Tag release 1.0.0" $ git push --tags