Allowing zooming, or displaying only part of the song.

Some notes on seeking an AVAssetReader are at http://stackoverflow.com/questions/13210684/reading-samples-with-avassetreader-and-timerange-in-real-time

Hi, Amazing thanks! Had a question. R u planning to add selection? For example I want to select a specific section of the file (using Pan gesture -- UIGestureRecognizerStateBegin and End in handlePanGesture()). So the user can select a section of the file with his finger (pan/touch); of course color the selection differently. thank you very much

Hi!

I've successfully integrated your library into one of my projects. It works very nice, but sometimes the waveform is not rendered and I get the "FDWaveformView failed to get graphics context".

Do You know what to do then or the circumstances why it can happen?

BR Joern

I'm no audio expert by any means, so this might be a silly question: is FDWaveformView supposed to be compatible with M4A files?

When I try to set the audioURL to my M4A file (local file, not streamed) the code crashes as the "tracks" property is an empty array.

--Joao

When you enable doesAllowStretch and zoom in, the progressSamples value is incorrect in relation to where you click on the wave form. It seems to always calculate progress samples based on the zoomed out waveform. Let me know if you need more information and I will try to provide it.

Version 1.0.1 is not visualizing when trying to play a sound shorter than 2 secs, obviously there is something with the frame calculation since the image frame printed by the console is minus one pixel of width:

(9.0, 6.0, 84.0, 30.0) -- (-0.00151425, 0.0, 0.00151425, 30.0)

Weird thing is that is the same value of the x position.

With 0.3.1 version it works fine.

It happens after fixing that issue i think https://github.com/fulldecent/FDWaveformView/issues/76

That crash occurs in case with tableView with audio cells (7-8 cells with short audio)

func sliceAsset(withRange slice: Range, andDownsampleTo targetSamples: Int, done: (_ samples: [CGFloat], _ sampleMax: CGFloat) -> Void) { guard slice.count > 0 else { return } guard let asset = asset else { return } guard let assetTrack = assetTrack else { return } guard let assetReader = assetReader else { return }

    assetReader.timeRange = CMTimeRange(start: CMTime(value: Int64(slice.lowerBound), timescale: asset.duration.timescale), duration: CMTime(value: Int64(slice.count), timescale: asset.duration.timescale)) <<------ here is crash

here is screenshot http://joxi.ru/RmzYddWcoLzkrO

I needed support for rending the waveform image outside of the view so I could cache it as well as support for showing a linear scaled waveform. This PR includes those features as well as several bugs that were fixed along side the massive refactor:

Features Added:

• Added support for rendering waveform images outside of a view (See FDWaveformRenderOperation).
• Added support for rendering linear waveforms.
• Added support for changing wavesColor and progressColor after waveform was rendered.
• Added support for updating waveform type and color to iOS Example app.

Bugs Fixed:

• Fixed bug which could prevent waveform from fitting new view size if rendering was in progress during a view resize.
• Fixed bug which caused waveformViewDidLoad() to not be called after the audio file was loaded.
• Fixed bug which caused subsequent waveform renderings for new audioURLs to never complete if there was an error with a previous render.
• Fixed bug which could cause a crash (divide by zero error) if the view's width was 0.

Tested performance using iOS Example's performance testing and confirmed there were no regressions. Tested linear/log and color changing support in added features in iOS Example app.

Note that this also includes the changes made in my previous PR https://github.com/fulldecent/FDWaveformView/pull/79.

*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: '*** -[AVAssetReader addOutput:] cannot add an output that has already been added to another AVAssetReader'

I use the pod for a sampler app, where you shot many sounds quickly and update the wave form analyzer, from time to time i got that exception, let me paste where it did happen:

        let readerOutput = AVAssetReaderTrackOutput(track: assetTrack, outputSettings: outputSettingsDict)
        readerOutput.alwaysCopiesSampleData = false
        reader.add(readerOutput)  <<<--- HERE

I have a audio saved on a Realm Database as NSData. With AVAudioPlayer I can success load the data and play the audio. I'm willing to use FDWaveformView to display the sound waves, but I couldn't found a way to make it work with NSData instead URL...

When trying to render this file, it crashes at line 266 , when doing downsample and average. The weird thing is that if i enable the address sanitizer in the scheme it wont crash!

iOS 8.2, iPad mini, FDWaveformView 2.2.1.

Urban Grooves 20.caf.zip

This change allows keeping the TeamID out of the project files. This way people can just clone the git repo, add their TeamID in a copy of the file "DEVELOPMENT_TEAM.xcconfig.template" then named "DEVELOPMENT_TEAM.xcconfig" and signing of the iOS Example will magically work.

This is described in detail in the file "Shared.xcconfig".

The README file uses this code sample:

self.waveform.progressSamples = self.waveform.totalSamples / 2

To illustrate the Set play progress feature (also applies to the Supports animation feature).

Latest code version requires something like this:

let samplesToHighlight = waveformView.totalSamples / 2
 waveformView.highlightedSamples = 0 ..< samplesToHighlight

Suggestion: Update the README to reflect this code change.

Hi,

I tried the sample iOS app, it works with the .mp3 and .aac sample files, but when I try connecting and loading the ogg file it gives me the following error: FDWaveformView failed to load AVAssetTrack

An additional screenshot showing the change made to load the ogg file and the place where the error occurs:

Is ogg currently not supported?

Thanks in advance.

Here is a competing product: https://github.com/dmrschmidt/DSWaveformImage

They separate the rendering step from the display/interaction control. It is possible for us to do this as well. Considering if this should be in-scope for the project.

Also they have nice rendering styles which we should consider: gradient and bars ("lo fi").