Simon Tatham's Portable Puzzle Collection

Tried to run the Puzzles.xcodeproj in Xcode 4.6.1 but it failed - missing file 'list.c'. Is the file required or is it indicating it doesn't work in this version of Xcode?

This has several different pieces, let me know if you'd prefer I split it into several PRs. Also, I know the diff looks big but most of that is just removing the PSTCollectionView files. The actual substance is less than a score of lines.

The app currently crashes on iOS 14 due to an assertion in UICollectionView that registered cell classes are subclasses of UICollectionViewCell. The class in question, GameListViewCell, is in fact a subclasses of PSUICollectionViewCell, which indeed does not inherit from UICollectionViewCell. Changing the superclass of GameListViewCell to UICollectionViewCell fixes the crash with no apparent side effects—as expected of an "API-compatible replacement" for UICollectionView.

Since the PSTCollectionView library is only a compatibility layer for iOS versions before 6, it is no longer needed. Changing the other couple references to it to their UIKit counterparts also appears to have no side effects, and allows us to remove the library altogether.

Additionally, when built for iOS 13+ and run in dark mode, text on the game list is white-on-white, and the status bar text is white on light gray, not great contrast. I have included basic dark mode support, adopting a system color that updates automatically based on dark mode state for the game list cell background, and forcing the game status bar text to remain black. One could go further, changing the bar tint colors or perhaps even the game color lists, but I'm not a designer and this is good enough.

When playing Undead, it's nice to be able to remove a mark you made, but not the one you just made (which can be removed with undo). In the desktop version, you do this by typing space.

I've tested this in the iOS simulator, but I don't have an iOS developer account, so I couldn't test it on actual hardware.

In version 1.3.1, the toolbar appears under the home bar for devices without a home button, making them difficult to press (this regression was caused by the SDK update). This PR updates the game view to account for the "safe area".

On my iPhone XS (iOS 14.0), before:

After:

On the "iPad Pro (12.9-inch) (3rd generation)" simulator (iOS 13.3), before:

After:

Cheers,

When pushing key kombo Strg+S several times you need to push also several times to undo. I think once should be enough because you cant solve it more than once and after that one undo should be enough.

Thanks,

I love this open source game package, thanks for maintaining it!

The Android version of Tatham’s Puzzle Games has a little control panel inside each game that enables toggling the functions of short and long click during game play. Could you implement that in the iOS version? For games that call for lots of long clicks, this feature makes them much more playable.

My system: iOS 15.2.1

App version: 1.3.2.1 Original Revision: f1e68fb Downloaded from Apple app store a few days ago

This bug report is about the right click sound played by the long tap action which simulates right click. To reproduce, open a new game of Mines, and perform a long tap on any square of the board. (Or pretty much at any time in any game, that's just one example.)

My phone has two volume controls: media and ringer. Media volume is in the control center which is accessed by swiping down from the top right. Ringer volume is in settings -> sound and haptics -> Ringer and alerts. Typically, ringer volume determines the playback volume of ringer and alerts while media volume controls the volume of video playback, music, and games.

The expected behavior is for games to use the media volume to for the long tap sound. The actual behavior is that this app uses the ringer volume. This means that in order to hear the long tap sound clearly (it is a very faint sound and very important for gameplay) I need to turn my ringer volume all the way up, and then my phone rings loudly if I get a call.

Glad to provide more details if needed, thanks for maintaining this package :)

The game ids and random seeds cannot be edited or copied. This problem has been going on for at least a few months, but I’m not sure when it started exactly. I’ve had it on both an iPhone SE (the old SE) and an iPad, on various subversions of iOS 14.

I've been keeping my own fork of your code up-to-date with Simon Tatham's updates over the years. Lots of little bugfixes, but he also added a new game at some point.

But at some point I also merged in a branch from some other guy's additional puzzles for the collection: https://github.com/x-sheep/puzzles-unreleased

Since you hadn't updated in years, I didn't think to keep a completely separate branch without those additional "x-sheep" puzzles. I did, however, keep my iOS build file changes in a separate branch. That separate branch is the one I've been using to build and then locally install on my iPhone and iPad. So this PR should produce a clean build that only incorporates 5 years' worth of upstream merges. It does have the x-sheep files in the source, but they're not incorporated into the build.

If you're interested in those additional puzzles, I can make different PR that includes the changes to Puzzles.xcodeproj/project.pbxproj I've been using to include them in the build.

If you're interested in the upstream merges but not the x-sheep puzzles, and you'd prefer a nice clean PR without the extra garbage, then I can make a cleaner PR for you.

If you're not interested in any of this at all, then I'll just say "thanks" for creating this iOS build in the first place :)