Hi.

I have faced for strange behaviour of grouped tableview with TableKit. I can't remove extra top space for grouped table (I use xibs - iOS 10/11).

I do following:

    func reload(withModels models: [MyModel]) {

        tableDirector.clear()

        let section = TableSection()
        tableDirector += section

        section.headerHeight = CGFloat.leastNormalMagnitude
        section.footerHeight = CGFloat.leastNormalMagnitude

        for item in models {

            section += TableRow<MyTableViewCell>(item: item)
                    .on(.click, handler: { [weak viewOutput] _ in

                    })
        }

        tableDirector.reload()
    }

Also I have tried to make subclass of TableDirector and always return CGFloat.leastNormalMagnitude for all sections. It's didn't work also.

--- But ---- If I implement datasource/delegate manually. It works fine - no any extra space on top.

extension MyTableDataSource: UITableViewDelegate {
    func tableView(_ tableView: UITableView, heightForRowAt indexPath: IndexPath) -> CGFloat {
        return MyTableViewCell.defaultHeight
    }

    func tableView(_ tableView: UITableView, heightForHeaderInSection section: Int) -> CGFloat {
        return CGFloat.leastNormalMagnitude
    }

    func tableView(_ tableView: UITableView, heightForFooterInSection section: Int) -> CGFloat {
        return CGFloat.leastNormalMagnitude
    }
}

@maxsokolov Привет! Во-первых Макс спасибо за отличную библиотеку! Но похоже есть небольшой memory leak, посмотри:

In English: I have very strange memory leak, it appears when i try append row in sections.

func reloadData() {
        _ = tableDirector.clear()
        // Row number for selected city (for scrolling)
        var selectedCityRowNumber = 0
        
        if let cityList = cityList {
            for city in cityList {
                let isSelected = (selectedCityId == city.id) ? true : false
                let row = TableRow<SelectDepartureCityScreenTableViewCell>(item: (city, isSelected)).on(.click) { [weak self] data in
                    
                    // Handler on cell clicking
                    self?.output.didTapDepartureCity(withId: data.item.city.id)
                }
                section.append(row: row)
                
                if isSelected {
                    selectedCityRowNumber = section.numberOfRows
                }
            }
            
            tableDirector += section
            
            // Scroll to selected number
            let selectedPath = IndexPath(row: selectedCityRowNumber, section: 0)
            tableDirector.tableView?.scrollToRow(at: selectedPath, at: .middle, animated: false)
        }
    }
}

на section.append вылазит memory leak:

Как не пробовал, не могу от него избавится, есть идеи? Чуть чуть другой текст вылазит если без создания section'a делать например tableDirector += row Или отдельно создавать TableRowAction , и потом заносить его в конструктор TableRow, утечка остается просто текст утечки немного меняется

I've created a UITableViewHeaderFooterView subclass, with just a simple label for now to test things out. I've pinned the label to the edges using constraints (all in code). Then, when creating my sections in my view controller, I create a new header view, configure it with the data it needs to set some text in the label and use that as the header view in the section initializer. However, when I run the app, the header doesn't show up. If I add break points, I can see that the view is created and the correct text is set, it just isn't visible... Do I need to manually specify the height of the header? It can't use AutoLayout to figure that out for me?

I've been using TableKit in all my projects with CocoaPods (thank you!) but recently tried to use it in a new project with SwiftPM in Xcode 11 beta 7 and it wouldn't work.

I'm still getting this error and don't know how to fix it (the error message says the requirement it can't match is 2.9.0..<3.0.0, which makes no sense because there is a 2.9.0 tag and Xcode is recognising that as the latest version automatically). I've tried using version 2.8.0 as well, but get the same error.

However, with the changes I've made to Package.swift in this PR, Xcode will add the package if I use the hash of the last commit. So I think these changes did need to be made to update the package file, but there's an outstanding issue with tags that I'm not sure about.

So we don't have to use delegate approach for cells.

Cell:

class StringTableViewCell: UITableViewCell, ConfigurableCell {

  @IBAction func sendTapped(sender: UIButton) {
    invokeCustomAction("send")
  }

}

Action in controller:

let action = TableRowAction<String, StringTableViewCell>(.custom("send")) { (data) in
  doSomeNetworking()
}

Maybe it is stupid idea, but seems reasonable to me. Let me know what you think.

I noticed that while scrolling through a UIView with a lot of cells, the line seperators flicker and it doesn't look to smooth. Would it be possible to make scrolling smoother?

Hi, I noticed that there is no way to get callbacks for willDisplayHeaderView and willDisplayFooterView. Is there any plans to add this and/or suggestion on how I can access those?

Thanks, Sushant

Привет, Макс! Спасибо за твою работу. Подскажи, как сделать перезагрузки секций при постраничной загрузке. Когда делаю: tableDirector.clear() .... add section .... add rows

tableDirector += section
tableDirector.reload()

То таблица скроллится в начало.

Hi there In #42 where an interesting improvement by reusing CellType.ItemType generic. Would you add this one into repo? Can I help you with PR for that? May be @noxt want to make it first?

Hi, you created great way for work with UITableView, but I have some questions: How update some data in row with animation? How reorder row with animation?

Thanks

Hi! Congratulations for the library, really cool and useful! I need to create custom section cells, but the question is : how can I do it? I see the TableSection has a headerView property, but I'd like to know how can I customize the info inside my custom section cell and how can I reuse the section header cell.

Please tell me how to activate the ability to sort cells or sections in a table using TableKit

Do not work:

let row = TableRow<BudgetSettingsTableViewCell>(item: item)

let canMove = TableRowAction<BudgetSettingsTableViewCell>(.canMove)  { options in
                return true
}
            
        
let caneMoveTo = TableRowAction<BudgetSettingsTableViewCell>(.canMoveTo) { [weak self] (options) in
                
           print("MOVE")
 }
row.on(canMove)
row.on(caneMoveTo)

Задачка: организовать получение данных из ячеек с сохранением типизации и без тайп-кастинга. Пример прикладной задачи: Есть n ячеек с разными полями ввода и интерактива с пользователем. В необходимый момент времени, нужно собрать данные из ячеек и сохранить в БД.

Hi! I really like your framework and I found a case where it doesn't quite work. I use it for creating chat and I needed to create a context menu for the message bubble. But in this version of the framework this cannot be done. I add some methods from UITableViewDelegate to select view from cell which will be used by the context menu.

Added methods from UITableViewDelegate:

• previewForHighlightingContextMenuWithConfiguration
• previewForDismissingContextMenuWithConfiguration

Some code example how to use new functionality:

let row = TableRow<MessageTableViewCell>(item: message)
  .on(.showContextMenu) { item -> UIContextMenuConfiguration in
      
      // Here you need to path indexPath to identifier.
      return UIContextMenuConfiguration(identifier: item.indexPath as NSIndexPath, previewProvider: nil) { _ in
          
          let copyAction = UIAction(title: R.string.chat.copy(), image: R.image.messageCopy())
          let deleteAction = UIAction(title: R.string.chat.delete(), image: R.image.messageDelete(), attributes: .destructive) 
          return UIMenu(children: [copyAction, deleteAction])
      }
  }
  // !New methods!
  .on(.previewForHighlightingContextMenu) { item -> UITargetedPreview in
      
      // Choosing view to use in contextMenu
      let view = cell.messageBackgroundView ?? UIView()
  
      // Choosing parameters
      let parameters = UIPreviewParameters()
      parameters.backgroundColor = .clear
      parameters.visiblePath = UIBezierPath(roundedRect: view.bounds, cornerRadius: 10))
  
      return UITargetedPreview(view: view, parameters: parameters)
  }
  .on(.previewForDismissingContextMenu) { item -> UITargetedPreview in
      
      let view = cell.messageBackgroundView ?? UIView()
      
      // Choosing parameters
      let parameters = UIPreviewParameters()
      parameters.backgroundColor = .clear
      parameters.visiblePath = UIBezierPath(roundedRect: view.bounds, cornerRadius: 10))
  
      return UITargetedPreview(view: view, parameters: parameters)
  }

Updated:

• UITablewViewRowAction is deprecated. Replace it with UIContextualAction
• Up IPHONEOS_DEPLOYMENT_TARGET to 9.0 with new Xcode
• Update .gitignore for SPM

Hey! I made this change in my fork because I had a large dataset with many sections. Creating sections and their header views at once caused a performance and memory problem, so I added the ability to have a callback to generate the header/footer when needed. This also allows the client to cache header/footer views and reuse them.