MWPhotoBrowser keeps crushing if I use it to open more than 30 or 40 files, each of which is about the size of 2~3M. A few of them are 5M

I did see "Received memory warning." Then app crushes but XCode did not show me which _cmd caused the crushing.

I tried to call releaseAllUnderlyingPhotos before it got "Received memory warning." But that did not help.

And idea how to fix it ?

Update: sometime when I use it to open a picture of size 5M, it will just crush too.

Since this internally uses SDWebImage, which is not updated for ios8, the app crashes at "SDWebImageDownloaderOperation.h" which I could fix by synthesizing the variables @synthesize executing = _executing; @synthesize finished = _finished; It did not completely fix the issue, app still crashes at start connection method. self.connection = [[NSURLConnection alloc] initWithRequest:self.request delegate:self startImmediately:NO];

I've created the MWPhotoBrowser object in my viewcontroller as a subview from my self.view:

For 1 to 3 { [photos addObject:[MWPhoto photoWithURL:[NSURL URLWithString:@"http://farm4.static.flickr.com/3590/3329114220_5fbc5bc92b_b.jpg"]]]; }

self.photos = photos;

MWPhotoBrowser *browser = [[MWPhotoBrowser alloc] initWithDelegate:self];

browser.displayActionButton = NO; browser.wantsFullScreenLayout = NO;

[self.view addSubview:browser.view]; [self.view bringSubviewToFront:browser.view];

and, so, only show me the first image, but the scroller works fine for the three images. However if I define the MWPhotoBrowser object so:

[self.navigationController pushViewController:browser animated:YES];

The browser show me correctly the three images.

And idea how to fix it with the first method?

Sorry for my english and congratulations for this project. Thanks a lot

I just had a pull request merged in to SDWebImage, it would be nice if the Podspec would change to something like '>= 3.5' or just remove the version and allow users to override the dependency within their own Podfile. I'm not sure if this would work, but maybe '< 4.0' would be safe as well as I doubt any methods will be removed and/or deprecated until the next major release. Thoughts?

I reload the data in the grid mode but it shows the toolbar at bottom, and I think it's a bug, as I reloaded it, the grid cannot be touch anymore, can you help me to solve it? TKS

Build failed with SDWebImage 3.5.4 because SDWebImage's progress block interface was changed from ^(NSUInteger receivedSize, long long expectedSize) to ^(NSInteger receivedSize, NSInteger expectedSize). I've fixed this incompatible issue with below modification.

• Modified progress block interface
• Renew MWPhotoBrowser/Libraries/SDWebImage
• Update podspec

Hi Michael,

Is there an easy way to integrate a title for each photo, like in the facebook app? or is it something you are planning to add?

Another thing is that, when I added MWPhotoBrowser to my project, there were a few irregularities (I can't see those in your project but I couldn't figure out why they are in my app)

1. After single tap, the navigationBar disappears (as it should). but when it appears again, it appears with a gap of 20 px between the status bar the navBar
2. The status bar disappears but the space just becomes plain white.

Thanks and regards, Ashish.

Holy crap! You saved my bacon with this class. It's EXACTLY what I was looking for after struggling with the buggy Ego classes and three20's bloat.

Here are small targeted fixes for a few issues. First, it saves/restores the navbar and statusbar state in viewDidAppear: and viewWillDisappear:. This means it's safe to use with navbars with custom tint colors, not to mention it doesn't muck with your status bar except when it's onscreen. The way it's done should be safe even if you push a further view controller past the MWPhotoBrowser.

Second, it hides any toolbars or tabbars by default by setting hidesBottomBarWhenPushed to YES in -initWithPhotos:. This is usually what you want (since it looks weird to have a toolbar nested like that). Users can still override this by just setting it back to NO after they init the browser.

Finally, the toolbar now has a proper autoresize mask so it doesn't end up floating in the middle of the image (which happened to me, not sure why).

I get 17 warnings overall with xcode 7.0.1 in MWGridViewController.m and MWPhotoBrowser.m:

7x 'interfaceOrientation' is deprecated: first deprecated in iOS 8.0

8x 'UIBarMetricsLandscapePhone' is deprecated: first deprecated in iOS 8.0 - Use UIBarMetricsCompact instead

1x 'setCompletionHandler:' is deprecated: first deprecated in iOS 8.0 - Use completionWithItemsHandler instead.

1x Conflicting return type in implementation of 'supportedInterfaceOrientations': 'UIInterfaceOrientationMask' (aka 'enum UIInterfaceOrientationMask') vs 'NSUInteger' (aka 'unsigned long')

project builds ok, most of them are just "deprecated" warnings but would be nice if these could be fixed sometime anyway, who knows what will happen when the next iOS version arrives :) And it's kind of ugly to have 17 yellow exclamation marks in the project.

Thanks, Tom

I'm trying to move my project to the iOS7 SDK, but it won't compile anymore. I keep getting an error on line 292 of SDWebImage library.

UIImage *image = [UIImage sd_imageWithData:self.imageData];

unrecognized selector sent to class.

This worked in iOS 5 + 6, but broke as soon as I try to view the Photo Browser in iOS 7. Is there another library that needs to be linked in now?

I'm moving to this from the Three20 photo gallery. One thing that Three20 does (that this does not) is it has the images fit the display, be it in portrait or landscape mode. (That is, smaller images start off fitting in the available space.)

It seems to be the one showstopper keeping me from using this library. I've tried modifying MWZoomingScrollView, but I end up having problems during rotation.

Has anyone else needed this and figured it out? I'm willing to fork the code base and expose the photoImageView's content mode as a developer-controlled setting.

Thanks!

I have an old app (2 years ago) which uses MWPhotoBrowser. When I try to compile it I get this error : Import of module 'Darwin.POSIX.dlfcn' appears within function 'PSTSimulatorAnimationDragCoefficient'

This is the reference for the code: CGFloat PSTSimulatorAnimationDragCoefficient(void) { static CGFloat (UIAnimationDragCoefficient)(void) = NULL; //#if TARGET_IPHONE_SIMULATOR #if TARGET_OS_SIMULATOR #import <dlfcn.h> static dispatch_once_t onceToken; dispatch_once(&onceToken, ^{ UIAnimationDragCoefficient = (CGFloat ()(void))dlsym(RTLD_DEFAULT, "UIAnimationDragCoefficient"); }); #endif return UIAnimationDragCoefficient ? UIAnimationDragCoefficient() : 1.f; }

Thank you !

Project as cloned is missing XCTest.framework, libPods-MWPhotoBrowser_Example.a, libPods-MWPhotoBrowser_Tests.a. Local Media folder shows as missing (red in Xcode) but images inside it are OK. Build fails with "Library not found -lDACircularProgress. How can fix this?

#import "UIImage+MWPhotoBrowser.h"

@implementation UIImage (MWPhotoBrowser)

+ (UIImage *)imageForResourcePath:(NSString *)path ofType:(NSString *)type inBundle:(NSBundle *)bundle {
    return [UIImage imageWithContentsOfFile:[bundle pathForResource:path ofType:type]];
}

+ (UIImage *)clearImageWithSize:(CGSize)size {
    UIGraphicsBeginImageContextWithOptions(size, NO, [UIScreen mainScreen].scale);
    UIImage *blank = UIGraphicsGetImageFromCurrentImageContext();
    UIGraphicsEndImageContext();
    return blank;
}

@end

memory leak: [UIImage imageWithContentsOfFile:[bundle pathForResource:path ofType:type]];