Hi, Love the Library - Just having a confusing issue - I am also using your NextLevel Camera Library and Player will not display the merged or exported local clips (This also seems to be the case for other local files.) The Implementation is fine, as I have checked that both Player can display remote URL's in the view and that a standard AVPlayer can play the problematic local files. Just curious if this is a known bug or If I am missing something?

Thanks

Hi @piemonte !

I'm trying to use your lib with a TinderSimpleSwipeCards ( https://github.com/cwRichardKim/TinderSimpleSwipeCards )

This is the fastest video lib I've found.

However, when i create 16 card ( 16 Player ), the 17th is not displayed ... , and i dont know why.

But it works, if i press the home button, then i go back to the application... .

Any idea ?

Is it possible to play the videos without a gap? Also, how can I minimize memory consumption by reusing the player?

    func playVideo() {
        videoPlayerController.videoPath = self.videoPath;

        // present
        self.addChildViewController(videoPlayerController);
        playerView.addSubview(videoPlayerController.view);
        videoPlayerController.didMoveToParentViewController(self);

        // Start Video
        videoPlayerController.playFromBeginning();
        //videoPlayerController.playbackLoops = true;
    }

    func videoPlayerPlaybackDidEnd(videoPlayer: PBJVideoPlayerController!) {
        videoPlayerController.removeFromParentViewController()
        videoPlayerController.view.removeFromSuperview()

        // setup next video and call self.playVideo()
    }

This might be of some interest: https://github.com/katokichisoft/SimpleGaplessPlayer

Hey Patrick. First things first, thanks for an awesome library, really =)

Basically, I am trying to implement a Vine-like app which will have a video player inside each cell and other buttons for likes, sharing et cetera. What is your opinion about this and do you think that is this possible with the current design of the library itself?

It is hard to find which fill modes are supported when they are as strings.

self.player.fillMode = “AVLayerVideoGravityResizeAspect”

Could you please add the possible fill modes to the documentation or make them available with an enum?

I am running into performance issues in my app and I believe they are related to this library, or at least how I am using it.

I noticed that deinit is never called on the controller that implements Player!

I have tried a lot of methods for getting it to fire and nothing seems to work:

dispatch_async(dispatch_get_main_queue()) { if self.player != nil{ self.player!.pause() self.player!.stop() self.player!.view.removeFromSuperview() self.player!.delegate = nil self.player = nil } self.dismissViewControllerAnimated(true, completion: { _ in })

this helps with memory but does not completely remove the viewController. any ideas?

Hi

The Issue I am currently facing is regarding the resuming video from saved time. I am saving the time and when the user launches the same video I am seeking it to that instance of time but the video is not played from the exact time rather its played before some seconds ranging from 1 to 9.

Here is one scenario, the video saved time is 600 seconds i.e 10 mins and when the video is played, I am playing the video from saved Time interval by seeking to that time using player.seek(to: timeInterval) where timeInterval is of type CMTIME with value as 600 and then I do player.playFromCurrentTime() which will start playing the video from the time stamp I sought to But the video plays from 9:51 ie 591 seconds. Hope I will get an early response.

Thanks

Hello! I have been developing an app lately using Player😸

Problem

I found a problem that playbackPausesWhenBackgrounded property doesn't work well. And I found the cause of the problem.

When pressed the Home button, Player receives UIApplicationWillResignActive notification before receives UIApplicationDidEnterBackground notification. Current handler method for UIApplicationWillResignActive is following. Therefore Player always pauses when background.

@objc internal func handleApplicationWillResignActive(_ aNotification: Notification) {
    if self.playbackState == .playing {
        self.pause()
    }
}

Also, I read issue #166. This PR is a solution for these two problem.

Solution

Add playbackPausesWhenResigningActive and playbackResumesWhenBecameActive properties just like playbackPausesWhenBackgrounded and playbackResumesWhenEnteringForeground. And Player controls properly when receive UIApplication notifications.

Please review🙇

@piemonte I would like to be able to instantly show a preview of a video taken by the user - just like Snapchat and more impressive, Instagram stories. Somehow once a user stops capturing a video on both apps, a preview automatically starts playing in an endless loop seemingly within the same view.

How can I achieve that with Player?

This does 2 things to fix carthage installations:

• [x] Share the main Player scheme
• [x] Duplicate the Player.h umbrella file and rename each to match one of the targets

Closes #144

We have an AVAsset from our capture tool. It seems silly to write it to a file just to play it so we made a slight modification to allow setting up the player using the premade Asset.

Would love to get your feedback!

Thread 0 name: Dispatch queue: com.apple.main-thread Thread 0 Crashed: 0 libobjc.A.dylib 0x00000001b290e4ac object_isClass + 16 1 Foundation 0x00000001b2faa5f8 KVO_IS_RETAINING_ALL_OBSERVERS_OF_THIS_OBJECT_IF_IT_CRASHES_AN_OBSERVER_WAS_OVERRELEASED_OR_SMASHED + 44 2 Foundation 0x00000001b2fa8120 NSKeyValueWillChangeWithPerThreadPendingNotifications + 272 3 AVFoundation 0x00000001bce0aa14 __31-[AVPlayerItem _updateTimebase]block_invoke_2 + 180 4 libdispatch.dylib 0x00000001b28b29a8 dispatch_call_block_and_release + 24 5 libdispatch.dylib 0x00000001b28b3524 dispatch_client_callout + 16 6 libdispatch.dylib 0x00000001b28966fc dispatch_main_queue_callback_4CF$VARIANT$armv81 + 860 7 CoreFoundation 0x00000001b2b6b6bc CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE + 12 8 CoreFoundation 0x00000001b2b66590 __CFRunLoopRun + 1724 9 CoreFoundation 0x00000001b2b65ba8 CFRunLoopRunSpecific + 424 10 GraphicsServices 0x00000001bccd5344 GSEventRunModal + 160 11 UIKitCore 0x00000001b6ca13e4 UIApplicationMain + 1932 12 libswiftUIKit.dylib 0x00000001e97dc2b4 UIApplicationMain+ 45748 (::::) + 168 13 Blessed 0x000000010454dd04 static UIApplicationDelegate.main() + 56580 (:0) 14 Blessed 0x000000010454dc8c static AppDelegate.$main() + 56460 (:0) 15 Blessed 0x000000010454e110 main + 57616 (AppDelegate.swift:0) 16 libdyld.dylib 0x00000001b29ed8f0 start + 4

Hello, I added the following code in the viewDidLoad

    override func viewDidLoad() {
        super.viewDidLoad()
    
        self.player.playerDelegate = self
        self.player.playbackDelegate = self
        self.player.url = URL(string: "https://www.soundhelix.com/examples/mp3/SoundHelix-Song-15.mp3")!
        self.player.playbackResumesWhenBecameActive=false

    }

and added IBaction to play the audio using the below

    @IBAction func playButtonPressed(_ sender: UIButton) {

       // print(self.player.view)
        self.player.playFromBeginning()
    }

But unfortunatley , this is not working until I add the code below

print(self.player.view)

This will load the Player class into memory and it will unlock the isViewLoaded

How can this be fixed and the audio don't play automatically unless the user click in Play Button

Player stopped working when set up with an AVAsset downloaded from user's iCloud photo library using PHImageManager:

Error Domain=NSCocoaErrorDomain Code=257 UserInfo={NSURL=file:///var/mobile/Media/PhotoData/Metadata/DCIM/101APPLE/IMG_1858.small.MP4, NSUnderlyingError=0x2833487b0 {Error Domain=NSOSStatusErrorDomain Code=-12203 "(null)"}}

Related posts:

Swift AVAsset downloading from iCloud has no permission on iOS 14: error Code=257

Request AVAsset using iCloud PHAsset returns an AVAsset with no VideoTracks

Solution

Set up Player with an AVPlayerItem.

PHImageManager provides either an AVAsset or an AVPlayItem for a video request from user's photo library. This issue does not occur when working with an AVPlayerItem.