This pull request contains following improvements:

• Fixed error #6
• Uses languageAuto function in highlight.js to auto detect the programming languages. (This is useful if you can't determine the programming language via the file extension, eg: ".h")

Dependency injection allows one to use a custom highlight.min.js file instead of the one provided (eg. to add a custom language). Since the init parameters all have default values, this shouldn't be source-breaking.

Hey, I installed 'Highlightr' the following way:

source 'https://github.com/CocoaPods/Specs.git'
use_frameworks!
# Uncomment the next line to define a global platform for your project
# platform :ios, '9.0'
target 'My_Target' do
pod 'Quick'
pod 'Nimble'
pod 'Highlightr'
end

It's probably my mistake, but I don't know what to do. Could you help me out? Couldn't find any install instruction on the internet.

Thanks in advance!

For some reason the theme isn't setting. It's probably really easy but i can't figure it out

heres my code

let layoutManager = NSLayoutManager()
        textStorage.addLayoutManager(layoutManager)
        
        let textContainer = NSTextContainer(size: view.bounds.size)
        layoutManager.addTextContainer(textContainer)
        
//        highlightr = textStorage.highlightr
        
        self.textStorage.highlightr.setTheme(to: "hopscotch")
        
        textView = UITextView(frame: viewPlaceholder.bounds, textContainer: textContainer)
        textView.autoresizingMask = [.flexibleHeight, .flexibleWidth]
        textView.autocorrectionType = UITextAutocorrectionType.no
        textView.autocapitalizationType = UITextAutocapitalizationType.none
//        textView.textColor = UIColor(white: 0.8, alpha: 1.0)
//        textView.inputAccessoryView = textToolbar
        viewPlaceholder.addSubview(textView)
        
        let code = try! String.init(contentsOfFile: Bundle.main.path(forResource: "index", ofType: "html")!)
        textView.text = code

I am having a problem getting this to work with Swift 4 in Xcode 9. Can anyone confirm that has yet to be updated to support compilation for those versions?

This seems like a great idea!

Thanks.

This update changes the API a little bit, which I mentioned in CHANGELOG.md. Because this isn't backwards compatible I bumped the version of the podspec to 1.0.0.

The pod lint passes without warnings, and the examples appear to work well. Let me know what you think, or if you'd like me to make any changes.

Thanks!

Hi Raspu, Thank you for your amazing work. I have a question: is it possible to create a custom theme? Or in another way, is it possible to change the font and the color of the text? Because I have read something about it on other issues but I haven't understood it very well Thank you for your patience

How would u put highlightr in a collection view? my idea is that you can give a live preview of a document however due to the collectionview having to dequeue cells the entire code highlighting is re rendered and takes up way too much system resources. Is there a more efficient way to do this? Also, isit possible to take a snapshot of the view of the highlighted code, for now the snapshot captures the text only and not the code.

Some of the code is incompatible with swift 4.2 Happy to help with some direction, I've never worked in this codebase though. Is anyone working on this?

Build Failed
	Task failed with exit code 65:
	/usr/bin/xcrun xcodebuild -project /Users/zly/Project/test/BearCapture/Carthage/Checkouts/Highlightr/Highlightr.xcodeproj -scheme Highlightr-iOS -configuration Release -derivedDataPath /Users/zly/Library/Caches/org.carthage.CarthageKit/DerivedData/10.2.1_10E1001/Highlightr/2.1.0 -sdk iphoneos ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive -archivePath /var/folders/sk/8_qnvmt550d0sr14czhv4k4h0000gp/T/Highlightr SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO CLANG_ENABLE_CODE_COVERAGE=NO STRIP_INSTALLED_PRODUCT=NO (launched in /Users/zly/Project/test/BearCapture/Carthage/Checkouts/Highlightr)

This usually indicates that project itself failed to compile. Please check the xcodebuild log for more details: /var/folders/sk/8_qnvmt550d0sr14czhv4k4h0000gp/T/carthage-xcodebuild.nLipft.log

I'm using macOS. I've noticed that when setting the writing direction in a NSTextView by right-clicking, and choosing Writing Direction > Right to Left, whenever the text changes the direction gets un-set, but when all text is removed, the cursor correctly appears on the right hand side of the text view.

I had a dig in to the code and believe this is happening in the highlight(_ range: NSRange) method of the CodeAttributedString class. I'm not sure exactly what is causing it, but think it has to do with the ranges being updated.

For example

If highlight() is called with the range {0, 1}, this represents a location of 0 and length of 1. The problem is that if the writing direction is Right to Left, and a single character is typed, then the range would be the exact same {0, 1}, since it's in location 0 and length 1, but this time from the right hand side of the text view.

As a result, whatever is typed in the Right to Left direction gets updated correctly, but gets put in the left hand side of the text view as if the direction is Left to Right.

I think fixing this may be fairly easy, as it should just require getting the writing direction and setting again somewhere, but it may not be trivial if some calculations need to be done around the range.

Below is a simple demo

I'm trying to build my app with the latest Xcode 12.5 beta 3 and I'm getting a build error due to this code in HTMLUtils.swift

 class func decodeNumeric(_ string : String, base : Int32) -> Character? {
        let code = UInt32(strtoul(string, nil, base))
        return Character(UnicodeScalar(code)!)
    }

I believe it's from the stroul() call.

The error is:

Undefined symbols for architecture arm64:
  "Swift._ArrayBuffer._copyContents(initializing: Swift.UnsafeMutableBufferPointer<A>) -> (Swift.IndexingIterator<Swift._ArrayBuffer<A>>, Swift.Int)", referenced from:
      generic specialization <serialized, Swift._ArrayBuffer<Swift.Int8>> of Swift._copyCollectionToContiguousArray<A where A: Swift.Collection>(A) 
-> Swift.ContiguousArray<A.Element> in HTMLUtils.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Does anyone have a solution for this or know a workaround?

I was updating my iOS app to have a minimum deployment target of iOS 13 and noticed that this library used a couple of deprecated APIs. I wanted to be able to pitch in and help modernize the code while still providing backward compatibility to existing users. In doing so, I left the majority of the code in place while simply wrapping the old/new API uses in #available checks. Let me know if you'd like me to make any changes to my approach (refactoring out to helpers, etc.). Thanks!

I did verify these changes locally in the iOS app I'm working on. Please let me know if there are any other verifications that you'd like to see. I'll attach a screenshot showing that the rendering doesn't change between iOS 12 and iOS 13.

Hi this library is cool.. but i got problem when i want to make NSTextview scrollable when the the text is over the height of textview. how to make it possible? I have done many experiments but it still hasn't worked

thanks

It would be nice if there would be a way to manually trigger a rehighlight from the auto-highlight feature (CodeAttributedString). Essentially, on top of the highlighting, I am using a yellow highlighter to display certain text (like a Find feature). However, the only way to remove this highlighting is when a user start typing, so that it re-highlights the text.

If anyone knows a simple work around that would be great. Calling processEditing causes an error because no edits were actually made I tried to reset the theme (setting it to itself), but to no luck

In order to allow us to use Highlightr in app extensions, the APPLICATION_EXTENSION_API_ONLY flag needs to be set to YES. There doesn't seem to be a technical reason to keep this flag set to NO.