Hello, in my app I have very simple coordinator, inited from SceneDelegate. When I try to dismiss modal window "CitySelectView" by router?.dismiss() I got "fatalError("no children, cannot dismiss?!")"

What have I done wrong?

final class WallsListCoordinator: NavigationCoordinatable {
    var navigationStack: NavigationStack = NavigationStack()
    
    enum Route: NavigationRoute {
        case openCalculator(id: Int?)
        case openCatalogue
        case openCitySelect
    }
    
    func resolveRoute(route: Route) -> Transition {
        switch route {
        case .openCalculator(let id):
            return .push(
                AnyView(
                    Resolver.resolve(CalculatorFormView.self, args: id)
                )
            )
        case .openCatalogue:
            return .push(
                AnyCoordinatable(
                    CatalogueCoordinator()
                )
            )
            
        case .openCitySelect:
            return .modal(
                AnyView(
                    NavigationView {
                        Resolver.resolve(CitySelectView.self)
                    }
                )
            )
        }
    }

First of all, thank you for creating a great library.

I'm using this library to implement Deep-link.

Deep-link need to be able to work on any screen, so we'll need a coordinator that can be used for any screen. Is this possible?

I'd appreciate it if you could let me know if there's any other way besides the one I said.

Thanks.

I have a coordinator and three screens:

@ViewBuilder
func makeStart() -> some View {
    TimetableView()
}

@ViewBuilder
func makeJoinMeeting() -> some View {
    JoinMeetingView()
}

@ViewBuilder
func makeMeeting() -> some View {
    MeetingView()
}

While on the third view I'm trying to .popToRoot in order to transition to the timetable. And sometimes the second view shows for a moment during the transition. Did anybody encounter this?

Hello again! I wold like to pop back inside of coordinator. Is there any way to implement something like this?

func makeView() -> some View {
  viewModel.$switchSearchType
      .sink { [weak self] _ in
          self?.pop() // no such method
      }
      .store(in: &cancellables)
...
    return View()
}

Is there any way to create a custom TabCoordinatable? What I want is basically the function of menu changing, but I don't want the coordinator's view to be a tab view, but a custom menu instead.

I had a look at the source and tried to create my own protocol, but I'm getting several error messages stating that the children.dismissalAction is unaccessible due to internal protection level.

Any way to implement this?

This is a follow up to https://github.com/rundfunk47/stinsen/issues/5

As I described in the issue I use Resolver for injecting my dependencies. Since using it directly within Resolver is messy I created a RouterStore which kind of copies the SwiftUI Environment behavior. It allows to use the Router without directly passing them from via the View, so there is no tight coupling.

I created a new protocol called RouterIdentifiable which has to be implemented optionally by a Coordinator. This way the code is 100% backward compatibly.

It would be cool if you like my solution our if we could find a similar solution enabling better ViewModel usage :blush:

Hi! When I use push, I have empty view with back Botton on toolbar. But when I use .modal or .fullScreen - everything is ok

final class AccountCoordinator: NavigationCoordinatable {
    let stack = Stinsen.NavigationStack<AccountCoordinator>(initial: \AccountCoordinator.start)
    @Root var start = getAccount
    @Route(.push) var userProfile = getUserProfile

    @ViewBuilder func getAccount() -> some View {
        AccountView()
    }

    @ViewBuilder func getUserProfile() -> some View {
        UserProfileView()
    }
}

final class TabCoordinator: TabCoordinatable {
    lazy var child = TabChild(startingItems: [
        \TabCoordinator.dashBoards,
        \TabCoordinator.results,
        \TabCoordinator.bookings,
        \TabCoordinator.accounts
    ], activeTab: 0)

    @Route(tabItem: dashBoardTab) var dashBoards = getLocations
    @Route(tabItem: bookingTab) var bookings = getBooking
    @Route(tabItem: accountTab) var accounts = getAccount
    @Route(tabItem: resultsTab) var results = getResults

    let dashBoard: DashCoordinator
    let booking: BookingCoordinator
    let account: AccountCoordinator
    let result: ResultsCoordinator

First of all, thank you for providing such a simple and elegant way to implement coordinator pattern with SwiftUI, I have been sniffing around about this topic and your approach is the best I found.

I installed this library with Swift Package Manager very easily and had zero issues when using it. But my project also depends on some other third party libraries that do not support SPM, so I also had to use CocoaPods to install those. And now, for some Apple M1 chip and arm64 compilation reason, I couldn't make the project compile for both CocoaPods and SPM dependencies, so I am thinking about dropping SPM and use CocoaPods only, because I know how to make it work with CocoaPods.

So here we are back to my original question: do you currently or plan to support installation with CocoaPods? I tried searching stinsen on CocoaPods.org but could not find it. Also, if you can add a Installation section to your readme, it would definitely help some devs to use your framework more easily.

Thanks again, for sharing this great library!

Hello, thank you for providing a good coordinator pattern library.

We tried to make the TabBar Button move to the corresponding tabView root when pressed, and move to the top of the scrollView when clicked again, but we found that tapGesture does not work for the TabBar Button provided by stinsen.

@ViewBuilder func makeFirstTab(isActive: Bool) -> some View {
    VStack {
        Image("icon")
        Text("TabItem")
    }
    .onTapGesture {
        // Not working
    }
}

I'm looking for a way other than how to create a Custom TabBar to save resources and I was wondering if there is a better way inside the library?

Thanks

I have the following scenario: i want to pass parameters to a function that returns a view:

@ViewBuilder
    private func makeMailComposeVC(recepients: [String], capturedImage: UIImage, completion: @escaping Action) -> some View {
        MailComposeViewController(toRecipients: recepients, capturedImage: capturedImage, didFinish: completion)
    }

but here it says: "No exact matches in call to initalizer"

@Route(.modal) var mailCompose = makeMailComposeVC

I am using Stinsen on SwiftUI to navigate from one view to another.

does exist way to remove previous stacked view?

View A -> View B -> ViewC -> View D go back ---> View B (ViewC should be removed from the stack so on back i should go to viewA again.

NavigationStack has value, but 'value' is inaccessible due to 'internal' protection level.

Hi! I've adapted example app to handle deeplink, but app crashes when trying to get current coordinator:

final class AppCoordinator: NavigationCoordinatable {
    var stack: Stinsen.NavigationStack<AppCoordinator>

    @Root var unauthenticated = makeUnauthenticated
    @Root var authenticated = makeAuthenticated

    init() {
        let user = User() // obtaining user from persistent store
        stack = NavigationStack(initial: \AppCoordinator.authenticated, user) // this is also handled by auth state listeners
    }
    
     func makeUnauthenticated() -> NavigationViewCoordinator<UnauthenticatedCoordinator> {
        NavigationViewCoordinator(UnauthenticatedCoordinator())
    }

    func makeAuthenticated(param user: User) -> NavigationViewCoordinator<MainCoordinator> {
        NavigationViewCoordinator(MainCoordinator(user: user)) // MainCoordinator is a simple navigaion view coordinator
    }

    func handleDynamicLink(_ url: URL) {
        guard let coordinator = self.hasRoot(\.authenticated) else { // <-- Crashes here.  self.isRoot(\.authenticated) causes the same crash
            return
        }
    }
}

Crash in NavigationCoordinatable.swift, line 661, col 21

Thread 1: Fatal error: Unexpectedly found nil while implicitly unwrapping an Optional value

Printing description of route: <ReferenceWritableKeyPath<AppCoordinator, Transition<AppCoordinator, RootSwitch, User, NavigationViewCoordinator>>: 0x280687280> Printing description of inputItem: nil

((input: App.User, comparator: ())?) inputItem = nil Printing description of self: <AppCoordinator: 0x283d59500>

App and coordination logic works perfectly, but this check on AppCoordinator level causes the crash.

It looks that unwraping var root: NavigationRoot! from NavigationStack (NavigationStack.swift, line 29) causes the crash. What is the reason for this crash and how to solve it?

Stinsen (2.0.7) MacOS 12.6, XCode 14 Release, iOS 15-16

Hello,

I encountered an AppCrash in the "coordinator" getter of NavigationRouter due to the force cast on the type.

When bringing back the App from background I sometimes get: #6 (null) in swift_dynamicCast ()

I am calling it this way (after unwrapping the router safely): _ = overviewRouter.coordinator.customPopToRoot()

Stacktrace:

0 (null) in __pthread_kill () 6 (null) in swift_dynamicCast () 7 0x000000010325a530 in NavigationRouter.coordinator.getter () 8 0x0000000102f8d720 in specialized NavService.goToOverviewRoot() 9 0x000000010370ab20 in LifecycleService.reactOnStatusChange() 10 0x000000010370a92c in LifecycleService.updateTo(state:) 11 (null) in protocol witness for LifecycleServiceType.updateTo(state:) in conformance LifecycleService () 12 0x00000001030183dc in App.handleAppState(_:) 13 (null) in partial apply for closure 2 in closure 1 in App.body.getter ()

Most likely because of the force cast of the weakReference in NavigationRouter.coordinator. Did you ever encounter this problem or have an idea how to solve it (other than making coordinator optional)?

Best regards Steffen

using stinsen 2.0.9 and try to move to previous page from current stack with focusFirst. Debug shows that stack has been changed internally but displayed page doesn't changed. By the way method popToRoot works well - returns to the begin of the stack.

Hi everyone,

First of all, thank you for the great framework.

I have a question. Is it possible to present the modal view from tabbar item? If yes, how can I do it? In the app I'm working on, I need to force users to log in before they can reach a specific tabbar item.

We have implemented StateObject into an app, as shown in the example below and we receive a lot of issues with the Coordinator such as crashes. The problems start to arise as soon as the StateObject is changed (due to updates). During debugging I have found out that the RouterStore holds a lot of Coordinators twice or three times and I guess this is the reason for the issues. However, I was not able to yet to create a minimal example for easier debugging of this issue.

struct TestApp: App {
    @StateObject var manager = Manager()
   
    var body: some Scene {
        WindowGroup {
            NavigationViewCoordinator(
                MainCoordinator()
            )
            .view()
            .environmentObject(manager)
        }
    }
}