Hi, this is not an issue, but not sure where to request a new feature that Dropbox's "short-lived" token.(https://dropbox.tech/developers/migrating-app-permissions-and-access-tokens) The current not expired token is deprecated and will expire Sep. 2021.

Thanks for making efforts to make this api for Objective-C. Has been using this lib for a long while.

Thanks!

VC

I'm about to use TJDropbox for my app and one of the things I will need is ability to retrieve the amount of free space on user's Dropbox. I implemented the get_space_usage API call, although not without additional changes.

Methods for creating request parameters serialize a nil parameter dictionary as an empty POST body, which is probably not valid JSON content, because by the documentation, get_space_usage requires a "null" value, which definitely is. I could pass an [NSNull null] parameter, but request methods in the library accept a <NSString *, NSString *> dictionary.

So, we could either change the [TJDropbox parameterStringForParameters] method to pass "null" in case of a nil dictionary (which I did), or change all request methods to accept an id parameter and let NSJSONSerialization serialize anything (which I could do, but don't know if such change has any chance of being accepted for a PR).

What do you think?

Hello Tim,

thanks a lot for your efforts in adding support for the new short lived tokens and refresh tokens.

It seems however, that TJDropbox's authentication using the iOS Dropbox app doesn't support refresh tokens yet.

I compared what TJDropbox is doing with what the official Dropbox Objective-C SDK is doing, and could enable refresh tokens using TJDropbox and app auth using two simple modifications.

This is an example request from TJDropbox:

dbapi-2://1/connect?k=9gg2zssmv7XXXXX&s=&state=oauth2code:6Y4vUgu9rIRJbx890ry3mwp2ryhwP0u0FOsaZmMrnx8:S256:&extra_query_params=code_challenge%3D6Y4vUgu9rIRJbx890ry3mwp2ryhwP0u0FOsaZmMrnx8%26code_challenge_method%3DS256%26response_type%3Dcode

This is an example request from the official Dropbox SDK:

dbapi-2://1/connect?k=9gg2zssmv7XXXXX&s=&state=oauth2code:kiCBUKN79D3O3hGI_eR0y7zikhTW0R7vY_dD-DeuLf4:S256:offline:account_info.read&extra_query_params=code_challenge%3DkiCBUKN79D3O3hGI_eR0y7zikhTW0R7vY_dD-DeuLf4%26code_challenge_method%3DS256%26token_access_type%3Doffline%26response_type%3Dcode%26scope%3Daccount_info.read

The notable changes are:

• the state parameter adds "offline" after "S256" (See tokenAccessType when the state parameter is created in +[DBOAuthPKCESession createStateWithPkceData:scopeRequest:tokenAccessType:]
• There is an additional extra_query_params parameter: token_access_type=offline

I added both changes to the URL generated in the -[TJDropbox dropboxAppAuthenticationURLWithClientIdentifier:codeVerifier:] method, and could successfully get an access token with a refresh token.

(Actually, just adding "offline" to the state parameter seems to work, but it's better to do the same as the official SDK and do both changes).

Here is a quick overview of various changes I made:

• make TJDropbox more thread-safe by using serial operation queues
• download: allow overwriting existing files
• upload: allow overwriting existing files
• add support for upload progress block for chunked (large) uploads
• increase large file upload chunk size to 10 MB - same as used by the official Dropbox Objective-C SDK
• add isKindOfClass checks when accessing parsed response objects to prevent crashes if the server returns unexpected values
• Add support for default redirect url for SFSafariViewController-based authentication: it is not necessary (anymore?) to set up a web site that redirects to an app scheme. Instead, you can just directly use the "db-CLIENTIDENTIFIER" app scheme as the redirect URL for SFSafariViewControlle-based auth. The official Dropbox Objective-C SDK does the same. Use +tokenAuthenticationURLWithClientIdentifier: method to create the auth url and +accessTokenFromURL:withClientIdentifier: to parse the response.

You can find more details in the commit messages. It's up to you if you want to merge these changes, but they were necessary so I could use TJDropbox in my app Textastic.

This is a starter .podspec file for CocoaPods support

Left to do

• [ ] get setup with CocoaPods Trunk service (to publish/make it public) @timonus https://guides.cocoapods.org/making/getting-setup-with-trunk.html
• [x] update README

iPad running iOS 9.3.2 and iPhone running iOS 9.3.2 on both Wi-Fi and cellular networks

IPv6 network， an error was shown when we attempted to sign in with Dropbox.

“The operation couldn't be completed. (TJDropboxErrorDomain error 0.) ”

    NSString* path = [NSHomeDirectory() stringByAppendingPathComponent:@"Library/Dropbox 使用入门.pdf"];
    NSLog(@"%@", path);
    [TJDropbox downloadFileAtPath:@"Dropbox 使用入门.pdf" toPath:path accessToken:self.accessToken completion:^(NSDictionary *_Nullable parsedResponse, NSError *_Nullable error) {
        dispatch_async(dispatch_get_main_queue(), ^{
            if (error) {
                NSLog(@"%@ ", [error localizedDescription]);

// self.outputTextView.text = [error description]; } else { NSLog(@"OK "); } }); }];

[TJDropbox downloadFileAtPath:@"Dropbox 使用入门.pdf"

or

[TJDropbox downloadFileAtPath:@"/Dropbox 使用入门.pdf"

All wrong

The operation couldn’t be completed. (TJDropboxErrorDomain error 0.)

Current ways you can auth in order of preference are

• Dropbox app
• ASWebAuthenticationSession
• SFAuthenticationSession
• SFSafariViewController
• Safari app
• TJDropboxAuthViewController (should be considered deprecated as it relies on UIWebView.

Would be nice if there wasn't as much manual work you had to do to make these all "just work" correctly.

I had a user with dropbox files containing the cyrillic alphabet. (i.e. "/Океан Эльзи - Без бою.txt")

This would fail using the TJDropbox code out of the box. I found a way to ascii-escape these (well, I also see you have a asciiEncodedString: method), but perhaps these should be on every method that has path as an argument? The out-of-the-box code for parameterString... will not ascii-encode these.

I'm wondering what you'd like to do. You know your code better than I do, so I thought I'd consult first before implementing a definitive fix. I made it work for my app, but it would be nice to get a universal solution in there...

Use the following authentication options to use native app auth with refresh tokens:

[[TJDropboxAuthenticationOptions alloc] initWithGenerateRefreshToken:YES bypassNativeAuth:NO]

https://github.com/timonus/TJDropbox/pull/21/commits/1f198dd6d4e8202e183ce4b5e4068b6828bb8f54 changed how one can auth with SFSafariViewController, the docs need to be updated.