Ticket

Required for Vimeans only VIM-4496

Ticket Summary

To support DRM, we need to directly access the player asset and set its delegate. See changes to playVideoWithURL: captured here: https://github.vimeows.com/MobileApps/Vimeo-iOS/pull/938/files

As a result, we're now using setAsset: instead of setURL:. This left local playback unaffected. But in airplay mode, the player never received a status change that the player item was ready to play. (If a video was already playing, it could be air played, but the next video would not play).

It's not clear why this was happening, but the way in which we create the asset seems like it could be the culprit. The init method we used specified that we should pre-load "tracks". This in effect excluded "duration" as a key to be preloaded. The docs say:

"Unless you omit @"duration" from the array of asset keys you pass to 
+playerItemWithAsset:automaticallyLoadedAssetKeys: or -initWithAsset:automaticallyLoadedAssetKeys:, 
the value of this property will accord with the properties of the underlying AVAsset 
and the current state of playback once the receiver becomes ready to play."

It's interesting that the most basic player Item creation method playerItemWithAsset (which is what this PR suggests we use) does not exclude the duration key. The docs say that calling playerItemWithAsset is equivalent to +playerItemWithAsset:automaticallyLoadedAssetKeys: and passing @[ @"duration" ] as the value of automaticallyLoadedAssetKeys.

Also, it's not clear if we necessarily need to pre-load tracks because it seems we don't need to access them outside of the context of playback. The docs say

If you need to access information about the asset before you enqueue it for playback, 
you can use the methods of the AVAsynchronousKeyValueLoading protocol to load 
the values you need. Alternatively, AVPlayerItem can automatically load the 
needed asset data for you by passing the desired set of keys 
to its init(asset:automaticallyLoadedAssetKeys:) initializer. When the player item is ready 
to play, those asset properties will have been loaded and are ready for use.

From an older WWDC talk - 2014

If you anticipate the use of a particular property later in your application, 
you can still request all of them together using loadValuesAsynchronouslyForKeys and 
completionHandler. You can parse in an array of keys which AVFoundation will load together and 
your completionHandler is called once you are done loading these properties. 
You no longer have to load tracks before playback begins. 
This has changed since the last time we talked about best practices. 
In fact, this has changed since iOS 5. You really only need to load those properties you 
would directly use in your application.

Since I couldn't find a clear link between our playback flow, airplay, and the creation of assets, the snippets above were meant to show it's likely not necessary to preload tracks, it could be disrupting something in our current playback flow and we can adopt the simpler method.

Implementation Summary

Updated the init method used for creating our AVAsset.

How to Test

• Confirm local playback works as expected.
• Enable airplay and connect to an Apple TV. Confirm playback works normally on external screen and "streaming to airplay" UI is on your device. Confirm you can tap a new video while already in airplay and playback is normal. Note, it's normal for the device to appear as though it is intermittently disconnecting and reconnecting as the user is switching videos.

From docs it is unclear where I should get reference on MP4 file. I don't want to use https://player.vimeo.com/video/<video_id>/config to get this information and have strong believe what there is more preferable and legal ay to get it.

How do I get path to MP4 which can be used with this player?

Best regards, Sergey

Hi, I have a list of vimeo, my flow is: for vimeo in list { fetch vimeo direct url play vimeo with VIMVideoPlayer }

I have a VIMVideoPlayer to reuse But I don't known how to switch to other url? I try this, but not work:

• (void)playVideoVimeo: (NSURL*)url { [_vimeoPlayerView.player setURL:url]; [_vimeoPlayerView.player play]; }

I tried to new 1 view for every video but I got other issue: the audio go first 2s after then is image. So with video about 2s, I don't see anything, only hear the sound.

I use xcode 6.4 simulator 8.4

Thanks.

Ticket

https://vimean.atlassian.net/browse/VIM-4419

Ticket Summary

This implements UI states for DRM-specific errors in the player.

Implementation Summary

Since NSErrors from a failed AVAssetResourceLoadingRequest are propagated back to our video player as an underlying error, I added steps to select the appropriate error object in our status observer KVO.

It's kind of a bummer that an NSObject can come from three different places (Who is to say which one we want to forward on?) but this seems like a reasonable selection process.

Associated PR: https://github.vimeows.com/MobileApps/Vimeo-iOS/pull/960

How to Test

See associated PR.

Ticket

Required for Vimeans only VIM-3864 See last comment by Dina

Ticket Summary

See companion PR

Implementation Summary

Check if seek to zero was successful before executing remainder of completion block

How to Test

See companion PR

Ticket

No ticket

Ticket Summary

Source files were being compiled straight in the example project. Is there an alternative?

Implementation Summary

This pull request adds a framework project to the workspace so that the library can be compiled and worked on in the context of the framework project. And then consumed in the example project.

How to Test

Open the workspace.

Build the framework project. Confirm there are no warnings or errors.

Build and run the example project. Confirm there are no warnings or errors. Confirm it functions properly in the simulator and on device.

There's no documentation on developer.vimeo.com that explains that video file information is only included in the response object for a video if the account making the request is a Vimeo Pro account. That documentation is apparently in the works (cc @Dashron).

In an effort to stem confusion, this PR adds info related to this to the README.

Hi, I want to add audio selection in the player without modifying your code. What would be the clean way to approach this.

PS: I know how to change the audio via selectMediaOption. I just want to know how you guys would approach this. Would you place the code in the ViewController, in the delegate videoPlayerViewIsReadyToPlayVideo? or is there a cleaner approach?

PPS: I don't have deliverables, I'm just trying to learn how to make simple and clean code. And I like your approach.

Ticket

https://vimean.atlassian.net/browse/VIM-4503

Ticket Summary

The current play logging events require session_time to be sent with the exit and play events. session_time is the total time the user has spent watching the video with the video actually playing. This ticket is for adding that parameter to those requests. Play logging spec here:

https://docs.google.com/document/d/1B4FPhSK_TECdygjgRhGLFx9vZUeg-9zePOqV5zD5RF0/edit#

This is a temporary implementation since we'll be overhauling our play logging with the new, unfinished spec that will be built by the API in the next few sprints.

Implementation Summary

Moving the TimeUpdateInterval constant to the header. This makes sense since as a user of this class, you can enable and disable time updates. It makes sense that you should be able to see at what interval these updates fire.

Also changed the name of this constant from TimeObserverInterval to TimeUpdateInterval to match the enableTimeUpdates and disableTimeUpdates function names.

Associated PR: https://github.vimeows.com/MobileApps/Vimeo-iOS/pull/951

How to Test

N/A

Ticket

https://vimean.atlassian.net/browse/VIM-3520

Ticket Summary

The "Connected to AirPlay" overlay is displayed when in AirPlay mirroring mode, not just when AirPlay streaming mode.

Implementation Summary

Added self.player.usesExternalPlaybackWhileExternalScreenIsActive = YES;, which causes the player to switch to AirPlay streaming when the device is AirPlay mirroring when playing a video.

How to Test

See ticket.

Ticket

https://vimean.atlassian.net/browse/VIM-3653

Ticket Summary

Add a demo project to VIMVideoPlayer.

Implementation Summary

Added a demo project for iOS that implements initializing a video, play/pause, and scrubbing.

Issue Summary

The page https://developer.vimeo.com/api/libraries still references this repo but this repo states that it's deprecated.

Reproduction Steps

Visit https://developer.vimeo.com/api/libraries which links here. See that it is deprecated.

Expected Behavior

I expect https://developer.vimeo.com/api/libraries to point to the current recommended library. https://github.com/vimeo/PlayerKit

Actual Behavior

Linked here instead of to https://github.com/vimeo/PlayerKit

Issue Summary

A brief but thorough description of the issue. vimeoPlayer.frame = CGRect(x: 0, y: 0, width: UIScreen.main.bounds.width, height: self.videoPlayer.bounds.height) vimeoPlayer.delegate = self self.videoPlayer.addSubview(vimeoPlayer) vimeoPlayer.player.disableAirplay() if let url = URL(string: "https://player.vimeo.com/video/12765955") { vimeoPlayer.player.setURL(url) } vimeoPlayer.player.isLooping = false vimeoPlayer.setVideoFillMode(AVLayerVideoGravity.resizeAspectFill.rawValue) vimeoPlayer.player.player.play()

Above Code, I'm using to play Vimeo Video. When is ready to play I'm getting error Message

Video player Status Failed: player item error = Error Domain=AVFoundationErrorDomain Code=-11828 "Cannot Open" UserInfo={NSLocalizedFailureReason=This media format is not supported., NSLocalizedDescription=Cannot Open, NSUnderlyingError=0x1c0856680 {Error Domain=NSOSStatusErrorDomain Code=-12847 "(null)"}}

I check with URL link on Browser is fine it's working on the browser. kindly do needfully

Reproduction Steps

Detailed steps to reproduce the issue.

Expected Behavior

What do you expect to happen as a result of the reproduction steps?

Actual Behavior

What currently happens as a result of the reproduction steps?

Issue Summary

A brief but thorough description of the issue.

Reproduction Steps

Detailed steps to reproduce the issue.

Expected Behavior

What do you expect to happen as a result of the reproduction steps?

Actual Behavior

What currently happens as a result of the reproduction steps?

Check dependencies
“Use Legacy Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.```