Currenlty delegate recevies wrong values, when users taps on selected row in picker. Delegate receives data for country 0, but app expects to see data for country actually tapped (in selected row)

After updating to 1.7.3 I got this crash when building my app in release mode: Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Could not load NIB in bundle: 'NSBundle </var/containers/Bundle/Application/3232DF58-CCEB-491A-8387-7100A0D31587/fototax.app/Frameworks/CountryPicker.framework> (loaded)' with name 'CountryView''

Hello.

I am trying to integrate a library using the Swift Package Manager from the master branch, everything looks good, but there is no way to access the source files for CountryPicker, only for the dummy CountryCode struct.

This library is really awesome. However there is an issue with using it with Carthage. This branch attempts to fix that, however I haven't tested it with Cocapods nor are the main line tests currently passing either.

The way you make a library compatible for Carthage is simply by providing shared .framework targets in a project file. You already have a .framework target in your project file but it doesn't link to any of the source or bundle resources so this won't work. Additionally having a Cartfile in your framework / module is for including sub dependencies for your project. The Cartfile in the current master includes a recursive include of itself which stops Carthage from working in the first place. I don't see any dependencies in your project so you don't need a Cartfile.

My branch is working for Carthage as we speak in Xcode 10.2.1 and Swift 5. If you want to test how a package works in Carthage check the documentation and make a simple test project and add your module to a Cartfile and see how it all works.

E.g.

# Cartfile
github "madhavajay/CountryCode" "carthage-fix"

Then run:

$ carthage update --platform iOS

If there are issues, you can simply modify the contents of the Checkout folder until its working and retry with:

$ carthage build --platform iOS

Regarding additional platforms all you need to do is add additional .framework targets for each platform in the Xcode Project file and ensure they have the same "Product Name" aka "CountryPickerSwift".

What I would suggest is possibly refactoring the whole project to simplify a few things so you can support all 3 package managers together.

I helped the author of GEOSwift with this recently and he has a nice example of a project that supports all three easily. https://github.com/GEOSwift/GEOSwift

Unfortunately it's likely to be a few more years before SPM is the only package manager in use.

Let me know if you have any questions about any of this stuff.

Inside

fileprivate func loadViewFromNib() -> UIView {
        let bundle = Bundle(for: type(of: self))
        let nib = UINib(nibName: String(describing: type(of: self)), bundle: bundle)
        let nibView = nib.instantiate(withOwner: self, options: nil).first as! UIView
        
        return nibView
    }

This error occures:

*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Could not load NIB in bundle: 'NSBundle </var/containers/Bundle/Application/F064407E-A951-47C1-8C3C-AD1938DD885F/MyApp.app> (loaded)' with name 'CountryView''

---

• Fix SPM support to explicitly include CountryPicker.bundle as a resource, otherwise countryCodes.json may not be included. Because of the guard let on line 188 of CountryPicker.swift, failure to load the JSON silently fails and returns an empty Set.
• Add conditionals to use Bundle.module when compiled with SPM.
• Update Podspec for 1.8.3 and regenerate lockfiles. I would request that this be tagged as 1.8.3 at the same time, so that SPM will see the recent SPM-specific commits for that version, instead of having to just follow master.

When adding this repo to swift package manger, I get the following error : Failed to resolve dependencies because CountryCode >=1.4.3 contains incompatible tools version and root depends on CountryCode 1.8.2..<1.9.0, version solving failed.

Hi

thank you for great repo. i added this repo to my app, but i found mini bug.

i just picking to list and touch current selected object. wow selected first country.

The .podspec does not define a swift version for the pod which causes the above error to appear when compiling a project which is importing CountryCode via cocoapods. You should consider adding the following to the .podspec to fix this issue:

s.swift_version = '4.0'

Hey,

I have started using Country Picker and I have encountered two issues. I hope we can solve this.

1. I am filtering countries in pickerView, so I have got Austria, Germany, Poland, Switzerland. Is there any way I can change order of these items? I guess it's preset alphabetically. I would like to begin with Germany.
2. When I tap on a particular country in the row, I get phoneCode from the first item in that array. I mean, I have swiped on Switzerland, it gives me +41 as it should and when I tap on that Switzerland row I get phoneCode from Austria (+43). Same with others countries beside Austria which is first in that array.

Here is my code:

func countryPhoneCodePicker(_ picker: CountryPicker, didSelectCountryWithName name: String, 
     countryCode: String, phoneCode: String, flag: UIImage) {
    countryCodeButton.setTitle(phoneCode, for: .normal)
    countryImage.image = flag
}


 func initPicker() {
    let locale = Locale.current
    guard let code = (locale as NSLocale).object(forKey: NSLocale.Key.countryCode) as! String? 
   else {
        return
      }

    countryPicker.displayOnlyCountriesWithCodes = StringConstants.codes.countryCodes
    countryPicker.countryPickerDelegate = self
    countryPicker.showPhoneNumbers = true
    countryPicker.setCountry(code)
}

In my project I need to customise an appearance of the picker views' rows, specifically colour of labels and the background colour. I've added a new struct, called CountryViewTheme. So now it's possible to change selected appearance attributes using following construction:

let theme = CountryViewTheme(countryCodeTextColor: .white, countryNameTextColor: .white, rowBackgroundColor: .black, showFlagsBorder: false)
countryPicker.theme = theme