This is most likely an issue with Process() and bash or zsh unable to identify homebrew commands on some computers. Will need to see how well this goes with an exectuable. Meanwhile I'll experiment with Xcode to see what is the best way.

I'm getting command not found when I try to run the exact same code on AppDelegate,

bash: mpv command not found

On Big Sur 11.3, attempting to launch the program results in an immediate crash.

Exception Type: EXC_BAD_INSTRUCTION (SIGILL) Exception Codes: 0x0000000000000001, 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY

Heyoooo ! Another pull request loool

This time, i focused on adding a native player to the app, to allow not using the YouTube player that can sometimes be weird without needing IINA !

Here is what I did in detail:

• Added the YoutubeKit module to extract stream urls from YT urls.
• Removed SDWebImageSwiftUI and use SwiftUI's AsyncImage elements ( Maybe should change this to use SDWebImageSwiftUI again as i think there was a good reason for it lol )
• Changed OnHover behaviour of video row to not hide the thumbnail but make it smaller
• Changed Menubar icon to match more YT logo
• Added videoClickBehaviour setting, to let the user customise the action performed on double clicking on a video row & made the corresponding GeneralSettingsView picker.
• Added support for native player. The app fetch the stream url of the video, and displays a native player for this stream.
• Added useNativePlayer setting for the user to choose between youtube player and native one.

ToDo / ways to improve :

• Add support for DASH streams in the native player, as YT doesn't provide any good quality non-DASH streams.
• Do the same thing for audio only playback (put controls in the bottom of the menubar view when playing).
• Make player window staying in all the desktops (like Quick Look's window) ( ✅, eventually add customisable behaviour for if app should appear also on fullscreen apps etc)

If you want to wait before merging, i'm going to work on the things listed above :3

The biggest issue was wget wasn't even installed on half the systems, wget does not come with our dear macs. I use npm and brew half the time so I never needed wget however there is a brew package for it.

Updated everything. If you find any error, point it out please. It works fine for me.

Cannot play video(API key inputted).

Also API key box too small.

Also the icon is too big, (I'll make one if I can),

The app cannot play videos no matter what I do, right click or anything.

I've created the credential and pasted the key and these are the error messages:

Log at: 2022-02-03 12:56:47 +0000, from Playlists, message => Fetching playlist data Log at: 2022-02-03 12:56:47 +0000, from Playlists, message => The response we got from server is invalid Log at: 2022-02-03 12:56:47 +0000, from Playlists, message => I've never seen an error like this before

I really want an app to listen to music in youtube as I like soundtracks that aren't in spotify or youtube premium =
also youtube premium and the youtube pwa just sucks

As there are two options to play, with video and just music. I played a song with "Just Music" option and then after some time I played the same song again ("Just Music"). it is adding multiple streams in the global music navigation menu.

Is this Expected?

When I play "Just Music" is there a way to have a single stream like (Now Playing) overwriting the previous one. (may be a feature request)

Hello!

In this pull request I refactored a ton of logic that to me seemed a bit redundant, there are still a couple more that I would like to refactor but I will probably work on that later. I removed the old AppKit stuff, like Main.storyboard and AppDelegate.swift in favor of the SwiftUI version of lifecycle.

I also improved App state by creating an AppStateViewModel which handles any shared data between views and publishes on data change across views.

There are some couple performance improvements and some ui improvement, such as a Preference Panel and we can add a general settings tab for any additional settings in the future.

Feel free to change anything you believe there should be change! :)

Right now, install.sh will waste time trying to install Homebrew even if it is installed. I added a check for the brew command so that this issue is fixed. I also removed the sleep statements from the bottom because they're unnecessary.

I can't figure out where to paste the API key. When I open the app, I see the following screen:

Clicking the Save API Key button does nothing.

System:

• 2015 15" MacBook Pro
• macOS 11.3.1

Thank you @nathom for suggesting the IF statement applications very much! This helps massively in lowering download/update speeds, I've added package checks as well and many more!

This is the final version of install.sh, (please tell what further can we do)

I've also updated my version to work with the DMG installer.

Please suggest what can I do further