Can you show me how can I hide TabBar (the horizontal scroll view) I want to hide it when pull down the tableview (to make more space for tableview's content) Please help me. Thank you.

TabPageViewController.displayControllerWithIndex(1, direction: .Forward, animated: false)?

I want set current index for controller, but does not update tabbar?

I forked your lib and fix this issue (Please look at what I commented at the bottom) Hide Scroll tab view

I add another option in TabPageOption, named "hidesNavigationBarOnSwipe" When hidesNavigationBarOnSwipe == true, navigation bar will be hidden. When hidesNavigationBarOnSwipe == false, navigation bar will be shown.

So we can hide Scroll tab and Navigation bar separately. (Currently, when you drag to hide Scroll tab, Navigation bar is hidden too)

iOS 10 was just released & we need to start making our apps ready for that. Please work on it or create a swift-3 branch & I'll send a PR. Thanks.

• Tap tabItem
• Swipe or tap viewController immediately (before tabItem's animation has finished)
• tabItem shows that Blue viewController is selected, but Red viewController is actually selected. (And after that, Yellow viewController disappears and be skipped)

Sometimes app crashes but not every time.

2017-06-02 14:05:39.322094 TabPageViewControllerDemo[5856:1863363] *** Assertion failure in -[TabPageViewController.TabPageViewController queuingScrollView:didEndManualScroll:toRevealView:direction:animated:didFinish:didComplete:], /BuildRoot/Library/Caches/com.apple.xbs/Sources/UIKit/UIKit-3600.6.22/UIPageViewController.m:2083
2017-06-02 14:05:39.324377 TabPageViewControllerDemo[5856:1863363] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'No view controller managing visible view <UIView: 0x115f10400; frame = (0 0; 375 667); autoresize = W+H; layer = <CALayer: 0x17403f060>>'
*** First throw call stack:
(0x191e151b8 0x19084c55c 0x191e1508c 0x1928cd02c 0x1984d8ae0 0x1985aacbc 0x1985aaa14 0x1985a6b38 0x1985a97b8 0x1985acac4 0x1985accec 0x1985a7aa8 0x197fde050 0x197e73370 0x197e72eac 0x19506af24 0x19506add0 0x192082094 0x191daae50 0x191dc3218 0x191dc29cc 0x191dc04b0 0x191cee2b8 0x1937a2198 0x197d357fc 0x197d30534 0x10004b624 0x190cd15b8)
libc++abi.dylib: terminating with uncaught exception of type NSException

To prevent this bug, I set tabPagerController.view.isUserInteractionEnabled to false in displayControllerWithIndex, then set to true when animation has been completed. This change works fine with my project currently.

Sorry for writing in Japanese.

いつも使わさせていただいております。日本語で失礼します。

この度、動作環境を xcode 8.3, swift 3.1 にして 0.2.6 にバージョンアップしたところ、 isInfinity が true だと 2回目か3回目くらいにタブが選択できなくなりました。

以下が動作キャプチャです。

https://i.gyazo.com/190a4f02265d4795e8ff7038ea7cf4f5.mp4

ソースコードを拝見しつつデバッグしたところ

https://github.com/EndouMari/TabPageViewController/blob/master/Sources/TabView.swift#L258

上記のif文をなくすと見た目上は正常に動作するようになりました。

https://i.gyazo.com/107a8fdd661b02a414076e3a58350607.mp4

深いところまでは追っていないのでこのif文を消すだけで問題がないか確認いただけますでしょうか。 このあとPRをお送りします。よろしくお願いします。

== Automatic translation using Google translation

I have upgraded the operating environment to xcode 8.3, swift 3.1 and upgraded it to 0.2.6, and when isInfinity is true, it becomes impossible to select the tab for the second time or the third time.

The following is the operation capture.

Https://i.gyazo.com/190a4f02265d4795e8ff7038ea7cf4f5.mp4

Debugging while seeing the source code

Https://github.com/EndouMari/TabPageViewController/blob/master/Sources/TabView.swift#L258

If you omit the above if statement, it looks like it works normally.

Https://i.gyazo.com/107a8fdd661b02a414076e3a58350607.mp4

Since I am not chasing deeply, can you check whether there is no problem just by deleting this if statement? I will send you a PR after this. Thank you.

Hi, @EndouMari.

I want to use this library in the width of several screen.

For example,

• Page Sheet
• Form Sheet, etc.

However, defaultContentOffsetX is width of the screen.

Do you have any good ideas?

I am using carthage for TabPageViewController, there is an import error message show: Module file's minimum deployment target is ios8.3? is it the minimum version? My environment: Xcode7.3 swift2.2 deployment target: iOS8.0

I prefer to change tabItemsCount to computed property, because didSet does not fire when the property was initialized. So open var tabItems: [(viewController: UIViewController, title: String)] = [] does not trigger didSet. tabItemsCount will have incorrect value if you make initial value nonempty.

Hi author. I just updated your library and an error has occurred (it works normal before). Module compiled with Swift 3.1 cannot be imported in Swift 3.0.2 image How can I use your library with Swift 3.0.2? Please help me.

Thank you.

When I keep scrolling without releasing your finger, the title of the tab changes.

I attach a gif file to a movie.

Is there a solution to this problem?

Following the Demo I was able to implement the TabPageViewController, but I would like to retain the system appearance of the nav bar (including the tab)

This is what I got so far but I don't think it matches the default system appearance

class TabPageViewController: TabPageViewController {
    
    override init() {
        super.init()
        
        // Configure the navigation bar
        /// Should I even need this?
        let appearance = UINavigationBarAppearance()
        appearance.configureWithTransparentBackground()
        navigationController?.navigationBar.standardAppearance = appearance
        
        // configure the VCs
        // [...] 
        
        option.isTranslucent = true
        option.tabBackgroundColor = UIColor.clear
        option.currentColor = UIColor(named: "AccentColor")!
    }
}

Any nudge in the correct direction?

I have added a simple fix for the right to left language support Like Arabic, Persian, Hebrew ...

Fork: https://github.com/Dev-Khaled/TabPageViewController

if you can merge it Thanks

On some iPhones:

There's a table view under the tab bar, and I can scroll the table view, such that the table view contents is visible between the top of the tab bar, and the top of the screen. Isn't the tab bar supposed to be extended to the very edge of the screen?