It seems there's two issues when there's an in-call status bar with a taller height. First, the status bar covers up the presented view controller's top part.

Second, after dismissing the presented modal, the presented view controller isn't being reset correctly. To reproduce, on the demo toggle in-call status bar, present the modal, take the app to background and bring it back. Now the presented view controller's frame is wrong. It's something to do with the transform, but I haven't figured it out yet.. On my own app, the controller's frame is actually going off screen (e.g. too large) after the modal is dismissed

I have implemented your scroll view code to my table view controller and it will dismiss when I’m not at the top. Do you have any suggestions?

Also when it said set the scroll view delegate as self, I just made sure tableview.delegate equaled self. Is that correct?

You seem to be using optional parameters within the constructors which can't be bridged to ObjC. Thus this library is not usable in ObjC projects.

See: https://stackoverflow.com/questions/26470771/swift-init-not-visible-in-objecitve-c

I wanted to be able to customise the top offset of the presented ViewController, so I've added in a new property in the DeckTransitioningDelegate and DeckPresentationController, that allows for this.

It is an optional argument to the existing constructors, that defaults to 28. Existing call sites will not be affected.

Because the top offset could be large enough that the user could tap on the background, I've also added a tap gesture to dismiss the modal by tapping there.

Regards, Arvindh

I noticed that if you drag the view past the threshold to dismiss it, you can't drag your finger back if you don't let go to cancel it.

It's a bit frustrating if you drag it down to "peek" underneath, and then it closes. Just running some tests here to examine the functionality and noticed this.

In your example file you are creating an object of ModalViewController and present this view controller via present(_:animated:completion:) after transitioningDelegate and modalPresentationStyle are set. This works as expected. The statusBar appearance changes with the transition from default to lightContent and then back to default again when dismissing.

But creating a storyboard segue by following the instructions in your README file (line 51) and perform the segue by invoking performSegue(withIdentifier:sender) doesn't change the statusBar appearance as expected. It keeps its default value. I couldn't figure out why.

Tested on Xcode 9GM simulator with iOS 11, iPhone 7+8.

This glitch appends when the View Controller is not the top-level VC of a Navigation Controller (when you've got a Back Button in the navBar etc.) When the Modal Controller is pushed, the navBar of the previous ViewController is cropped from the top.

Hey! Matt from WWDCSCholars here :)

You sent me this library a few days ago. It looks neat! But we were wondering, could you please add Carthage support so we can actually implement it in the app, without too much hassle?

Hi there.

Really want to use DeckTransition but it isn't working for me. I'm using a dark background and an embedded UIView with a tap gesture recogniser.

Please can you help me.

This prevents crashing if DeckPresentationController contains a table view, since scrollViewUpdater observes contentOffset and results in crash when table view displayed is eventually released while still having this KVO observer:

Fatal Exception: NSInternalInconsistencyException An instance 0x132094a00 of class UITableView was deallocated while key value observers were still registered with it. Current observation info: <NSKeyValueObservationInfo 0x174626680> ( <NSKeyValueObservance 0x17485da60: Observer: 0x175e74cc0, Key path: contentOffset, Options: <New: NO, Old: NO, Prior: NO> Context: 0x0, Property: 0x170a50890> )

Hello Harshil Shah! Thanks a lot of what are you doing!! In ios11 I found interesting bug. On hiding navigation bar on tap it disappears like on foto. Can you help with this?

Hello. I've used DeckTransition for a while, but I have ipod with ios 9.3.5. And I'v caught Zombie object.

The same app on the simulator (ios >= 11.0) or iPhone (ios >= 11.0) works fine.

I am integrating this lib into my project and it works perfect until I got this problem with keyboard:

• setup a viewcontroller with textfield and keyboard is showing
• click on a button to present this new viewcontroller with this decktransition. The keyboard will hide automatically but very laggy

The keyboard is glitching/laggy when hiding. I am sure it is this lib because I compare this lib with ios default presenting modal view.

I hope this one could be fixed because this glitching make smooth animation become glitchy

Hey all,

Sorry it’s been a while, this took a bit longer than I’d expected, and then iOS 13 hit and that made it take a bit longer.

Originally, I was planning address some different issues with this major update, however in light of the transition changes in iOS 13, I’ve had to made some changes to the plans. While custom transitions and variable height presentations were to be the main focus, I’ve decided to push those back in favour of prioritising bringing the design and implementation up to par with Apple’s.

The goal for now is to essentially make DeckTransition functionally identical to the default iOS 13 transitions which will enable backporting the new UI for now, and then building in features which Apple doesn’t have yet such as the two mentioned above, better customisability on iPads, and so on.

Here’s a list of all the changes I’m hoping to get in:

• The swipe-to-dismiss gesture should use an interactive transition.
• View controllers should be able to dynamically specify when a dismissal is allowed.
• The corner radius handling needs improvement. On devices and features with rounded corners (so the X-series iPhones, newer iPad Pros, and split view on iPads) the presenting card should animate from the device’s corners.
• The iPad UI needs a complete rethink. It should essentially be a 1:1 match of Apple’s designs which scales up from a page sheet to the current style based on the user’s dynamic type settings.

The iPhone part of this changelog is relatively trivial. The iPad part will take significant work, especially given the smart things Apple is doing with handling corner radii in split view, for example.

Additionally, I think I’ve found solutions to some prevalent bugs such as the weird transforms for certain UITableView rows and some others.

It should be possible to retain support for upto iOS 11, however iOS 9 and 10 will likely have to be dropped.

The plan is to have a draft of this change in within a few weeks, time permitting.

I’d love to hear any thoughts people using this library have about these planned changes or any ideas.

In my app I have a UISplitViewController as the base. Now, when I present a UIViewController as a card on top of it, the view will look like this.

However, when I rotate the device and then rotate back, the layout breaks and it will look like this.

When I then rotate once more and once more back, the app will crash, throwing this:

Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Multiplier is not finite!  That's illegal.  multiplier:-inf'
*** First throw call stack:
(
0   CoreFoundation                      0x000000010759a6fb __exceptionPreprocess + 331
1   libobjc.A.dylib                     0x0000000106b3eac5 objc_exception_throw + 48
2   CoreFoundation                      0x000000010759a482 +[NSException raise:format:arguments:] + 98
3   Foundation                          0x000000010658c927 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 194
4   Foundation                          0x000000010679255e -[NSLayoutConstraint _setMultiplier:] + 336
5   Foundation                          0x000000010679949f +[NSLayoutConstraint constraintWithAnchor:relatedBy:toAnchor:multiplier:constant:] + 575
6   DeckTransition                      0x000000010319992b $s14DeckTransition0A22PresentationControllerC29updateSnapshotViewAspectRatio33_71FA53A27BEAE2D482201C2CF371A196LLyyF + 1931
7   DeckTransition                      0x000000010319a09a $s14DeckTransition0A22PresentationControllerC31containerViewWillLayoutSubviewsyyF + 298
8   DeckTransition                      0x000000010319a644 $s14DeckTransition0A22PresentationControllerC31containerViewWillLayoutSubviewsyyFTo + 36
9   UIKitCore                           0x0000000111070905 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 1229

Any ideas as to what could be causing this? I have a feeling it's a layout issue in the library, but I have no clue where to start looking...