Hey 😬 I can see through the code that indeed the library support custom headers, anywhere you can point me in the docs for it? Can't seem to find anything

hi, i get the following errors

Cannot convert return expression of type 'Dictionary<Key, Value>.Values' to return type 'LazyMapCollection<[Key : Value], Value>'

lines 330-333

  public var keys: LazyMapCollection<[Key : Value], Key> {
    return _data.keys
  }
  public var values: LazyMapCollection<[Key : Value], Value> {
    return _data.values
  }

i didn't see the "values" being used anywhere?? i commented out the lines and checked a couple of files and servers and got back the correct GET/POST

Hi, First of all, great library. thanks. I'm updating UI components in the main thread as recommended but still can't get the UIprogressView work although console print works fine.

What is wrong here?

 Just.post("https://httpbin.org/post",
                   files:["sample": .url(sampleFile, nil)],
                   asyncProgressHandler:{ p in
                       print(p.percent)
                       DispatchQueue.main.async(execute: {
                               self.progressView.setProgress(p.percent, animated: false)
                        })
          })

My app crashing using asynchronous callback but works fine when switching to synchronous mode. I dont know why.

Pseudo Sample: APP CRASHING: Just.post( "http://justiceleauge.org/member/register", data: ["username": "barryallen", "password":"ReverseF1ashSucks"], files: ["profile_photo": .URL(fileURLWithPath:"flash.jpeg", nil)] ) { r in if r.ok { /* SOME CODE HERE! */ } }

THIS WORKS: let r = Just.post( "http://justiceleauge.org/member/register", data: ["username": "barryallen", "password":"ReverseF1ashSucks"], files: ["profile_photo": .URL(fileURLWithPath:"flash.jpeg", nil)] )

if r.ok { /* SOME CODE HERE! */ }

When I run, these error occurs:

Cannot convert return expression of type 'Dictionary<Key, Value>.Keys' to return type 'LazyMapCollection<[Key : Value], Key>'

Cannot convert return expression of type 'Dictionary<Key, Value>.Values' to return type 'LazyMapCollection<[Key : Value], Value>'

Im currently on XCode 8 with Swift 3 and i have a PHP file upload handler in the server side. Using the provided playground file, and basically just changing the POST URL to my PHP handler, upload doesnt work (file not reaching the server) but no error whatsoever. Fyi, i used another swift HTTP client (Swift 2.x version compatible) with the same PHP handler and it is working fine.

From playground: let elonPhotoURL = Bundle.main.url(forResource: "elon", withExtension: "jpg")! let uploadResult = Just.post("**http://xxxx.com/uploader.php**", files:["elon": .url(elonPhotoURL, "image/jpeg")]) // <== that's it print(uploadResult.text ?? "")

Not sure if this log info will help? "iSignature[10575:3106978] bool _WebTryThreadLock(bool), 0x7960e950: Tried to obtain the web lock from a thread other than the main thread or the web thread. This may be a result of calling to UIKit from a secondary thread. Crashing now..."

I'm trying to use Just in an iOS 10 message extension. Due to various issues, Cocoapods isn't working for me, so I've tried dropping in Just.swift, but I get a whole mess of compile errors, some I don't feel confident about fixing.

Has Swift 3 syntax changed since your last build?

I modified the following (These were causing compilation issues):

in line 698: Before:

for key in Array(parameters.keys).sorted(isOrderedBefore: <) {
            let value: AnyObject! = parameters[key]
            components += self.queryComponents(key, value)
}

After:

for key in Array(parameters.keys).sorted(by: <){
            let value: AnyObject! = parameters[key]
            components += self.queryComponents(key, value)
}

in line 739: Before:

if let component = URL.lastPathComponent {
                    partFilename = component
}

After:

if let component:String = URL.lastPathComponent {
                    partFilename = component
}

Sorry for jumping the gun, but we are in a bit of a hurry to get the app out for testing and this is a blocker for us.

Happy to make whatever changes deemed necessary to the patch; in particular, I'm not sure anything should be done in case of timeouts, maybe return nil instead of the response?

I believe I've come across an issue when running requests in many threads (one thread per request) and some (but not all) of them time out.

The timeouts seem to be "honored" but the thread that initiated the request is left waiting for a semaphore: doing some debugging in Xcode's thread view, I noticed all the threads were stuck on this line:

dispatch_semaphore_wait(semaphore, DISPATCH_TIME_FOREVER)

when I changed it to something like:

                        let NSEC: Int64 = {
                            var base: Int64 = 1
                            for _ in 1...9 {
                                base *= 10
                            }
                            return base
                        }()

                        let tint: Int64 = Int64(timeout ?? 10.0)
                        let how_long = dispatch_time(DISPATCH_TIME_NOW, tint * NSEC)

                        dispatch_semaphore_wait(semaphore, how_long)

my code now runs without problem, I can see threads being created then destroyed, and it's now been running for > 1 hour without any issue (it used to just crash and die with a hundred or so of hung threads in a couple of minutes).

If you want, I'd be happy to polish the fix and push a PR?

There's no reason I can see that Just needs to target 8.3, so I've flipped it to 8.0, we have a 40% non 8.3 userbase and I imagine that number is reflected in other codebases.

Apologies if this is a dumb question, but I am relatively new to Swift. I've implemented this in a little sandbox and can properly make a post call to my end point and get a proper response.

I'm very familiar with Python requests, so I was hoping that I would be able to address the r.json object similarly in Swift, but no matter what I do, I can't seem to figure out how to actually get key out of the r.json object. I can print it and see it is valid, but when I try to something simple (in my mind) like print(r.json["my_key"]) I can't.

This is probably more of a lack of understanding of the object type that r.json returns in swift and how to get info out of it, but I figured I'd ask because I love the idea of just using my familiarity with Python requests to start my voyage into Swift programming.

i tried this

Just.get(url, params: params, headers: headers) { response in
       if response.status.code == 200 {
              let json = JSON(response.json!) 
              .......
      }
}

we managed, to log the content. response.json returns nil because it is not in full response. sample:

{
    order: {
         'id':  1,
         'notes': ''
    }

swift 5 xcode 11.2.1 we can't reproduce this. Only happens in production Thanks

Crashed: com.apple.main-thread
0  libswiftCore.dylib             0x1977b1138 swift_isUniquelyReferenced_nonNull_native + 28
1  Just                           0x105372530 specialized Dictionary._Variant.setValue(_:forKey:) + 44 (<compiler-generated>:44)
2  Just                           0x10536d83c HTTP.makeTask(_:configuration:) + 420 (<compiler-generated>:420)
3  Just                           0x105370c9c HTTP.request(_:url:params:data:json:headers:files:auth:cookies:redirects:timeout:urlQuery:requestBody:asyncProgressHandler:asyncCompletionHandler:) + 1009 (Just.swift:1009)
4  Just                           0x1053715d0 protocol witness for JustAdaptor.request(_:url:params:data:json:headers:files:auth:cookies:redirects:timeout:urlQuery:requestBody:asyncProgressHandler:asyncCompletionHandler:) in conformance HTTP + 96 (<compiler-generated>:96)
5  Just                           0x10536c71c JustOf.delete(_:params:data:json:headers:files:auth:cookies:allowRedirects:timeout:urlQuery:requestBody:asyncProgressHandler:asyncCompletionHandler:) + 364
6  Just                           0x10536c39c JustOf.get(_:params:data:json:headers:files:auth:cookies:allowRedirects:timeout:urlQuery:requestBody:asyncProgressHandler:asyncCompletionHandler:) + 92
7  Houzcall                       0x104490fc4 showRateBookingControllerIfNeeded(_:) + 387 (Utils.swift:387)
8  Houzcall                       0x1044c0134 partial apply for closure #1 in closure #1 in closure #1 in BookingDetailsViewController.syncBookings(_:) + 130 (BookingDetailsViewController.swift:130)
9  Houzcall                       0x1045289c4 thunk for @escaping @callee_guaranteed () -> () + 4376988100 (<compiler-generated>:4376988100)
10 libdispatch.dylib              0x18a075610 _dispatch_call_block_and_release + 24
11 libdispatch.dylib              0x18a076184 _dispatch_client_callout + 16
12 libdispatch.dylib              0x18a05935c _dispatch_main_queue_callback_4CF$VARIANT$armv81 + 996
13 CoreFoundation                 0x18a3263c4 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
14 CoreFoundation                 0x18a3213b8 __CFRunLoopRun + 2004
15 CoreFoundation                 0x18a3208bc CFRunLoopRunSpecific + 464
16 GraphicsServices               0x19418c328 GSEventRunModal + 104
17 UIKitCore                      0x18e3b66d4 UIApplicationMain + 1936
18 Houzcall                       0x104424764 main + 21 (AppDelegate.swift:21)
19 libdyld.dylib                  0x18a1ab460 start + 4

Hi @dduan currently I found a problem when trying to do Just.get(). from what I see, there is a possibility when doing Just.get() the request is nil when trying to makeTask

// Just.swift
...
public func synthesizeRequest(...) -> URLRequest?
...
func makeTask(_ request: URLRequest, configuration: TaskConfiguration)
    -> URLSessionDataTask?
...
guard let request = synthesizeRequest()
...
// variabel `request` below can be `nil`
if let task = makeTask(request, configuration: config) {
    task.resume()
}

isn't synthesizeRequest() supposed return URLRequest without nil?

This only happens in production build and I can't reproduce the crash. Xcode 11.1 Swift 5

I want to get the real link of a page from a link that redirects, such as this: https://apple.news/AQZXxg8mUQfKrEaM9MRBpxw . However, when I do

    Just.get("https://apple.news/AQZXxg8mUQfKrEaM9MRBpxw")
    { r in
        
        print(r.statusCode)
        print(r.url)
    }

it still prints the same link. Does Just not get real redirect links or am I doing it wrong?