Hi,

I've just tried the example from the project, added just a few more elements to tableview that is inside and got this behaviour that I've recorded in video https://youtu.be/q4cU4kW-rcQ It happens when panel is fully open, inside tableview is scrolled a bit up and then when you pulling it down it starts skipping when it reaches the end by pulling the panel to compensate. Maybe it's not well explained in words, but you can see it in video :)

Regards,

Aleksandar

Haven't you thought about changing some closures to functions opened to overriding, so that you could make a few overrides? For example, I have a subclass of PullUpController ABC, which is superclass to another class CDF. To call some function from ABC on each call in CDF I have to do something like this for now. Maybe I just don't know something.

The pullup animation seems like its going to pause at an invisible sticky point in the middle of the screen( Even though the sticky point array has only 2 points - Offset and PreferredHeight) This makes the animation look incomplete and smooth Any idea on how I can resolve this?

Hey, thanks for the great library!

We're considering using it in an existing project. I seem to have managed to customize it fine so far (with rounded corners and shadow). But I cannot seem to set up the landscapeFrame. See this video: https://www.dropbox.com/s/8pxh1rdm56fs1fm/pulluppcontroller.mp4?dl=0 When the phone rotates, the controller is placed somewhere below the screen. When it is fully expanded, it does show up a bit, but its bottom is probably somewhere below the screen bounds. Also, it is aligned next to the left screen edge, even if it should have some trailing space.

I did override

override var pullUpControllerPreferredLandscapeFrame: CGRect

in my own ViewController inheriting from PullUpController. I gave it the value CGRect(x: 10, y: 20, width: 280, height: 100). Is there something else I am missing? Or maybe it is clashing with some existing code?

Hi. Love you lib, though there are two things I'm concerned about:

1. Could you add some way to change animations, except for copying the file and changing them yourself? Overriding is not quite an option because not all the functions using animation are open.
2. On bounce or spring animation, I'm using now, there is some free space in the bottom when animating. It looks a bit weird. For now, I'm fixing it adding some extra height in pullUpControllerPreferredSize, though it would be also nice if you could do something with it, or at least I will be grateful if you could give me some advice how to do it better.

Thanks :)

Edit: also seems logical to call willMoveToStickyPoint and didMoveToStickyPoint on moveToVisiblePointHandling.

Should PullUp bounce when pullUpControllerMoveToVisiblePoint is called to 0.0 or is removed with animation? Looks a bit weird. Should that be handled by the library or better to use overriding of the bounce offset and exposed current point?

UPD: This is not bounce issue.

As I understood documentation and code, you can only change pullupVC inside itself. However, there is a needs to hide/show it outside. I think there should be delegate for that, like in default UIKit elements.

i have one doubt in this pod, for eg if i click But ticket button how to show popup window ?

Could you give the code for this ?

For hide i use pullUpControllerMoveToVisiblePoint(pullUpControllerAllStickyPoints[0], animated: true, completion: nil) this is working

but how to show window on event ?

With the latest pod update I cannot increase the visible point height. Previosuly I was able to increase with increasing previewOffsetValue. Now it has been removed.

override var pullUpControllerPreviewOffset: CGFloat {
       return 120
       //searchBoxContainerView.frame.height
   }

When running on the iPhone XR Simulator, the view controller does not "drag" up slowly when using finger like it does on iPhone 7 Simulator.

Do not have iPhone XR/XS to determine if this is a simulator issue, or issue with code.

I'm developing an application in which only portrait orientation is available. When I started using the library I found the problem. It seemed to me that I should not override the variable pullUpControllerPreferredLandscapeFrame. But when I override only pullUpControllerPreferredSize and run my application I saw that the frame of the PullUpController was inherited from super definition of pullUpControllerPreferredLandscapeFrame. Something going wrong inside of controller. That was really confused for me. I hope this feedback will help you make your library better.

when search view controller is half opened the scorlling is not working. I have also used func gestureRecognizer(gestureRecognizer: UIGestureRecognizer, shouldRecognizeSimultaneouslyWithGestureRecognizer otherGestureRecognizer: UIGestureRecognizer) -> Bool { return true }

but not works. Please help

open func addPullUpController(_ pullUpController: PullUpController, initialStickyPointOffset: CGFloat, animated: Bool, completion: ((Bool) -> Void)? = nil) { assert(!(self is UITableViewController), "It's not possible to attach a PullUpController to a UITableViewController. Check this issue for more information: https://github.com/MarioIannotta/PullUpController/issues/14") addChild(pullUpController) pullUpController.setup(superview: view, initialStickyPointOffset: initialStickyPointOffset) if animated { pullUpController.pullUpControllerAnimate( action: .add, withDuration: 0.3, animations: { [weak self] in self?.view.layoutIfNeeded() // Thread 1: EXC_BAD_ACCESS (code=EXC_I386_GPFLT) }, completion: { didComplete in pullUpController.didMove(toParent: self) completion?(didComplete) } ) } else {... please help)

I got this message. It is possible that the app will crash. With this solution * DispatchQueue.main.async {} (in line 489 of the PullUpController.swift), the message will disappear.

Kind Regards, Ton Driessen

DispatchQueue.main.async { if animated { pullUpController.pullUpControllerAnimate( action: .add, withDuration: 0.3, animations: { [weak self] in self?.view.layoutIfNeeded() }, completion: { didComplete in pullUpController.didMove(toParent: self) completion?(didComplete) } ) } else { self.view.layoutIfNeeded() pullUpController.didMove(toParent: self) completion?(true) } } }

In Map.app on iPad, the PullUpController is located in the left top Instead bottom and its width does not equal the width of the screen. There are some differences between iPad and iPhone. In iOS 13 or newer, Apple add SceneDelegate and the size of the scene will be changed by users. So, updating the frame when it changes is also important.

Contacted you on twitter have a replicated example on me, when a tab bar view is embed into the main view the pullupcontroller is hidden under the tab bar on the iPhone X, Xr, Xs and Xs Max