This fixes a bug where the Info.plist file from this repo was included in the compile sources phase, which causes a build failure with the new Xcode 9 build system.

Hi All, Im using StackViewController in one of my Projects. Currently im using "backgroundcolor" property to set the BG color of the View. Now i have a new Req in which i need to set an Image as the Background. Is it Possible using this Framework ? I tried adding a subview to the "backgroundView" property and it is not working out. Please provide some pointers.

Thank you :)

Currently we expose properties for backgroundColor, backgroundView, stackView, axis seperatorViewFactory and scrollView. Ideally a user won't be able to modify the state of stackView, seperatorViewFactory and scrollView without going through StackViewController directly.

Being able to modify properties of the stack view directly makes it possible for a user to reconfigure it in such a way that it isn't compatible with the current configuration of the StackViewController anymore. Similarly being able to change the axis after initialization complicates the implementation of StackViewController because it always needs to account for the fact the the axis might change.

axis, separatorViewFactory and backgroundView should be injected in the initializer and not changed after StackViewConroller is initialized.

stackView scrollView properties that we want the user to modify should be exposed directly on the StackViewController. For example if we want the user to be able to scroll we could expose scroll(toViewController:) or scroll(toRect:) on StackViewController directly.

We can keep backgroundColor, but I think it should be implemented as a convenience for backgroundView.backgroundColor =.

Hi there. Love this project and the quality of the code! Can you do us a favor and release a new version with the latest changes? The current podspec and release tags cause an older version of the code to be installed (pre Swift 3) Thanks!

When running the app on iPhone 6, after adding the third picture, it should be on a line below, instead of scrolling off to the side. The same way the text entry field expands downwards, the container of the cells should also expand accordingly. (BTW, fantastic work done on the StackViewController)

This is my initial draft of the README, containing the overview of the project and the detailed design rationale. Feel free to nitpick, I want to make sure this gets the idea across properly.

This bit of code had an error:

/// The items displayed by this controller
open var items: [StackViewItem] {
    get { return _items }
    set(newItems) {
        for (index, _) in _items.enumerated() { // <-- HERE
            removeItemAtIndex(index)
        }
        for item in newItems {
            addItem(item, canShowSeparator: true)
        }
    }
}

As it looks through the array with the index increasing it will hit an Index Not Found exception once the number of remaining items is less than the current index.

Simple fix was to reverse the enumeration.

/// The items displayed by this controller
open var items: [StackViewItem] {
    get { return _items }
    set(newItems) {
        for (index, _) in _items.enumerated().reversed() { // <-- SIMPLE FIX
            removeItemAtIndex(index)
        }
        for item in newItems {
            addItem(item, canShowSeparator: true)
        }
    }
}

Hi, I am currently considering to use this good library in my project to show user inbox email. So, in the Demo App, I'm trying to add a WKWebView as StackViewController item in place of UITextView but web view is not shown. This's modified setupStackViewController method:

import WKWebKit

....

fileprivate func setupStackViewController() {
     let toFieldController = LabeledTextFieldController(labelText: "To:")
     firstField = toFieldController.view
     stackViewController.addItem(toFieldController)
     stackViewController.addItem(LabeledTextFieldController(labelText: "Subject:"))
        
     let webView = WKWebView()
     webView.loadHTMLString("This field automatically expands as you type, no additional logic required", baseURL: nil)
     webView.scrollView.isScrollEnabled = false
     stackViewController.addItem(webView, canShowSeparator: false)
        
     stackViewController.addItem(ImageAttachmentViewController())
 }

Debug View Hierarchy tells me Scrollable content size is ambiguous. What I'm doing wrong?

Thanks for your help, Giorgio

stackView.removeArrangedSubview does not actually remove the subview from its superview. This leaves a big pile of UIViews sitting around on screen afterwards.

This will fix it: open func removeContentViewAtIndex(_ index: Int) { precondition(index >= items.startIndex) precondition(index < items.endIndex)

    let item = items[index]
    if items.count >= 1 && index == (items.endIndex - 1) && index > 0 {
        let previousItem = items[(index - 1)]
        if let separatorView = previousItem.separatorView {
            stackView.removeArrangedSubview(separatorView)
            separatorView.removeFromSuperview()
            previousItem.separatorView = nil
        }
    }
    stackView.removeArrangedSubview(item.contentView)
    item.contentView.removeFromSuperview()
    if let separatorView = item.separatorView {
        stackView.removeArrangedSubview(separatorView)
        separatorView.removeFromSuperview()
    }
    items.remove(at: index)
    _contentViews.remove(at: index)
}

Setting StackViewContainer.backgroundColor while there is also a backgroundView currently does not have the intended behaviour because the backgroundView goes underneath the stackView, which does not draw its own background color. The stackView is now wrapped in a container view that draws a background to prevent this issue.

Previously, the SeparatorView's actual axis would be perpendicular to the axis of the stack view, which was passed into this initializer. This (largely unintentional) convention was convenient because you could use the stack view's axis directly as the parameter to the SeparatorView initializer, but this made no sense when using the SeparatorView as a standalone view.

This pull request changes that convention to the opposite (the axis parameter passed into init is the actual axis of the separator) and adds a convenience method for creating separator view factories because it's no longer a trivial one liner.

Perhaps there is another intended way to do this, but if I set the .stackView.spacing property, the top of the stack view is still flush with the AutoScrollView instead of offset by the spacing amount which makes the layout look wrong. It looks like simply passing the stack view spacing property as a edge inset to activateSuperviewHuggingConstraints in commonInit() on line 130 of StackViewContainer might do the trick

Hi! Thank you for great plugin! Could you please explain, how to easily access to subject: and to: fields text to be able send message? Now only bodyText field is accessible thru ViewController. Thanks.