Hi,

This is a great libary, I am not referencing it as a pod but integrating it as a Library but for some reason its creating a compilation issue for the first line in this function saying :

Ambiguous use of 'dc'

    func ipadSize1024() -> Double {
        let deviceModel = UIDevice().dc.deviceModel // the error is on this line
        switch deviceModel {
        case .iPadMini, .iPadMini2, .iPadMini3, .iPadMini4, .iPadMini5: return 7.9
        case .iPadPro10_5Inch: return 10.5
        case .iPadSevenGen: return 10.2
        default: return 9.7
        }
    }

Is there any way of fixing this and yes I would like to use it directly not as a pod please :)

Thank you,

Wael

Not ready,

iPad 13,4, 13,5, 13,8, 13,9 is WiFi iPad 13,6, 13,7, 13,10, 13,11 is Cellular

But I think its too early to tell which is (probably) the higher RAM version

We love your library, very well thought out and written, but it has a problem with Swift Package Manager, you can reproduce it with Xcode 11.3. Can you have a look?

Cannot convert value of type 'Int' to expected element type 'SwiftVersion'

using:

Xcode 11.1GM (11A1027)
iOS 13.1
Simulator XS

& code:

switch device {
            case .iPhoneXR, .iPhone11:
                print("test:sized for found:", device)
                print("test:adjustments for: XR, 11")
                break
            case .iPhone11Pro, .iPhoneX, .iPhoneXS:
                print("test:sized for found:", device)
                print("test:adjustments for: 11Pro, X, XS")
                break
            default:
                print("test:sized for default:", device)
                break
 }

the output for the XS: test:sized for default: unknown Same for the XS Max. other devices seem to be ok. Is this a bug?

Ty

In Xcode 14, cStrings need to be null-terminated. I updated this variable to work with null-terminated strings but not add extra spaces at the end.

Closes #78

@vincentneo This pull request was just sent over #51

Maybe we should check everything and make sure there are no other existing issues for XCode 12.

If there are no further issues then lets put out a new release!

Xcode Version 11.4.1 (11E503a)
iOS 13.1.4
Simulator iPhone SE 2nd Gen

& code:

let device = UIDevice.current.dc.deviceModel

Returns "unknown"

The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99.

Travis CI now appears to be a paid service for iOS builds? I've switch to GitHub Actions for my personal projects, and thought if you would want to switch too for this project.

❯ bundle exec pod install
Analyzing dependencies
Downloading dependencies
Installing UIDeviceComplete (2.7.3)
[!] Unable to determine Swift version for the following pods:

- `UIDeviceComplete-library` does not specify a Swift version and none of the targets (`MyTarget`) integrating it have the `SWIFT_VERSION` attribute set. Please contact the author or set the `SWIFT_VERSION` attribute in at least one of the targets that integrate this pod.

Setting SWIFT_VERSION in my project fixes this. But specifying Swift version in the podspec would be more correct.

My private pod depends on your library: s.dependency 'UIDeviceComplete', '~> 2.7'

When I install pods, only v2.7.3 is fetched:

❯ bundle exec pod install --repo-update
Updating local specs repositories
Analyzing dependencies
Downloading dependencies
Installing UIDeviceComplete (2.7.3)
...

Temporary workaround is to point to the repo directly in Podfile:

pod 'UIDeviceComplete', :git => 'https://github.com/Nirma/UIDeviceComplete.git', :commit => '7fa25cf6c648a0c5fa4bb8c182fb91c7ded3e861'

Regarding:

// MARK: - Detecting Screen size in Inches
extension Screen {
    public var sizeInches: Double? {
        switch (height, scale) {
        case (480, _): return 3.5
        case (568, _): return 4.0
        case (667, 3.0), (736, _): return 5.5
        case (667, 1.0), (667, 2.0): return 4.7
        case (812, 3.0): return 5.8
        case (896, 2.0): return 6.1
        case (896, 3.0): return 6.5
        case (1024, _): return ipadSize1024()
        case (1080, _): return 10.2
        case (1112, _): return 10.5
        case (1133, _): return 8.3
        case (1180, _): return 10.9
        case (1194, _): return 11.0
        case (1366, _): return 12.9
        default: return nil
        }
    }

    func ipadSize1024() -> Double {
        let deviceModel = UIDevice().dc.deviceModel
        switch deviceModel {
        case .iPadMini, .iPadMini2, .iPadMini3, .iPadMini4, .iPadMini5: return 7.9
        case .iPadPro10_5Inch: return 10.5
        default: return 9.7
        }
    }
}

iPhone 12 ProMax & 13 ProMax have a 6.7 iPhone 12 mini & 13 mini have a 5.4

When running on an iPhone 12 mini

UIDevice.current.dc.screenSize.height = 812 UIDevice.current.dc.screenSize.scale = 3 UIDevice.current.dc.screenSize.sizeInches = 5.8

But with Display Zoom turned on I get these values:

UIDevice.current.dc.screenSize.height = 693 UIDevice.current.dc.screenSize.scale = 3

And since there is no match, sizeInches is nil.