Type of issue: Bug

Related Files: https://gist.github.com/c859ec7ca61130369fc40bea3b53b9a8

Description: Followed all install instructions, but am getting "command not found" when running nslocalizer. Install seems to fail on install_requirements.txt, after which it prints: If reporting this issue please do so at (not Homebrew/brew or Homebrew/core): https://github.com/samdmarshall/homebrew-formulae/issues

I followed all brew/Troubleshooting instructions, updated my XCode command line tools, restarted everything... no effect. I have also tried installing python3, but it says it's already installed.

Bug: Permission failures on brew install due to system protections present on macOS 10.13+

Description:

When I try to install via brew install, I get the following errors:

$ brew install samdmarshall/formulae/nslocalizer
==> Installing nslocalizer from samdmarshall/formulae
==> Cloning https://github.com/samdmarshall/nslocalizer.git
Updating /Users/bjhomer/Library/Caches/Homebrew/nslocalizer--git
==> Checking out branch develop
Already on 'develop'
Your branch is up to date with 'origin/develop'.
HEAD is now at 4c00aa1 Merge pull request #10 from samdmarshall/updating-pbPlist-version
Entering 'docs'
/Users/bjhomer/Library/Caches/Homebrew/nslocalizer--git/docs
==> pip3 install -r install_requirements.txt
Last 15 lines from /Users/bjhomer/Library/Logs/Homebrew/nslocalizer/01.pip3:
  Building wheel for pbPlist (setup.py): finished with status 'done'
  Stored in directory: /private/tmp/nslocalizer-20190225-22020-mnpzab/.brew_home/Library/Caches/pip/wheels/7a/8e/c5/1222a694fb77543c4a19a9a783ce962abd63f0ad3eff749cb9
  Building wheel for langcodes (setup.py): started
  Building wheel for langcodes (setup.py): finished with status 'done'
  Stored in directory: /private/tmp/nslocalizer-20190225-22020-mnpzab/.brew_home/Library/Caches/pip/wheels/84/20/3d/dc2010b4f7c0b786a06947530a962972caead0c58898f25a02
  Building wheel for biplist (setup.py): started
  Building wheel for biplist (setup.py): finished with status 'done'
  Stored in directory: /private/tmp/nslocalizer-20190225-22020-mnpzab/.brew_home/Library/Caches/pip/wheels/e1/a5/ce/28ba6a80c2487f54deec4a2eda7ccda8bcbeeec2aad39e9779
  Building wheel for marisa-trie (setup.py): started
  Building wheel for marisa-trie (setup.py): finished with status 'done'
  Stored in directory: /private/tmp/nslocalizer-20190225-22020-mnpzab/.brew_home/Library/Caches/pip/wheels/45/24/79/022624fc914f0e559fe8a1141aaff1f9df810905a13fc75d57
Successfully built pbPlist langcodes biplist marisa-trie
Installing collected packages: pyobjc-core, pyobjc-framework-Cocoa, biplist, pbPlist, marisa-trie, langcodes
Could not install packages due to an EnvironmentError: [Errno 1] Operation not permitted: '/usr/local/lib/python3.7/site-packages/pyobjc_core-5.1.2-py3.7-nspkg.pth'


If reporting this issue please do so at (not Homebrew/brew or Homebrew/core):
https://github.com/samdmarshall/homebrew-formulae/issues

It appears that /usr/local/lib/python3.7 is protected when running brew install for some reason, and it's causing problems with the pip3 install command in the nslocalizer brew formula. I've checked that the permissions on the directory are correct, but installation still fails. I was able to get around it by manually running pip3 install pyobjc-core, pyobjc-framework-Cocoa, biplist, pbPlist, marisa-trie, langcodes, but most users won't know to do that. And even after doing that, I had trouble when trying to update to a newer version of nslocalizer.

This is likely the same cause behind issue #7.

A possible solution is to pass the --user flag to pip3 install. When I modified the home-brew formula to pass that flag, installation succeeded and the issues were resolved. Passing --user does limit the functionality to the current user, but that seems to mostly be the default behavior of homebrew anyway, so that's probably fine?

My xcodeproj is part of a xcworkspace (which has multiple xcodeproj), not sure if this error is related to that?

Type of issue: [ Bug ]

Related Files:

Description:

$ nslocalizer --project <MY_PROJECT>.xcodeproj --target <MY_TARGET> --find-missing
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/pbPlist-1.0.3-py3.7.egg/pbPlist/Switch.py", line 41, in __iter__
    raise StopIteration # pragma: no cover
StopIteration

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/bin/nslocalizer", line 11, in <module>
    load_entry_point('nslocalizer==1.0.1', 'console_scripts', 'nslocalizer')()
  File "/usr/local/lib/python3.7/site-packages/nslocalizer-1.0.1-py3.7.egg/nslocalizer/main.py", line 123, in main
    Executor.run(args)
  File "/usr/local/lib/python3.7/site-packages/nslocalizer-1.0.1-py3.7.egg/nslocalizer/Executor/Executor.py", line 58, in run
    xcodeproj_file = xcodeproj(project_file_path)
  File "/usr/local/lib/python3.7/site-packages/nslocalizer-1.0.1-py3.7.egg/nslocalizer/xcodeproj/xcodeproj.py", line 44, in __init__
    self.project_file = pbProj.PBXProj(pbxproj_file_path)
  File "/usr/local/lib/python3.7/site-packages/nslocalizer-1.0.1-py3.7.egg/nslocalizer/xcodeproj/pbProj/pbProj.py", line 38, in __init__
    plist = pbPlist.pbPlist.PBPlist(file_path)
  File "/usr/local/lib/python3.7/site-packages/pbPlist-1.0.3-py3.7.egg/pbPlist/pbPlist.py", line 41, in __init__
    self.root = parser.read()
  File "/usr/local/lib/python3.7/site-packages/pbPlist-1.0.3-py3.7.egg/pbPlist/pbParser.py", line 118, in read
    parsed_plist = self.__readTest(True)
  File "/usr/local/lib/python3.7/site-packages/pbPlist-1.0.3-py3.7.egg/pbPlist/pbParser.py", line 133, in __readTest
    read_result = self.__parse(requires_object)
  File "/usr/local/lib/python3.7/site-packages/pbPlist-1.0.3-py3.7.egg/pbPlist/pbParser.py", line 142, in __parse
    parsed_item = pbItem.pbItemResolver(self.__parseDict(), 'dictionary') # pylint: disable=redefined-variable-type
  File "/usr/local/lib/python3.7/site-packages/pbPlist-1.0.3-py3.7.egg/pbPlist/pbParser.py", line 256, in __parseDict
    new_object = self.__readTest(False)
  File "/usr/local/lib/python3.7/site-packages/pbPlist-1.0.3-py3.7.egg/pbPlist/pbParser.py", line 133, in __readTest
    read_result = self.__parse(requires_object)
  File "/usr/local/lib/python3.7/site-packages/pbPlist-1.0.3-py3.7.egg/pbPlist/pbParser.py", line 139, in __parse
    for case in Switch(starting_character):
RuntimeError: generator raised StopIteration

Type of issue: [ Bug ]

Description: When using the --ignore <language> option, the language selected to ignore is still listed in the results

Standard --find-missing

➜  imu git:(master) nslocalizer --project Qrof.xcodeproj --target Qrof --find-missing
Base.lproj/Localizable.strings:24: warning: String "lbl_verify_email_1" missing for: Spanish, Korean, Traditional Chinese, Italian, French, German, Simplified Chinese

With --ignore option

➜  imu git:(master) nslocalizer --project Qrof.xcodeproj --target Qrof --ignore French --find-missing
Base.lproj/Localizable.strings:24: warning: String "lbl_verify_email_1" missing for: Italian, French, Simplified Chinese, German, Spanish, Korean, Traditional Chinese

Type of issue: [ Bug ]

Related Files:

None

Description:

Hi! First of all I must say nslocalizer looks like a great tool. Thank you for open-sourcing it! I've installed nslocalizer according to Installation section of readme and I'm using it this way nslocalizer --project Inbbbox.xcodeproj/ --target Inbbbox --find-unused. Unfortunately, it's not working for me, please see crash report. Project I'm trying to check is open-sourced so you can check it for yourself (https://github.com/netguru/inbbbox-ios) Let me know if you need more informations, happy to help to debug this issue.

Crash Report:

Traceback (most recent call last):
  File "/usr/local/Cellar/nslocalizer/1.0/libexec/bin/nslocalizer", line 9, in <module>
    load_entry_point('nslocalizer==1.0', 'console_scripts', 'nslocalizer')()
  File "/usr/local/Cellar/nslocalizer/1.0/libexec/lib/python3.5/site-packages/nslocalizer/main.py", line 117, in main
    Executor.run(args)
  File "/usr/local/Cellar/nslocalizer/1.0/libexec/lib/python3.5/site-packages/nslocalizer/Executor/Executor.py", line 75, in run
    unused_strings = cls.findUnusedStrings(xcodeproj_file, desired_targets)
  File "/usr/local/Cellar/nslocalizer/1.0/libexec/lib/python3.5/site-packages/nslocalizer/Executor/Executor.py", line 98, in findUnusedStrings
    code_files.extend(CodeFinder.getCodeFileList(project.project_file, target))
  File "/usr/local/Cellar/nslocalizer/1.0/libexec/lib/python3.5/site-packages/nslocalizer/Finder/CodeFinder.py", line 45, in getCodeFileList
    all_file_refs = [PathFinder.resolveFilePathForReference(project, build_file.store[pbProj.PBX_Constants.kPBX_BUILDFILE_fileRef]) for build_file in all_build_files]
  File "/usr/local/Cellar/nslocalizer/1.0/libexec/lib/python3.5/site-packages/nslocalizer/Finder/CodeFinder.py", line 45, in <listcomp>
    all_file_refs = [PathFinder.resolveFilePathForReference(project, build_file.store[pbProj.PBX_Constants.kPBX_BUILDFILE_fileRef]) for build_file in all_build_files]
  File "/usr/local/Cellar/nslocalizer/1.0/libexec/lib/python3.5/site-packages/nslocalizer/Finder/PathFinder.py", line 34, in resolveFilePathForReference
    file_path = reference.resolvePath(project)
  File "/usr/local/Cellar/nslocalizer/1.0/libexec/lib/python3.5/site-packages/nslocalizer/xcodeproj/pbProj/PBXItem.py", line 77, in __getattr__
    return getattr(self.store, attrib)
AttributeError: 'dict' object has no attribute 'resolvePath'

Description: brew tap sandmarshall/formulae fails since it can't find the associated github repo

Cloning into '/usr/local/Homebrew/Library/Taps/sandmarshall/homebrew-formulae'...
remote: Repository not found.
fatal: repository 'https://github.com/sandmarshall/homebrew-formulae/' not found
Error: Failure while executing; `git clone https://github.com/sandmarshall/homebrew-formulae /usr/local/Homebrew/Library/Taps/sandmarshall/homebrew-formulae --depth=1` exited with 128.

Title: fixing the code to conform to linting rules

Description: this is a pass at cleaning up the code to conform to the linting rules so i can work with it easier when i start work on this project.

Type of issue: Request

Description:

I am using this lib : https://github.com/PiXeL16/IBLocalizable which allow localization from storyboard.

When I use nslocalizer "--find-unused" all string set via IBLocalizable in storyboard are considered as unused. Is it possible to take IBlocalizable into account ?