Hi,

I'm getting some clipping around the text with the font I'm using

I updated the sizetofit method on THLabel but it removes the clipping only on the right hand side

-(void)sizeToFit
{
    [super sizeToFit];
    CGRect frame = self.frame;
    CGRect expandedFrame = CGRectInset(frame, -self.strokeSize * 2, -self.strokeSize *2);
    [self setFrame:expandedFrame];
    [self setNeedsDisplay];
}

The issue is only visible when using sizeToFit. I have faar to many labels to manually set the frames for them. Any suggestions?

If I render a white THLabel above a white background, you can see it adding a thin black line around the text. This also means that text rendered small will become thinner and disappear quicker than it should.

I'm getting a strange crash in

• (CTFrameRef)frameRefFromSize:(CGSize)size textRectOutput:(CGRect *)textRectOutput CF_RETURNS_RETAINED

when I call it from the did set on text (I'm doing some logic in a subclass to provide better multi-line wrapping)

    override var text: String? {
        didSet {
            wrapText()
        }
    }

it is a bad access at

CFStringRef stringRef = (__bridge CFStringRef)self.text;

I can fix it by replacing that with

    NSString *myString=self.text;

    CFStringRef stringRef = (__bridge CFStringRef)myString;

I don't really understand what is happening here - but something memory related...

There is no way of generating a bounding box for the text given a fixed width, similar to NSAttributedString.boundingRect(with:options:context:)

If you use NSAttributedString.boundingRect(with:options:context:), estimate is wrong and text ends up getting cut off.

I tried out THLabel because I needed a good way to handle shadows on labels. Apparently it was not working for me until I added UIColor *shadowColor to .h. Have you noticed this?

@property (nonatomic, strong) IBInspectable UIColor *shadowColor;

Edit: Using Xcode 6.1, iOS 7.0 project.

Hi,

When I run Analyze I get a "THLabel.m:510:2: Potential leak of an object stored into 'image'" It is in inverseMaskFromAlphaMask the line - return image;

Also there are similar warnings for: THLabel.m:543:2: Potential leak of an object stored into 'image' THLabel.m:583:2: Potential leak of an object stored into 'image'

I installed latest version via cocoa pods. I target iOS 9.0 and higher.

This lines throws a EXC_BAD_ACCES error : CTFramesetterRef framesetterRef = CTFramesetterCreateWithAttributedString(attributedStringRef);

Any idea why ?

THLabel.m line 430:

CTTextAlignment alignment = NSTextAlignmentToCTTextAlignment ? NSTextAlignmentToCTTextAlignment(self.textAlignment) : [self CTTextAlignmentFromNSTextAlignment:self.textAlignment];

gives a warning "Code will never be executed".

Not really a problem, but I like to keep my code warning free, so might be worth fixing for people with similar needs.

I have defined a THLabel programmatically as follows.

THLabel *labelValue4 = [[THLabel alloc] initWithFrame:CGRectMake(20,269,300,85)]; labelValue4.text = @"Spectacular"; labelValue4.font = [UIFont fontWithName:@"Arial Rounded MT Bold" size: 57.0]; labelValue4.textColor = [UIColor colorWithRed:52/255.f green:152/255.f blue:255/255.f alpha:1.0]; labelValue4.textAlignment = NSTextAlignmentLeft; labelValue4.numberOfLines = 1; labelValue4.backgroundColor = [UIColor clearColor]; labelValue4.strokeColor = [UIColor blackColor]; labelValue4.strokeSize = 1.0; [self.view addSubview:labelValue4];

What I want is if the word is large like "spectacular" then it should adjust the size of the font automatically but it doesn't. It just chops off the word. How can I fix that? By the way really nice with THLabel.

Or I get this for labelValue4.text = @"Partly Cloudy"; dot dot dot

Hello, I used THLabel 1.0.3 and it works fine in my app. But after updating to THLabel 1.3.1, it has Chinese font vertical alignment problem. English font is normal . How can I solve this problem ?

Hello,

I may be wrong but in the requirements sections of THLabel i read "iOS 4.0 or higher" and I assumed it could be used on devices running on iOS 4, 5,... but the use in the code of NSTextAlignmentToCTTextAlignment makes the code crash on devices under iOs 6.

Maybe it would be nice to just precise it on the description.

Anyway the label is really nice , thanks, too bad does not work on iOs 5 =)

Bye

Hi!

I'm trying to use THLabel to create a solid white background around my label that follows the shape of the text. It looks fine mostly, but some letters can cause holes in the stroke's shape, which makes it a bit ugly.

The following image shows the problem with the letter 'i':

And the desired output would be:

I've come up with a temporary solution, but it's probably not the most optimal. In the strokeImageWithRect function I've applied a 1px white shadow on the clipping mask, then used this idea to "remove" the opacity of the blurred shadow edges: https://stackoverflow.com/questions/14622202/can-cgcontextcliptomask-mask-all-non-transparent-pixels-with-alpha-1

I wonder if there's any better way of filling the holes directly on the clipping mask's path, without using a shadow.

I used this label to display an attributed string but it did not work with underline or strike through. I tried to set stroke size to a large number without changing its bounds and recognized that there might be loss of text. How could I do to keep the content and number of lines if stroke size goes up?

Hi

I had some free time and made swift version of you subclass. You can check it there https://github.com/IGRSoft/THLabel :branch => swift

If you like it, you can make a swift branch and I'll make pull request :)

Have a nice day ;)

I used this label in a game that was running 60fps. My entire game update loop ran about 40% of the CPU at the my intense parts. THLabel ran at 14%. Those percentages are over a minute of gameplay with the THLabel changing its text once a second.

I had to work around it with snapshots of THLabels for various words generated before the game starts.

However, looking at the DrawRect briefly I see some places for speed improvements. It will likely never be fast enough for 60fps rendering as I know Core Text can be extremely expensive. But every little bit of CPU we can save means better battery life under normal operating conditions.

As people fill this thread with ideas, I'll see if I can find time to implement a few.